Github messages for voidlinux
 help / color / mirror / Atom feed
From: Calandracas606 <Calandracas606@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: OpenCL-SDK
Date: Thu, 18 Jan 2024 13:32:33 +0100	[thread overview]
Message-ID: <20240118123233.8C361216DD@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48261@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48261#issuecomment-1898394976

Comment:
> Please tag maintainers when you propose to restructure their packages, especially if "restructure" means "kidnap".

My apologies, I should have contacted you prior to submitting this PR

> What benefit accrues from the SDK as packaged? The major bits are available as standalone packages and could be built separately as independent packages. The SDK itself just makes for an awkward template and adds a utility library that doesn't seem to be used anywhere. It's usually desired to wait until some "end-user" application to be packaged for Void requires libraries (including header-only libraries) before packaging the libraries themselves, so CLHPP and the utility library could just as well wait until they are needed.

You're right, it isn't currently needed by any packages. Existing void packages only use OpenCL-Headers, so CLHPP and utility libraries are only useful as a development tool.

> The ICD loader may have some value, but what is the argument for replacing the existing loader with this? Yes, it comes from Khronos, but yanking an existing package out from users and replacing it with another may not be the right choice.

 There is nothing wrong with the existing ICD loader. I only changed it because this one comes from Khronos


Closing because It is clear that this PR is overzealous, and isn't currently a good fit for inclusion in void.

  parent reply	other threads:[~2024-01-18 12:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 23:59 [PR PATCH] " Calandracas606
2024-01-18  0:50 ` Calandracas606
2024-01-18  0:59 ` [PR PATCH] [Updated] " Calandracas606
2024-01-18  1:00 ` Calandracas606
2024-01-18  1:07 ` [PR PATCH] [Updated] " Calandracas606
2024-01-18  3:56 ` Calandracas606
2024-01-18  6:41 ` ahesford
2024-01-18 12:32 ` Calandracas606 [this message]
2024-01-18 12:32 ` [PR PATCH] [Closed]: " Calandracas606
2024-01-18 12:48 ` ahesford
2024-01-18 12:48 ` ahesford
2024-01-18 13:41 ` Calandracas606
2024-01-18 15:09 ` [PR PATCH] [Updated] " Calandracas606
2024-01-18 15:17 ` Calandracas606
2024-01-18 15:41 ` [PR PATCH] [Updated] " Calandracas606
2024-02-13 23:28 ` [PR PATCH] [Closed]: " Calandracas606
2024-02-13 23:28 ` Calandracas606

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240118123233.8C361216DD@inbox.vuxu.org \
    --to=calandracas606@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).