From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [RFC] xbps-src: add -A flag for host arch, create masterdir per host arch
Date: Mon, 22 Jan 2024 20:58:49 +0100 [thread overview]
Message-ID: <20240122195849.4D42923A80@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46263@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/46263#discussion_r1462351631
Comment:
```suggestion
else
: "${XBPS_MASTERDIR:=$XBPS_DISTDIR/masterdir-$XBPS_MACHINE}"
if [ ! -d "${XBPS_MASTERDIR}" && -d "${XBPS_DISTDIR}/masterdir" ]; then
XBPS_MASTERDIR="${XBPS_DISTDIR}/masterdir"
fi
```
This avoids the need to break builds with existing `masterdir`.
next prev parent reply other threads:[~2024-01-22 19:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 7:52 [PR PATCH] " classabbyamp
2023-09-26 8:00 ` [PR PATCH] [Updated] " classabbyamp
2023-09-26 8:10 ` classabbyamp
2023-09-26 8:11 ` classabbyamp
2023-09-26 8:13 ` classabbyamp
2023-09-26 8:17 ` classabbyamp
2023-09-26 11:43 ` lemmi
2023-09-26 18:51 ` SpidFightFR
2023-09-26 18:53 ` [PR REVIEW] " classabbyamp
2023-12-26 1:45 ` github-actions
2023-12-26 17:54 ` [PR PATCH] [Updated] " classabbyamp
2024-01-17 4:34 ` classabbyamp
2024-01-17 4:46 ` classabbyamp
2024-01-17 4:50 ` classabbyamp
2024-01-17 4:51 ` classabbyamp
2024-01-17 5:02 ` classabbyamp
2024-01-17 5:44 ` classabbyamp
2024-01-17 6:50 ` [PR PATCH] [Updated] [RFC] xbps-src: add -A flag for host arch, create buildroot per host arch, rename masterdir to buildroot classabbyamp
2024-01-22 18:00 ` classabbyamp
2024-01-22 19:58 ` ahesford [this message]
2024-01-22 20:15 ` [PR PATCH] [Updated] [RFC] xbps-src: add -A flag for host arch, create masterdir per host arch classabbyamp
2024-01-23 3:57 ` [PR PATCH] [Merged]: " the-maldridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122195849.4D42923A80@inbox.vuxu.org \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).