Github messages for voidlinux
 help / color / mirror / Atom feed
From: tranzystorekk <tranzystorekk@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: minijinja-cli-1.0.12
Date: Tue, 23 Jan 2024 11:20:16 +0100	[thread overview]
Message-ID: <20240123102016.36FA224273@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48336@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

New review comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/48336#discussion_r1463042128

Comment:
I tested out that we can instead use

```
configure_args="--workspace --exclude minijinja-py"
make_install_args="--path minijinja-cli"
```

to build/test the whole workspace except for the unused python bindings that require `python3-devel`, the only caveat being we then also need to reset `configure_args` in `pre_install`.

Not sure if that would be preferable, but still thought I'd put it out here.

  parent reply	other threads:[~2024-01-23 10:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23  9:35 [PR PATCH] " jcgruenhage
2024-01-23 10:19 ` [PR REVIEW] " tranzystorekk
2024-01-23 10:20 ` tranzystorekk [this message]
2024-01-23 13:06 ` jcgruenhage
2024-01-23 13:56 ` tranzystorekk
2024-01-25 12:08 ` [PR PATCH] [Updated] " jcgruenhage
2024-01-25 12:14 ` [PR REVIEW] " jcgruenhage
2024-01-25 12:15 ` jcgruenhage
2024-01-25 12:16 ` tranzystorekk
2024-01-25 12:16 ` jcgruenhage
2024-01-26 12:20 ` jcgruenhage
2024-03-14 11:46 ` [PR PATCH] [Closed]: " jcgruenhage
2024-03-14 11:46 ` jcgruenhage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240123102016.36FA224273@inbox.vuxu.org \
    --to=tranzystorekk@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).