Github messages for voidlinux
 help / color / mirror / Atom feed
From: bitmeise <bitmeise@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] astroid: apply upstream patch to prevent crashes while adding attachments
Date: Wed, 24 Jan 2024 21:10:27 +0100	[thread overview]
Message-ID: <20240124201027.D5C3723D5C@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48355@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

There is an updated pull request by bitmeise against master on the void-packages repository

https://github.com/bitmeise/void-packages astroid016_attachments
https://github.com/void-linux/void-packages/pull/48355

astroid: apply upstream patch to prevent crashes while adding attachments
This update is applying a non-release upstream patch to prevent crashes while adding attachments.
See astroidmail/astroid/issues/726 for more information.

#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, (x68_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/48355.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-astroid016_attachments-48355.patch --]
[-- Type: text/x-diff, Size: 1892 bytes --]

From b628419bd64f21eafcffee34723d253c1aa0bccd Mon Sep 17 00:00:00 2001
From: Bitmeise <ameise@bitparlament.de>
Date: Wed, 24 Jan 2024 17:43:27 +0100
Subject: [PATCH] astroid: apply upstream patch to prevent crashes while adding
 attachments

---
 srcpkgs/astroid/patches/attachements.patch | 23 ++++++++++++++++++++++
 srcpkgs/astroid/template                   |  2 +-
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/astroid/patches/attachements.patch

diff --git a/srcpkgs/astroid/patches/attachements.patch b/srcpkgs/astroid/patches/attachements.patch
new file mode 100644
index 0000000000000..e01e274c324c1
--- /dev/null
+++ b/srcpkgs/astroid/patches/attachements.patch
@@ -0,0 +1,23 @@
+From 7fd64c41435a2b99fb9e0a5770a83ba30cd11450 Mon Sep 17 00:00:00 2001
+From: "Stephan C. Buchert" <scb@irfu.se>
+Date: Wed, 14 Jun 2023 17:44:05 +0200
+Subject: [PATCH] compose_message: to load as byte array, 'file' must be
+ wrapped with copy.
+
+---
+ src/compose_message.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/compose_message.cc b/src/compose_message.cc
+index 189c20f99..329481f40 100644
+--- a/src/compose_message.cc
++++ b/src/compose_message.cc
+@@ -781,7 +781,7 @@ namespace Astroid {
+ 
+     } else {
+       /* load into byte array */
+-      refptr<Gio::File> fle = Glib::wrap (file, false);
++      refptr<Gio::File> fle = Glib::wrap (file, true);
+       refptr<Gio::FileInputStream> istr = fle->read ();
+ 
+       refptr<Glib::Bytes> b;
diff --git a/srcpkgs/astroid/template b/srcpkgs/astroid/template
index c56fbbb1ba358..2bd79b3a9420f 100644
--- a/srcpkgs/astroid/template
+++ b/srcpkgs/astroid/template
@@ -1,7 +1,7 @@
 # Template file for 'astroid'
 pkgname=astroid
 version=0.16
-revision=11
+revision=12
 build_style=cmake
 build_helper=gir
 hostmakedepends="pkg-config scdoc protobuf gobject-introspection"

  parent reply	other threads:[~2024-01-24 20:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 16:49 [PR PATCH] " bitmeise
2024-01-24 19:26 ` oreo639
2024-01-24 19:26 ` oreo639
2024-01-24 20:03 ` [PR PATCH] [Updated] " bitmeise
2024-01-24 20:10 ` bitmeise [this message]
2024-01-24 20:11 ` bitmeise
2024-01-24 20:22 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124201027.D5C3723D5C@inbox.vuxu.org \
    --to=bitmeise@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).