From: kymnob <kymnob@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] base-files: add zsh completions for vkpurge
Date: Sat, 10 Feb 2024 18:43:25 +0100 [thread overview]
Message-ID: <20240210174325.89C7C25B78@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48638@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
New review comment by kymnob on void-packages repository
https://github.com/void-linux/void-packages/pull/48638#discussion_r1485204289
Comment:
> The option `-C` tells `_arguments` to modify the `curcontext` parameter for an action of the form ‘->state'. This is the standard parameter used to keep track of the current context. Here it (and not the context array) should be made local to the calling function to avoid passing back the modified value and should be initialised to the current value at the start of the function:
>
> local curcontext="$curcontext"
>
> This is useful where it is not possible for multiple states to be valid together.
next prev parent reply other threads:[~2024-02-10 17:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 8:00 [PR PATCH] " classabbyamp
2024-02-10 8:02 ` [PR PATCH] [Updated] " classabbyamp
2024-02-10 16:33 ` 0x5c
2024-02-10 17:43 ` [PR REVIEW] " kymnob
2024-02-10 17:43 ` kymnob [this message]
2024-02-10 17:43 ` kymnob
2024-02-10 17:43 ` kymnob
2024-02-10 17:43 ` kymnob
2024-02-10 17:43 ` kymnob
2024-02-10 17:43 ` kymnob
2024-02-10 17:43 ` kymnob
2024-02-10 18:35 ` [PR PATCH] [Updated] " classabbyamp
2024-02-10 19:07 ` [PR REVIEW] " kymnob
2024-02-10 19:07 ` kymnob
2024-02-10 19:08 ` [PR PATCH] [Updated] " classabbyamp
2024-02-12 16:42 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240210174325.89C7C25B78@inbox.vuxu.org \
--to=kymnob@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).