From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: winegui-2.3.5
Date: Sun, 11 Feb 2024 15:18:42 +0100 [thread overview]
Message-ID: <20240211141842.A051127B7C@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48642@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/48642#discussion_r1485603607
Comment:
As I noted on IRC, you should amend your distribution procress so this argument is unnecessary. Relying on the build process to tell you the version number for your own package is bad practice and, as the upstream author, you are in a position to fix it.
next prev parent reply other threads:[~2024-02-11 14:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 21:05 [PR PATCH] " melroy89
2024-02-10 22:42 ` [PR PATCH] [Updated] " melroy89
2024-02-10 22:49 ` melroy89
2024-02-11 0:09 ` [PR PATCH] [Updated] " melroy89
2024-02-11 0:11 ` melroy89
2024-02-11 0:13 ` melroy89
2024-02-11 2:06 ` chrysos349
2024-02-11 3:18 ` [PR PATCH] [Updated] " melroy89
2024-02-11 3:21 ` melroy89
2024-02-11 3:23 ` melroy89
2024-02-11 3:32 ` melroy89
2024-02-11 14:18 ` ahesford [this message]
2024-02-11 15:07 ` [PR REVIEW] " melroy89
2024-02-11 15:14 ` melroy89
2024-02-11 15:46 ` melroy89
2024-02-11 16:47 ` ahesford
2024-02-11 16:48 ` ahesford
2024-02-11 18:19 ` ahesford
2024-02-11 18:19 ` [PR PATCH] [Closed]: " ahesford
2024-02-11 19:30 ` melroy89
2024-02-11 20:18 ` [PR REVIEW] " melroy89
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240211141842.A051127B7C@inbox.vuxu.org \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).