Github messages for voidlinux
 help / color / mirror / Atom feed
From: Bnyro <Bnyro@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: grub-theme-voidlinux-3.2
Date: Sun, 18 Feb 2024 22:17:33 +0100	[thread overview]
Message-ID: <20240218211733.7CBAC25349@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48675@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/48675#issuecomment-1951447665

Comment:
> I also agree to merge. I'm fine to get this simple and lightweight theme getting merged. Too bad you get 'thumbs-down' from others.
> 
> As long as you are also wiling to keep the theme updated in a regular way. I don't see the problem here.
>
That's absolutely not been my personal intention for the "thumbs down". I really like the theme and also would love it to be added here.

The issue for me is
>  I would kindly ask you for the merge. If not, I'll come to terms with the final call to let it die.
>
You're on an open source project, and whenever a maintainer decides to agree with having this new package in the repos it'll be merged - that's just how Void works. There are lots of open pull requests adding new packages - some of them were opened years ago - so it's certainly too early to give up now :)
What however is really annoying if people just always continue asking "When will this be merged?", "Can sonebody merge this now?", ..., I imagine that to be very frustrating for the maintainers / package commiters. You probably didn't intend doing something like this - but text messages are always easy to misinterpret unfortunately.

Sorry for my previous "thumbs down", I should have explained that earlier, I just saw you're new here, so you couldn't know yet.

I'd just propose to re-open this PR, leave it for a while and see what happens - in the best case it'll get merged one day - in the worst case you'll meet some other GRUB theme enjoyers here and learn on improving your package templating skills.

  parent reply	other threads:[~2024-02-18 21:17 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 19:56 [PR PATCH] a neat grub2 theme designed for Void Linux slymattz
2024-02-12 20:47 ` Clos3y
2024-02-12 21:52 ` slymattz
2024-02-12 21:53 ` slymattz
2024-02-13  3:01 ` [PR REVIEW] " classabbyamp
2024-02-13  3:01 ` classabbyamp
2024-02-13  3:01 ` classabbyamp
2024-02-13  3:01 ` classabbyamp
2024-02-13  3:01 ` classabbyamp
2024-02-13 12:11 ` [PR PATCH] [Updated] " slymattz
2024-02-13 12:19 ` [PR REVIEW] New package: grub-theme-voidlinux-3.2 slymattz
2024-02-13 13:11 ` [PR PATCH] [Updated] " slymattz
2024-02-13 13:17 ` [PR REVIEW] " slymattz
2024-02-13 15:11 ` slymattz
2024-02-13 15:11 ` slymattz
2024-02-13 15:13 ` slymattz
2024-02-13 16:15 ` melroy89
2024-02-13 16:25 ` slymattz
2024-02-13 23:02 ` [PR REVIEW] " Bnyro
2024-02-13 23:03 ` Bnyro
2024-02-13 23:05 ` Bnyro
2024-02-13 23:05 ` Bnyro
2024-02-13 23:09 ` [PR PATCH] [Updated] " slymattz
2024-02-13 23:18 ` [PR REVIEW] " Bnyro
2024-02-13 23:19 ` [PR PATCH] [Updated] " slymattz
2024-02-14  0:09 ` slymattz
2024-02-14  0:34 ` slymattz
2024-02-15 18:49 ` slymattz
2024-02-15 20:56 ` [PR PATCH] [Closed]: " slymattz
2024-02-15 21:01 ` caughtquick
2024-02-16 19:15 ` melroy89
2024-02-18 21:17 ` Bnyro [this message]
2024-02-18 21:59 ` [PR PATCH] [Updated] " slymattz
2024-02-18 22:29 ` Bnyro
2024-02-18 22:49 ` [PR PATCH] [Updated] " slymattz
2024-02-18 23:23 ` [PR PATCH] [Closed]: " slymattz
2024-02-18 23:32 ` slymattz
2024-02-18 23:33 ` slymattz
2024-02-18 23:33 ` slymattz
2024-02-18 23:33 ` slymattz
2024-02-19  8:56 ` Bnyro
2024-02-19  8:57 ` Bnyro
2024-02-19 10:40 ` slymattz
2024-02-19 10:42 ` Bnyro
2024-02-19 10:45 ` Bnyro
2024-02-19 10:46 ` slymattz
2024-02-19 10:55 ` slymattz
2024-02-19 10:58 ` Bnyro
2024-02-19 10:58 ` Bnyro
2024-02-19 11:04 ` slymattz
2024-02-19 11:09 ` slymattz
2024-02-19 11:14 ` Bnyro
2024-02-19 11:14 ` Bnyro
2024-02-19 11:24 ` [PR PATCH] [Updated] " slymattz
2024-02-19 11:26 ` slymattz
2024-02-19 11:52 ` Bnyro
2024-02-24  0:37 ` [PR PATCH] [Closed]: " slymattz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240218211733.7CBAC25349@inbox.vuxu.org \
    --to=bnyro@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).