Github messages for voidlinux
 help / color / mirror / Atom feed
From: nuckle <nuckle@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: nekoray 3.26
Date: Mon, 19 Feb 2024 14:31:44 +0100	[thread overview]
Message-ID: <20240219133144.8B83D2917C@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48831@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]

New comment by nuckle on void-packages repository

https://github.com/void-linux/void-packages/pull/48831#issuecomment-1952461860

Comment:
> As far as I know, you should insert distfiles before checksum and remove do_fetch (from what I've learned git clone in do_fetch is not the right way to do it in Void): `distfiles="https://github.com/MatsuriDayo/nekoray/archive/refs/tags/${version}.tar.gz"`
> 
> Oh, and remember to update the sha256sum checksum.

Yes, I checked the order with `xlint`. I tried to create this template without dealing with `do_fetch`, but the issue is that `.tar` doesn't contain any files for 3d party repositories and there's no git repository inside of it. You can't compile nekoray without those repositories, so you have to use something like this 

```
git clone https://github.com/MatsuriDayo/nekoray.git --recursive
```

or this

```
git clone \
 --branch ${version} \
 https://github.com/MatsuriDayo/${pkgname}.git ${wrksrc}/${pkgname}
cd ${wrksrc}/${pkgname}
git submodule init
git submodule update
```

to get them. Also there's an issue with database packages. I tried to use `build_style=go`, but looks like the binary is useless and the only way to make use of it is to run it directly with `go run -v .`, but I don't really know how to do it properly in Void's template format, so it's kind of a mess too

  parent reply	other threads:[~2024-02-19 13:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 10:26 [PR PATCH] Nekoray nuckle
2024-02-19 12:41 ` New package: nekoray 3.26 slymattz
2024-02-19 13:31 ` nuckle [this message]
2024-02-19 13:33 ` nuckle
2024-02-19 13:38 ` nuckle
2024-02-19 13:46 ` slymattz
2024-02-19 13:48 ` slymattz
2024-02-19 13:49 ` chrysos349
2024-02-19 13:58 ` chrysos349
2024-02-19 14:29 ` nuckle
2024-02-19 19:54 ` [PR PATCH] [Updated] " nuckle
2024-02-19 19:55 ` nuckle
2024-02-19 21:34 ` nuckle
2024-02-19 22:30 ` nuckle
2024-02-20  7:08 ` nuckle
2024-02-20  7:25 ` [PR REVIEW] " chrysos349
2024-02-20  7:34 ` [PR PATCH] [Updated] " nuckle
2024-02-20  8:11 ` nuckle
2024-02-20  8:15 ` nuckle
2024-02-20  8:20 ` nuckle
2024-02-28 20:01 ` nuckle
2024-02-28 20:04 ` nuckle
2024-02-28 20:11 ` nuckle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240219133144.8B83D2917C@inbox.vuxu.org \
    --to=nuckle@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).