Github messages for voidlinux
 help / color / mirror / Atom feed
From: ypsvlq <ypsvlq@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] attract: respect cflags
Date: Thu, 22 Feb 2024 11:11:45 +0100	[thread overview]
Message-ID: <20240222101145.34C8820D66@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48757@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

There is an updated pull request by ypsvlq against master on the void-packages repository

https://github.com/ypsvlq/void-packages master
https://github.com/void-linux/void-packages/pull/48757

attract: respect cflags
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/48757.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-48757.patch --]
[-- Type: text/x-diff, Size: 1921 bytes --]

From afe09b186255663ae9494bf04b5788e22a2fb14b Mon Sep 17 00:00:00 2001
From: Elaine Gibson <ypsvlq@gmail.com>
Date: Fri, 16 Feb 2024 10:21:04 +0000
Subject: [PATCH] attract: respect cflags

---
 srcpkgs/attract/patches/Makefile.patch | 25 +++++++++++++++++--------
 srcpkgs/attract/template               |  2 +-
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/attract/patches/Makefile.patch b/srcpkgs/attract/patches/Makefile.patch
index 6310a9fd365269..434c08dea38958 100644
--- a/srcpkgs/attract/patches/Makefile.patch
+++ b/srcpkgs/attract/patches/Makefile.patch
@@ -1,16 +1,16 @@
-diff --git a/Makefile.orig b/Makefile
-index 4f4793a9a69..b1f7cf469f4 100644
---- a/Makefile.orig
+diff --git a/Makefile b/Makefile
+index 4f4793a..82387e0 100644
+--- a/Makefile
 +++ b/Makefile
-@@ -69,15 +69,10 @@
+@@ -69,15 +69,7 @@
  
  FE_VERSION=v2.7.0
  
 -CC=gcc
 -CXX=g++
- CFLAGS=
- CXXFLAGS=-std=c++11 $(EXTRA_CXXFLAGS)
- CPPFLAGS=
+-CFLAGS=
+-CXXFLAGS=-std=c++11 $(EXTRA_CXXFLAGS)
+-CPPFLAGS=
 -STRIP=strip
 -OBJCOPY=objcopy
  PKG_CONFIG=pkg-config
@@ -18,7 +18,16 @@ index 4f4793a9a69..b1f7cf469f4 100644
  ARFLAGS=rc
  RM=rm -f
  MD=mkdir -p
-@@ -512,7 +507,7 @@ $(OBJ_DIR)/%.o: $(SRC_DIR)/%.mm $(DEP) | $(OBJ_DIR)
+@@ -308,7 +300,7 @@ ifeq ($(FE_DEBUG),1)
+  FE_FLAGS += -DFE_DEBUG
+  ENABLE_DEBUG_SYMBOLS=1
+ else
+- CPPFLAGS += -O$(OPTIMIZE) -DNDEBUG
++ CPPFLAGS += -DNDEBUG
+ endif
+ 
+ ifeq ($(USE_GLES),1)
+@@ -512,7 +504,7 @@ $(OBJ_DIR)/%.o: $(SRC_DIR)/%.mm $(DEP) | $(OBJ_DIR)
  
  $(EXE): $(OBJ) $(EXPAT) $(SQUIRREL) $(AUDIO)
  	$(EXE_MSG)
diff --git a/srcpkgs/attract/template b/srcpkgs/attract/template
index e769fb15456217..776cbe4ebd2c93 100644
--- a/srcpkgs/attract/template
+++ b/srcpkgs/attract/template
@@ -1,7 +1,7 @@
 # Template file for 'attract'
 pkgname=attract
 version=2.7.0
-revision=1
+revision=2
 build_style=gnu-makefile
 make_build_args="VERBOSE=1"
 make_use_env=yes

      parent reply	other threads:[~2024-02-22 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 10:25 [PR PATCH] " ypsvlq
2024-02-22  9:35 ` [PR REVIEW] " sgn
2024-02-22 10:11 ` ypsvlq [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222101145.34C8820D66@inbox.vuxu.org \
    --to=ypsvlq@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).