Re: [PR PATCH] [Updated] pdfpc: disable REST server

[oreo639 <oreo639@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages pdfpc
https://github.com/void-linux/void-packages/pull/48959

pdfpc: disable REST server
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Build with webkit2gtk-4.1, which provides an identical api to webkit2gtk-4.0 except it uses libsoup3.
The REST server functionality requires libsoup2. libsoup2 and libsoup3 cannot be loaded in the same process at the same time.

One of the maintainers recommended just disabling the rest server and building the markdown presentation notes viewer with webkit2gtk-4.1 stating that as far as he knows, he is the only one that actually uses the rest server function. https://github.com/pdfpc/pdfpc/issues/671#issuecomment-1552713117

I was wondering if anyone here that uses pdfpc uses the rest server function?

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/48959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pdfpc-48959.patch --]
[-- Type: text/x-diff, Size: 1549 bytes --]

From f00c2e41dd9a59a9a3b75f6efd9872485b512b5e Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Mon, 26 Feb 2024 16:29:40 -0800
Subject: [PATCH] pdfpc: disable REST server

Build with libwebkit2gtk41
REST functionality cannot be used with libwebkit2gtk41 since it uses libsoup2.
---
 srcpkgs/pdfpc/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pdfpc/template b/srcpkgs/pdfpc/template
index 450a9f300730ea..c5eff73cd6fabd 100644
--- a/srcpkgs/pdfpc/template
+++ b/srcpkgs/pdfpc/template
@@ -1,16 +1,21 @@
 # Template file for 'pdfpc'
 pkgname=pdfpc
 version=4.6.0
-revision=1
+revision=2
 build_style=cmake
+configure_args="-DREST=OFF"
 hostmakedepends="pkg-config vala libgee08-devel"
 makedepends="gst-plugins-base1-devel gtk+3-devel libgee08-devel
  libzstd-devel poppler-glib-devel json-glib-devel vala-devel
- webkit2gtk-devel discount-devel qrencode-devel"
+ libwebkit2gtk41-devel discount-devel"
 short_desc="Presenter console with multi-monitor support for PDF files"
 maintainer="Aaron Marcher <info@nulltime.net>"
 license="GPL-2.0-or-later"
 homepage="https://pdfpc.github.io/"
-changelog="https://raw.githubusercontent.com/pdfpc/pdfpc/master/CHANGELOG.txt"
+changelog="https://raw.githubusercontent.com/pdfpc/pdfpc/master/CHANGELOG.rst"
 distfiles="https://github.com/pdfpc/pdfpc/archive/v${version}.tar.gz"
 checksum=3b1a393f36a1b0ddc29a3d5111d8707f25fb2dd2d93b0401ff1c66fa95f50294
+
+post_patch() {
+	vsed -e 's/webkit2gtk-4.0/webkit2gtk-4.1/' -i src/CMakeLists.txt
+}