* [PR PATCH] foliate: add missing libadwaita dependency
@ 2024-02-29 10:40 lipidity
2024-02-29 10:42 ` sgn
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: lipidity @ 2024-02-29 10:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
There is a new pull request by lipidity against master on the void-packages repository
https://github.com/lipidity/void-packages patch-1
https://github.com/void-linux/void-packages/pull/49000
foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch with the following error:
```
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28 @gi://Adw?version=1:3:25
```
#### Testing the changes
- I tested the changes in this PR: **briefly** (foliate stopped crashing after I installed libadwaita)
A patch file from https://github.com/void-linux/void-packages/pull/49000.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-49000.patch --]
[-- Type: text/x-diff, Size: 1151 bytes --]
From a242fa8fcd27c7a064452ae4dd7e275b296fe565 Mon Sep 17 00:00:00 2001
From: Ankur Kothari <ankur@lipidity.com>
Date: Thu, 29 Feb 2024 21:36:10 +1100
Subject: [PATCH] foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch with the following error:
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found
require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28
@gi://Adw?version=1:3:25
---
srcpkgs/foliate/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/foliate/template b/srcpkgs/foliate/template
index f841cad354740..f1ef7b61cebae 100644
--- a/srcpkgs/foliate/template
+++ b/srcpkgs/foliate/template
@@ -6,7 +6,7 @@ build_style=meson
hostmakedepends="pkg-config gettext glib-devel
gtk4-update-icon-cache desktop-file-utils"
makedepends="gjs-devel gtk4-devel libadwaita-devel libwebkitgtk60-devel"
-depends="libwebkitgtk60 gjs"
+depends="libwebkitgtk60 gjs libadwaita"
checkdepends="desktop-file-utils appstream-glib"
short_desc="Simple and modern GTK eBook reader"
maintainer="Orphaned <orphan@voidlinux.org>"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: foliate: add missing libadwaita dependency
2024-02-29 10:40 [PR PATCH] foliate: add missing libadwaita dependency lipidity
@ 2024-02-29 10:42 ` sgn
2024-02-29 10:49 ` [PR PATCH] [Updated] " lipidity
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2024-02-29 10:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/49000#issuecomment-1970862958
Comment:
Bump revision to 2, please.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] foliate: add missing libadwaita dependency
2024-02-29 10:40 [PR PATCH] foliate: add missing libadwaita dependency lipidity
2024-02-29 10:42 ` sgn
@ 2024-02-29 10:49 ` lipidity
2024-02-29 10:53 ` oreo639
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: lipidity @ 2024-02-29 10:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
There is an updated pull request by lipidity against master on the void-packages repository
https://github.com/lipidity/void-packages patch-1
https://github.com/void-linux/void-packages/pull/49000
foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch with the following error:
```
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28 @gi://Adw?version=1:3:25
```
#### Testing the changes
- I tested the changes in this PR: **briefly** (foliate stopped crashing after I installed libadwaita)
A patch file from https://github.com/void-linux/void-packages/pull/49000.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-49000.patch --]
[-- Type: text/x-diff, Size: 1831 bytes --]
From a242fa8fcd27c7a064452ae4dd7e275b296fe565 Mon Sep 17 00:00:00 2001
From: Ankur Kothari <ankur@lipidity.com>
Date: Thu, 29 Feb 2024 21:36:10 +1100
Subject: [PATCH 1/2] foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch with the following error:
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found
require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28
@gi://Adw?version=1:3:25
---
srcpkgs/foliate/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/foliate/template b/srcpkgs/foliate/template
index f841cad3547400..f1ef7b61cebae5 100644
--- a/srcpkgs/foliate/template
+++ b/srcpkgs/foliate/template
@@ -6,7 +6,7 @@ build_style=meson
hostmakedepends="pkg-config gettext glib-devel
gtk4-update-icon-cache desktop-file-utils"
makedepends="gjs-devel gtk4-devel libadwaita-devel libwebkitgtk60-devel"
-depends="libwebkitgtk60 gjs"
+depends="libwebkitgtk60 gjs libadwaita"
checkdepends="desktop-file-utils appstream-glib"
short_desc="Simple and modern GTK eBook reader"
maintainer="Orphaned <orphan@voidlinux.org>"
From c9355d4c75b539fd44c9827956e3da41f06fac2d Mon Sep 17 00:00:00 2001
From: Ankur Kothari <ankur@lipidity.com>
Date: Thu, 29 Feb 2024 21:48:26 +1100
Subject: [PATCH 2/2] foliate: bump revision 1 -> 2
---
srcpkgs/foliate/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/foliate/template b/srcpkgs/foliate/template
index f1ef7b61cebae5..7e3e5d230373cf 100644
--- a/srcpkgs/foliate/template
+++ b/srcpkgs/foliate/template
@@ -1,7 +1,7 @@
# Template file for 'foliate'
pkgname=foliate
version=3.1.0
-revision=1
+revision=2
build_style=meson
hostmakedepends="pkg-config gettext glib-devel
gtk4-update-icon-cache desktop-file-utils"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: foliate: add missing libadwaita dependency
2024-02-29 10:40 [PR PATCH] foliate: add missing libadwaita dependency lipidity
2024-02-29 10:42 ` sgn
2024-02-29 10:49 ` [PR PATCH] [Updated] " lipidity
@ 2024-02-29 10:53 ` oreo639
2024-02-29 10:53 ` [PR PATCH] [Updated] " lipidity
2024-02-29 11:03 ` [PR PATCH] [Merged]: " oreo639
4 siblings, 0 replies; 6+ messages in thread
From: oreo639 @ 2024-02-29 10:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/49000#issuecomment-1970880481
Comment:
It needs to be one commit, you can do:
```
git reset --soft HEAD~
git commit --amend
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] foliate: add missing libadwaita dependency
2024-02-29 10:40 [PR PATCH] foliate: add missing libadwaita dependency lipidity
` (2 preceding siblings ...)
2024-02-29 10:53 ` oreo639
@ 2024-02-29 10:53 ` lipidity
2024-02-29 11:03 ` [PR PATCH] [Merged]: " oreo639
4 siblings, 0 replies; 6+ messages in thread
From: lipidity @ 2024-02-29 10:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
There is an updated pull request by lipidity against master on the void-packages repository
https://github.com/lipidity/void-packages patch-1
https://github.com/void-linux/void-packages/pull/49000
foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch with the following error:
```
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28 @gi://Adw?version=1:3:25
```
#### Testing the changes
- I tested the changes in this PR: **briefly** (foliate stopped crashing after I installed libadwaita)
A patch file from https://github.com/void-linux/void-packages/pull/49000.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-49000.patch --]
[-- Type: text/x-diff, Size: 1039 bytes --]
From d1cf28cbb78ce5e7d5233d67a600112b7e30d55e Mon Sep 17 00:00:00 2001
From: Ankur Kothari <ankur@lipidity.com>
Date: Thu, 29 Feb 2024 21:36:10 +1100
Subject: [PATCH] foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch.
---
srcpkgs/foliate/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/foliate/template b/srcpkgs/foliate/template
index f841cad3547400..7e3e5d230373cf 100644
--- a/srcpkgs/foliate/template
+++ b/srcpkgs/foliate/template
@@ -1,12 +1,12 @@
# Template file for 'foliate'
pkgname=foliate
version=3.1.0
-revision=1
+revision=2
build_style=meson
hostmakedepends="pkg-config gettext glib-devel
gtk4-update-icon-cache desktop-file-utils"
makedepends="gjs-devel gtk4-devel libadwaita-devel libwebkitgtk60-devel"
-depends="libwebkitgtk60 gjs"
+depends="libwebkitgtk60 gjs libadwaita"
checkdepends="desktop-file-utils appstream-glib"
short_desc="Simple and modern GTK eBook reader"
maintainer="Orphaned <orphan@voidlinux.org>"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: foliate: add missing libadwaita dependency
2024-02-29 10:40 [PR PATCH] foliate: add missing libadwaita dependency lipidity
` (3 preceding siblings ...)
2024-02-29 10:53 ` [PR PATCH] [Updated] " lipidity
@ 2024-02-29 11:03 ` oreo639
4 siblings, 0 replies; 6+ messages in thread
From: oreo639 @ 2024-02-29 11:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
There's a merged pull request on the void-packages repository
foliate: add missing libadwaita dependency
https://github.com/void-linux/void-packages/pull/49000
Description:
When libadwaita is not installed, foliate crashes on launch with the following error:
```
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28 @gi://Adw?version=1:3:25
```
#### Testing the changes
- I tested the changes in this PR: **briefly** (foliate stopped crashing after I installed libadwaita)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-29 11:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-29 10:40 [PR PATCH] foliate: add missing libadwaita dependency lipidity
2024-02-29 10:42 ` sgn
2024-02-29 10:49 ` [PR PATCH] [Updated] " lipidity
2024-02-29 10:53 ` oreo639
2024-02-29 10:53 ` [PR PATCH] [Updated] " lipidity
2024-02-29 11:03 ` [PR PATCH] [Merged]: " oreo639
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).