Re: [PR PATCH] [Updated] foliate: add missing libadwaita dependency

[lipidity <lipidity@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

There is an updated pull request by lipidity against master on the void-packages repository

https://github.com/lipidity/void-packages patch-1
https://github.com/void-linux/void-packages/pull/49000

foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch with the following error:

```
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28 @gi://Adw?version=1:3:25
```
#### Testing the changes
- I tested the changes in this PR: **briefly** (foliate stopped crashing after I installed libadwaita)

A patch file from https://github.com/void-linux/void-packages/pull/49000.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-49000.patch --]
[-- Type: text/x-diff, Size: 1831 bytes --]

From a242fa8fcd27c7a064452ae4dd7e275b296fe565 Mon Sep 17 00:00:00 2001
From: Ankur Kothari <ankur@lipidity.com>
Date: Thu, 29 Feb 2024 21:36:10 +1100
Subject: [PATCH 1/2] foliate: add missing libadwaita dependency

When libadwaita is not installed, foliate crashes on launch with the following error:

JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found
require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28
@gi://Adw?version=1:3:25
---
 srcpkgs/foliate/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/foliate/template b/srcpkgs/foliate/template
index f841cad3547400..f1ef7b61cebae5 100644
--- a/srcpkgs/foliate/template
+++ b/srcpkgs/foliate/template
@@ -6,7 +6,7 @@ build_style=meson
 hostmakedepends="pkg-config gettext glib-devel
  gtk4-update-icon-cache desktop-file-utils"
 makedepends="gjs-devel gtk4-devel libadwaita-devel libwebkitgtk60-devel"
-depends="libwebkitgtk60 gjs"
+depends="libwebkitgtk60 gjs libadwaita"
 checkdepends="desktop-file-utils appstream-glib"
 short_desc="Simple and modern GTK eBook reader"
 maintainer="Orphaned <orphan@voidlinux.org>"

From c9355d4c75b539fd44c9827956e3da41f06fac2d Mon Sep 17 00:00:00 2001
From: Ankur Kothari <ankur@lipidity.com>
Date: Thu, 29 Feb 2024 21:48:26 +1100
Subject: [PATCH 2/2] foliate: bump revision 1 -> 2

---
 srcpkgs/foliate/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/foliate/template b/srcpkgs/foliate/template
index f1ef7b61cebae5..7e3e5d230373cf 100644
--- a/srcpkgs/foliate/template
+++ b/srcpkgs/foliate/template
@@ -1,7 +1,7 @@
 # Template file for 'foliate'
 pkgname=foliate
 version=3.1.0
-revision=1
+revision=2
 build_style=meson
 hostmakedepends="pkg-config gettext glib-devel
  gtk4-update-icon-cache desktop-file-utils"