From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: gocryptfs: update to 2.4.0, enable OpenSSL
Date: Fri, 01 Mar 2024 16:13:06 +0100 [thread overview]
Message-ID: <20240301151306.22D6F289D7@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48949@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2093 bytes --]
There's a merged pull request on the void-packages repository
gocryptfs: update to 2.4.0, enable OpenSSL
https://github.com/void-linux/void-packages/pull/48949
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
---
Enabling OpenSSL fixes `gocryptfs -speed` crashing. Before:
```
$ gocryptfs -speed
gocryptfs v2.3.1 without_openssl; go-fuse [vendored]; 2023-10-02 go1.21.1 linux/amd64
cpu: AMD EPYC 7702P 64-Core Processor; with AES acceleration
AES-GCM-256-OpenSSL panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5aab40]
goroutine 7 [running]:
testing.(*common).decorate(0x40f2c5?, {0xc00001a210, 0x2a}, 0x83d801?)
/usr/lib/go/src/testing/testing.go:772 +0xa0
testing.(*common).logDepth(0xc000140280, {0xc00001a210, 0x2a}, 0x3)
/usr/lib/go/src/testing/testing.go:1035 +0x1dd
testing.(*common).log(...)
/usr/lib/go/src/testing/testing.go:1004
testing.(*common).Skip(0xc000140280, {0xc00004ef08?, 0x48a7af?, 0xc00004ef18?})
/usr/lib/go/src/testing/testing.go:1089 +0x4a
github.com/rfjakob/gocryptfs/v2/internal/speed.bStupidGCM(0xc000140280)
/builddir/gocryptfs-2.3.1/internal/speed/speed.go:125 +0x45
testing.(*B).runN(0xc000140280, 0x1)
/usr/lib/go/src/testing/benchmark.go:193 +0x102
testing.(*B).run1.func1()
/usr/lib/go/src/testing/benchmark.go:233 +0x4e
created by testing.(*B).run1 in goroutine 1
/usr/lib/go/src/testing/benchmark.go:226 +0x90
```
After:
```
$ gocryptfs -speed
gocryptfs v2.4.0; go-fuse [vendored]; 2024-02-26 go1.22.0 linux/amd64
cpu: AMD EPYC 7702P 64-Core Processor; with AES acceleration
AES-GCM-256-OpenSSL 1459.24 MB/s
AES-GCM-256-Go 3129.59 MB/s (selected in auto mode)
AES-SIV-512-Go 228.40 MB/s
XChaCha20-Poly1305-OpenSSL 883.58 MB/s
XChaCha20-Poly1305-Go 1643.98 MB/s (selected in auto mode)
```
Maintainer ping: @fnogcps
prev parent reply other threads:[~2024-03-01 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 6:27 [PR PATCH] " mvf
2024-03-01 15:13 ` ahesford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301151306.22D6F289D7@inbox.vuxu.org \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).