From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: qbe: update to 1.2.
Date: Sat, 02 Mar 2024 12:31:57 +0100 [thread overview]
Message-ID: <20240302113157.A19202280E@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49016@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/49016#issuecomment-1974769506
Comment:
The way you have it set up, make doesn't run in `do_build()` when native compiling.
The object files getting compiled `do_install()` is not correct as the variables set when running `do_install()` are not necessarily the same as with `do_build()`.
You don't need to use a custom `do_build()` here, there is a variable `make_build_args` for this purpose, although as Duncaen said, the correct fix is to remove the CC assignment in the makefile using vsed so that the compiler can be specified by the environment.
next prev parent reply other threads:[~2024-03-02 11:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 9:06 [PR PATCH] " echoptic
2024-03-01 9:10 ` oreo639
2024-03-01 9:43 ` echoptic
2024-03-01 9:46 ` oreo639
2024-03-01 10:53 ` echoptic
2024-03-01 11:08 ` [PR PATCH] [Updated] " echoptic
2024-03-01 14:14 ` echoptic
2024-03-01 14:15 ` echoptic
2024-03-01 16:57 ` Duncaen
2024-03-01 17:00 ` Duncaen
2024-03-01 17:01 ` Duncaen
2024-03-01 17:02 ` [PR REVIEW] " Duncaen
2024-03-02 10:15 ` [PR PATCH] [Updated] " echoptic
2024-03-02 10:15 ` [PR REVIEW] " echoptic
2024-03-02 10:59 ` echoptic
2024-03-02 11:23 ` oreo639
2024-03-02 11:31 ` oreo639 [this message]
2024-03-02 11:44 ` [PR PATCH] [Updated] " echoptic
2024-03-02 11:46 ` echoptic
2024-03-02 11:50 ` echoptic
2024-03-02 11:52 ` echoptic
2024-03-02 12:07 ` [PR PATCH] [Updated] " echoptic
2024-03-07 20:46 ` echoptic
2024-03-10 20:29 ` [PR PATCH] [Merged]: " cinerea0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302113157.A19202280E@inbox.vuxu.org \
--to=oreo639@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).