From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: strace: revbump
Date: Sat, 02 Mar 2024 22:34:43 +0100 [thread overview]
Message-ID: <20240302213443.724ED25476@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49037@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/49037#issuecomment-1974915176
Comment:
The message is coming from glibc: https://github.com/bminor/glibc/blob/d370155b9ab73d0c45bf968b7a9c823f4697a505/sysdeps/x86_64/dl-machine.h#L460
`_UPD_accessors` is a variable defined by libunwind that gets externed and the struct size was changed here: https://github.com/libunwind/libunwind/commit/d7e59261feb4f9425728ae08031bee3d5bf6e48a
The only use of `_UPD_accessors` in strace is passing its pointer back in to libunwind so afaict it shouldn't cause any noticeable issues in this instance: https://github.com/strace/strace/blob/8c480270653da45370fe44871dfdf18647bb0951/src/unwind-libunwind.c#L24
That being said, it should still be rebuilt as this is an ABI break.
Update the commit message to include the reason for the revbump and include the libunwind commit in the commit description.
next prev parent reply other threads:[~2024-03-02 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 20:25 [PR PATCH] " meator
2024-03-02 20:55 ` icp1994
2024-03-02 21:34 ` oreo639 [this message]
2024-03-02 21:47 ` [PR PATCH] [Updated] " meator
2024-03-03 1:03 ` [PR PATCH] [Merged]: strace: rebuild against newer libunwind oreo639
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302213443.724ED25476@inbox.vuxu.org \
--to=oreo639@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).