Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: msitools-0.103
@ 2023-11-22 22:27 elbeardmorez
  2023-11-30  8:40 ` [PR PATCH] [Updated] " elbeardmorez
                   ` (20 more replies)
  0 siblings, 21 replies; 22+ messages in thread
From: elbeardmorez @ 2023-11-22 22:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

There is a new pull request by elbeardmorez against master on the void-packages repository

https://github.com/elbeardmorez/void-packages xbps_msitools
https://github.com/void-linux/void-packages/pull/47355

New package: msitools-0.103
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/47355.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps_msitools-47355.patch --]
[-- Type: text/x-diff, Size: 1141 bytes --]

From 003f978a3694eb5763081d04417cc0ac61d29893 Mon Sep 17 00:00:00 2001
From: Pete Beardmore <peteb@appcheck-ng.com>
Date: Wed, 22 Nov 2023 18:51:03 +0000
Subject: [PATCH] New package: msitools-0.103

---
 srcpkgs/msitools/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 0000000000000..1d8d094aa609e
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,13 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.103
+revision=1
+build_style=meson
+hostmakedepends="vala perl bison pkg-config cmake"
+makedepends="glib-devel libgsf-devel gcab-devel gobject-introspection"
+short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
+maintainer="Pete Beardmore <elbeardmorez@msn.com>"
+license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
+homepage="https://wiki.gnome.org/msitools"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR PATCH] [Updated] New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
@ 2023-11-30  8:40 ` elbeardmorez
  2023-11-30  8:43 ` elbeardmorez
                   ` (19 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: elbeardmorez @ 2023-11-30  8:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

There is an updated pull request by elbeardmorez against master on the void-packages repository

https://github.com/elbeardmorez/void-packages xbps_msitools
https://github.com/void-linux/void-packages/pull/47355

New package: msitools-0.103
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/47355.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps_msitools-47355.patch --]
[-- Type: text/x-diff, Size: 1247 bytes --]

From a4e91e27ec88fa3f3577043a961a47671a7a577f Mon Sep 17 00:00:00 2001
From: Pete Beardmore <peteb@appcheck-ng.com>
Date: Wed, 22 Nov 2023 18:51:03 +0000
Subject: [PATCH] New package: msitools-0.103

---
 srcpkgs/msitools/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 0000000000000..7ea2f5b317992
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,16 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.103
+revision=1
+build_style=meson
+build_helper="gir"
+hostmakedepends="glib-devel gobject-introspection vala perl bison pkg-config cmake"
+makedepends="glib-devel gobject-introspection libgsf-devel gcab-devel"
+short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
+maintainer="Pete Beardmore <elbeardmorez@msn.com>"
+license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
+homepage="https://wiki.gnome.org/msitools"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"
+build_options="gir"
+build_options_default="gir"

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
  2023-11-30  8:40 ` [PR PATCH] [Updated] " elbeardmorez
@ 2023-11-30  8:43 ` elbeardmorez
  2023-12-03 14:49 ` Bnyro
                   ` (18 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: elbeardmorez @ 2023-11-30  8:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by elbeardmorez on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-1833328181

Comment:
with a few tweaks to the template the aarch64 package is successfully built here locally

is there a requirement to get the package building for every single supported architecture?

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
  2023-11-30  8:40 ` [PR PATCH] [Updated] " elbeardmorez
  2023-11-30  8:43 ` elbeardmorez
@ 2023-12-03 14:49 ` Bnyro
  2024-03-03  1:45 ` github-actions
                   ` (17 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: Bnyro @ 2023-12-03 14:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-1837505892

Comment:
> with a few tweaks to the template the aarch64 package is successfully built here locally
> 
> is there a requirement to get the package building for every single supported architecture?
>
No, but all officially supported architectures by the project itself should likely be functional here too.


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (2 preceding siblings ...)
  2023-12-03 14:49 ` Bnyro
@ 2024-03-03  1:45 ` github-actions
  2024-03-03 12:18 ` elbeardmorez
                   ` (16 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2024-03-03  1:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-1974973676

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (3 preceding siblings ...)
  2024-03-03  1:45 ` github-actions
@ 2024-03-03 12:18 ` elbeardmorez
  2024-03-27 14:47 ` afranchuk
                   ` (15 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: elbeardmorez @ 2024-03-03 12:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

New comment by elbeardmorez on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-1975141813

Comment:
There is no official list of what it should compile on and trying to compile such a list of potential architectures just in case someone needs it one day doesn't appeal as an exercise. If, assuming this goes in, someone then comes and suggests a tweak to make it also compile on XYZ then cool, I'll push the change.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (4 preceding siblings ...)
  2024-03-03 12:18 ` elbeardmorez
@ 2024-03-27 14:47 ` afranchuk
  2024-03-27 14:48 ` afranchuk
                   ` (14 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: afranchuk @ 2024-03-27 14:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

New comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2022961947

Comment:
I made #49528 as an update to #43321 (which was never merged) and didn't realize this existed. Comparing against your additions, I see that you have `build_options="gir"` and don't have `python3-setuptools`. I found that I needed `python3-setuptools` otherwise `distutils` (removed in python 3.12) was missing, and it's used by `gobject-introspection`. Obviously `gobject-introspection` should have this dependency itself, but I'm wondering whether the `build_options="gir"` somehow avoided this issue for you?

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (5 preceding siblings ...)
  2024-03-27 14:47 ` afranchuk
@ 2024-03-27 14:48 ` afranchuk
  2024-06-26  1:48 ` github-actions
                   ` (13 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: afranchuk @ 2024-03-27 14:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

New comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2022961947

Comment:
I made #49528 as an update to #43321 (which was never merged) and didn't realize this existed. Comparing against your additions, I see that you have `build_options="gir"` and don't have `python3-setuptools`.

I found that I needed `python3-setuptools` otherwise `distutils` (removed in python 3.12) was missing, and it's used by `gobject-introspection`. Obviously `gobject-introspection` should have this dependency itself (EDIT: it appears it does??), but I'm wondering whether the `build_options="gir"` somehow avoided this issue for you? Or maybe my (previously completely clean) build env somehow got busted?

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (6 preceding siblings ...)
  2024-03-27 14:48 ` afranchuk
@ 2024-06-26  1:48 ` github-actions
  2024-06-26  8:39 ` elbeardmorez
                   ` (12 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2024-06-26  1:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2190378215

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (7 preceding siblings ...)
  2024-06-26  1:48 ` github-actions
@ 2024-06-26  8:39 ` elbeardmorez
  2024-06-26 12:58 ` afranchuk
                   ` (11 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: elbeardmorez @ 2024-06-26  8:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

New comment by elbeardmorez on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2191139964

Comment:
bump!!

@afranchuk did you ever attempt any cross compilation?

I'm not able to comment authoritatively on the _gobject-introspection_ line of questioning, but if I recall correctly, having hit a build failure due to that requirement itself, hunting led me to the likes of https://voidlinux.org/news/2019/02/cross-gobject.html and with the requirement to test cross-compilation (where possible), and having made comparisons with other package's build config / template files, the `build_options="gir"` addition was the winner.

Given that that post gives me the _getting this sh1t working on the myriad platforms packages are available for in the voidlinux arena is difficult so **this is how we do it going forward**_ vibe.. I do not want to dig at this at all.

@Bnyro are there any further steps that you are expecting here? @afranchuk has tried twice to get this me in, myself just the once, it's not a very complex package so it would be good to understand how we can make this happen.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (8 preceding siblings ...)
  2024-06-26  8:39 ` elbeardmorez
@ 2024-06-26 12:58 ` afranchuk
  2024-06-26 16:57 ` elbeardmorez
                   ` (10 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: afranchuk @ 2024-06-26 12:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2191629153

Comment:
I did not try any cross-compilation. But I agree, it'd be nice to know why this package stagnates.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (9 preceding siblings ...)
  2024-06-26 12:58 ` afranchuk
@ 2024-06-26 16:57 ` elbeardmorez
  2024-09-25  2:00 ` github-actions
                   ` (9 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: elbeardmorez @ 2024-06-26 16:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

New comment by elbeardmorez on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2191139964

Comment:
bump!!

@afranchuk did you ever attempt any cross compilation?

I'm not able to comment authoritatively on the _gobject-introspection_ line of questioning, but if I recall correctly, having hit a build failure due to that requirement itself, hunting led me to the likes of https://voidlinux.org/news/2019/02/cross-gobject.html and with the requirement to test cross-compilation (where possible), and having made comparisons with other package's build config / template files, the `build_options="gir"` addition was the winner.

Given that that post gives me the _getting this sh1t working on the myriad platforms packages are available for in the voidlinux arena is difficult so **this is how we do it going forward**_ vibe.. I do not want to dig at this at all.

@Bnyro are there any further steps that you are expecting here? @afranchuk has tried twice to get this in, myself just the once, it's not a very complex package so it would be good to understand how we can make this happen.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (10 preceding siblings ...)
  2024-06-26 16:57 ` elbeardmorez
@ 2024-09-25  2:00 ` github-actions
  2024-09-28 10:54 ` elbeardmorez
                   ` (8 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2024-09-25  2:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2372730641

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (11 preceding siblings ...)
  2024-09-25  2:00 ` github-actions
@ 2024-09-28 10:54 ` elbeardmorez
  2024-09-30 14:37 ` xeroxslayer
                   ` (7 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: elbeardmorez @ 2024-09-28 10:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by elbeardmorez on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2380601591

Comment:
Bump ... BUMP?!?!

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (12 preceding siblings ...)
  2024-09-28 10:54 ` elbeardmorez
@ 2024-09-30 14:37 ` xeroxslayer
  2024-09-30 14:39 ` xeroxslayer
                   ` (6 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: xeroxslayer @ 2024-09-30 14:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2383396073

Comment:
The template is fine. Tested 10 different builds, builds just fine for 8 arches and libcs.

- x86_64 (native)
- x86_64-musl (native)
- i686 (native)
- i686-musl (native)
- aarch64 (through x86_64)
- aarch64-musl (through x86_64-musl)
- armv7l (through i686)
- armv7l-musl (through i686-musl)
- armv6l (through i686)
- armv6l-musl (through i686)

The tools also run fine, tested in x86_64-musl and i686 (extracted a msi file in both of them). Wouldn't know about the rest of the arches, but the bins and libs were all tested for word size and arch, they all matched what they were built for (`./xbps-src install msitools`, check the `destidir`, then `./xbps-src pkg msitools`).

There are just a few corrections in the template, if I may. `glib-devel` is almost always needed just in `hostmakedepends`, not in `makedepends`, so I removed it from `makedepends` and as expected, it built just fine. Also `gobject-introspection` is automatically added to `hostmakedepends` and `makedepends` when defining the `buld_helper="gir"`, so again there is no need to add it to either of them.

This is what I used for my builds.

````
# Template file for 'msitools'
pkgname=msitools
version=0.103
revision=1
build_style=meson
build_helper="gir"
hostmakedepends="glib-devel vala perl bison pkg-config cmake"
makedepends="libgsf-devel gcab-devel"
short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
maintainer="Pete Beardmore <elbeardmorez@msn.com>"
license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
homepage="https://wiki.gnome.org/msitools"
distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"
build_options="gir"
build_options_default="gir"
````

So, in general, it's safe to turn on CI now and let it check the template, it should pass the checks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (13 preceding siblings ...)
  2024-09-30 14:37 ` xeroxslayer
@ 2024-09-30 14:39 ` xeroxslayer
  2024-09-30 14:39 ` xeroxslayer
                   ` (5 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: xeroxslayer @ 2024-09-30 14:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2383396073

Comment:
The template is fine. Tested 10 different builds, builds just fine for 8 arches and libcs.

- x86_64 (native)
- x86_64-musl (native)
- i686 (native)
- i686-musl (native)
- aarch64 (through x86_64)
- aarch64-musl (through x86_64-musl)
- armv7l (through i686)
- armv7l-musl (through i686-musl)
- armv6l (through i686)
- armv6l-musl (through i686)

The tools also run fine, tested in x86_64-musl and i686 (extracted a msi file in both of them). Wouldn't know about the rest of the arches, but the bins and libs were all tested for word size and arch, they all matched what they were built for (`./xbps-src install msitools`, check the `destidir`, then `./xbps-src pkg msitools`).

There are just a few corrections in the template, if I may. `glib-devel` is almost always needed just in `hostmakedepends`, not in `makedepends`, so I removed it from `makedepends` and as expected, it built just fine. Also `gobject-introspection` is automatically added to `hostmakedepends` and `makedepends` when defining the `buld_helper="gir"`, so again there is no need to add it to either of them.

This is what I used for my builds.

````
# Template file for 'msitools'
pkgname=msitools
version=0.103
revision=1
build_style=meson
build_helper="gir"
hostmakedepends="glib-devel vala perl bison pkg-config cmake"
makedepends="libgsf-devel gcab-devel"
short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
maintainer="Pete Beardmore <elbeardmorez@msn.com>"
license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
homepage="https://wiki.gnome.org/msitools"
distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"
build_options="gir"
build_options_default="gir"
````

Basically, just corrections to `hostmakedepends` and `makedepends`.

So, in general, it's safe to turn on CI now and let it check the template, it should pass the checks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (14 preceding siblings ...)
  2024-09-30 14:39 ` xeroxslayer
@ 2024-09-30 14:39 ` xeroxslayer
  2024-09-30 14:40 ` xeroxslayer
                   ` (4 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: xeroxslayer @ 2024-09-30 14:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2142 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2383396073

Comment:
The template is fine. Tested 10 different builds, builds just fine for 10 arches and libcs.

- x86_64 (native)
- x86_64-musl (native)
- i686 (native)
- i686-musl (native)
- aarch64 (through x86_64)
- aarch64-musl (through x86_64-musl)
- armv7l (through i686)
- armv7l-musl (through i686-musl)
- armv6l (through i686)
- armv6l-musl (through i686)

The tools also run fine, tested in x86_64-musl and i686 (extracted a msi file in both of them). Wouldn't know about the rest of the arches, but the bins and libs were all tested for word size and arch, they all matched what they were built for (`./xbps-src install msitools`, check the `destidir`, then `./xbps-src pkg msitools`).

There are just a few corrections in the template, if I may. `glib-devel` is almost always needed just in `hostmakedepends`, not in `makedepends`, so I removed it from `makedepends` and as expected, it built just fine. Also `gobject-introspection` is automatically added to `hostmakedepends` and `makedepends` when defining the `buld_helper="gir"`, so again there is no need to add it to either of them.

This is what I used for my builds.

````
# Template file for 'msitools'
pkgname=msitools
version=0.103
revision=1
build_style=meson
build_helper="gir"
hostmakedepends="glib-devel vala perl bison pkg-config cmake"
makedepends="libgsf-devel gcab-devel"
short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
maintainer="Pete Beardmore <elbeardmorez@msn.com>"
license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
homepage="https://wiki.gnome.org/msitools"
distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"
build_options="gir"
build_options_default="gir"
````

Basically, just corrections to `hostmakedepends` and `makedepends`.

So, in general, it's safe to turn on CI now and let it check the template, it should pass the checks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (15 preceding siblings ...)
  2024-09-30 14:39 ` xeroxslayer
@ 2024-09-30 14:40 ` xeroxslayer
  2024-09-30 14:43 ` xeroxslayer
                   ` (3 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: xeroxslayer @ 2024-09-30 14:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2147 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2383396073

Comment:
The template is fine. Tested 10 different builds, builds just fine for 10 arches and libcs.

- x86_64 (native)
- x86_64-musl (native)
- i686 (native)
- i686-musl (native)
- aarch64 (through x86_64)
- aarch64-musl (through x86_64-musl)
- armv7l (through i686)
- armv7l-musl (through i686-musl)
- armv6l (through i686)
- armv6l-musl (through i686-musl)

The tools also run fine, tested in x86_64-musl and i686 (extracted a msi file in both of them). Wouldn't know about the rest of the arches, but the bins and libs were all tested for word size and arch, they all matched what they were built for (`./xbps-src install msitools`, check the `destidir`, then `./xbps-src pkg msitools`).

There are just a few corrections in the template, if I may. `glib-devel` is almost always needed just in `hostmakedepends`, not in `makedepends`, so I removed it from `makedepends` and as expected, it built just fine. Also `gobject-introspection` is automatically added to `hostmakedepends` and `makedepends` when defining the `buld_helper="gir"`, so again there is no need to add it to either of them.

This is what I used for my builds.

````
# Template file for 'msitools'
pkgname=msitools
version=0.103
revision=1
build_style=meson
build_helper="gir"
hostmakedepends="glib-devel vala perl bison pkg-config cmake"
makedepends="libgsf-devel gcab-devel"
short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
maintainer="Pete Beardmore <elbeardmorez@msn.com>"
license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
homepage="https://wiki.gnome.org/msitools"
distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"
build_options="gir"
build_options_default="gir"
````

Basically, just corrections to `hostmakedepends` and `makedepends`.

So, in general, it's safe to turn on CI now and let it check the template, it should pass the checks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (16 preceding siblings ...)
  2024-09-30 14:40 ` xeroxslayer
@ 2024-09-30 14:43 ` xeroxslayer
  2024-10-04 11:03 ` [PR PATCH] [Updated] " elbeardmorez
                   ` (2 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: xeroxslayer @ 2024-09-30 14:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2229 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2383396073

Comment:
The template is fine. Tested 10 different builds, builds just fine for 10 arches and libcs.

- x86_64 (native)
- x86_64-musl (native)
- i686 (native)
- i686-musl (native)
- aarch64 (through x86_64)
- aarch64-musl (through x86_64-musl)
- armv7l (through i686)
- armv7l-musl (through i686-musl)
- armv6l (through i686)
- armv6l-musl (through i686-musl)

The tools also run fine, tested in x86_64-musl and i686 (extracted a msi file in both of them). Wouldn't know about the rest of the arches, but the bins and libs were all tested for word size and arch, they all matched what they were built for (`./xbps-src install msitools`, check the `destidir`, then `./xbps-src pkg msitools`).

There are just a few corrections in the template, if I may. `glib-devel` is almost always needed just in `hostmakedepends`, not in `makedepends` (and is probably one of the very few devel packages that go in `hostmakedepends`), so I removed it from `makedepends` and as expected, it built just fine. Also `gobject-introspection` is automatically added to `hostmakedepends` and `makedepends` when defining the `buld_helper="gir"`, so again there is no need to add it to either of them.

This is what I used for my builds.

````
# Template file for 'msitools'
pkgname=msitools
version=0.103
revision=1
build_style=meson
build_helper="gir"
hostmakedepends="glib-devel vala perl bison pkg-config cmake"
makedepends="libgsf-devel gcab-devel"
short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
maintainer="Pete Beardmore <elbeardmorez@msn.com>"
license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
homepage="https://wiki.gnome.org/msitools"
distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"
build_options="gir"
build_options_default="gir"
````

Basically, just corrections to `hostmakedepends` and `makedepends`.

So, in general, it's safe to turn on CI now and let it check the template, it should pass the checks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR PATCH] [Updated] New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (17 preceding siblings ...)
  2024-09-30 14:43 ` xeroxslayer
@ 2024-10-04 11:03 ` elbeardmorez
  2024-10-04 11:05 ` elbeardmorez
  2024-10-04 23:47 ` xeroxslayer
  20 siblings, 0 replies; 22+ messages in thread
From: elbeardmorez @ 2024-10-04 11:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

There is an updated pull request by elbeardmorez against master on the void-packages repository

https://github.com/elbeardmorez/void-packages xbps_msitools
https://github.com/void-linux/void-packages/pull/47355

New package: msitools-0.103
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/47355.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps_msitools-47355.patch --]
[-- Type: text/x-diff, Size: 1242 bytes --]

From eb8c802a65f84c23cc8e56c7c33a7c9dfba52a93 Mon Sep 17 00:00:00 2001
From: Pete Beardmore <peteb@appcheck-ng.com>
Date: Wed, 22 Nov 2023 18:51:03 +0000
Subject: [PATCH] New package: msitools-0.103

-notable thanks to @xeroxslayer for their input
---
 srcpkgs/msitools/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 00000000000000..b97bd65d88f7d2
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,16 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.103
+revision=1
+build_style=meson
+build_helper="gir"
+hostmakedepends="glib-devel vala perl bison pkg-config cmake"
+makedepends="libgsf-devel gcab-devel"
+short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
+maintainer="Pete Beardmore <elbeardmorez@msn.com>"
+license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
+homepage="https://wiki.gnome.org/msitools"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"
+build_options="gir"
+build_options_default="gir"

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (18 preceding siblings ...)
  2024-10-04 11:03 ` [PR PATCH] [Updated] " elbeardmorez
@ 2024-10-04 11:05 ` elbeardmorez
  2024-10-04 23:47 ` xeroxslayer
  20 siblings, 0 replies; 22+ messages in thread
From: elbeardmorez @ 2024-10-04 11:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

New comment by elbeardmorez on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2393447091

Comment:
thank you for the help @xeroxslayer, happy to defer to your version, you clearly know what you're talking about :+1:

fixed and force pushed post rebase

```
diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
index 7ea2f5b3179..b97bd65d88f 100644
--- a/srcpkgs/msitools/template
+++ b/srcpkgs/msitools/template
@@ -4,8 +4,8 @@ version=0.103
 revision=1
 build_style=meson
 build_helper="gir"
-hostmakedepends="glib-devel gobject-introspection vala perl bison pkg-config cmake"
-makedepends="glib-devel gobject-introspection libgsf-devel gcab-devel"
+hostmakedepends="glib-devel vala perl bison pkg-config cmake"
+makedepends="libgsf-devel gcab-devel"
 short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
 maintainer="Pete Beardmore <elbeardmorez@msn.com>"
 license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
```

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (19 preceding siblings ...)
  2024-10-04 11:05 ` elbeardmorez
@ 2024-10-04 23:47 ` xeroxslayer
  20 siblings, 0 replies; 22+ messages in thread
From: xeroxslayer @ 2024-10-04 23:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2394795535

Comment:
Great :).

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2024-10-04 23:47 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
2023-11-30  8:40 ` [PR PATCH] [Updated] " elbeardmorez
2023-11-30  8:43 ` elbeardmorez
2023-12-03 14:49 ` Bnyro
2024-03-03  1:45 ` github-actions
2024-03-03 12:18 ` elbeardmorez
2024-03-27 14:47 ` afranchuk
2024-03-27 14:48 ` afranchuk
2024-06-26  1:48 ` github-actions
2024-06-26  8:39 ` elbeardmorez
2024-06-26 12:58 ` afranchuk
2024-06-26 16:57 ` elbeardmorez
2024-09-25  2:00 ` github-actions
2024-09-28 10:54 ` elbeardmorez
2024-09-30 14:37 ` xeroxslayer
2024-09-30 14:39 ` xeroxslayer
2024-09-30 14:39 ` xeroxslayer
2024-09-30 14:40 ` xeroxslayer
2024-09-30 14:43 ` xeroxslayer
2024-10-04 11:03 ` [PR PATCH] [Updated] " elbeardmorez
2024-10-04 11:05 ` elbeardmorez
2024-10-04 23:47 ` xeroxslayer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).