Github messages for voidlinux
 help / color / mirror / Atom feed
From: Luciogi <Luciogi@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: phonon/phonon-backend-vlc: update
Date: Wed, 06 Mar 2024 16:51:17 +0100	[thread overview]
Message-ID: <20240306155117.B323E25C36@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47609@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/47609#issuecomment-1981186831

Comment:
This would build both qt5,6 versions
```diff
diff --git a/srcpkgs/phonon/template b/srcpkgs/phonon/template
index ff0883ce588..4c20061710a 100644
--- a/srcpkgs/phonon/template
+++ b/srcpkgs/phonon/template
@@ -3,7 +3,7 @@ pkgname=phonon
 version=4.12.0
 revision=1
 build_style=cmake
-configure_args="-DPHONON_BUILD_PHONON4QT5=ON -DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=ON"
+configure_args="-DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=ON"
 hostmakedepends="extra-cmake-modules qt5-host-tools qt5-devel
  qt6-base qt6-tools qt6-tools"
 makedepends="glib-devel qt5-devel qt5-tools-devel pulseaudio-devel

```

Everything is fine except short_desc

  parent reply	other threads:[~2024-03-06 15:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 22:01 [PR PATCH] " Johnnynator
2024-03-05  1:44 ` github-actions
2024-03-06 15:51 ` Luciogi [this message]
2024-03-06 15:52 ` Luciogi
2024-03-06 21:52 ` [PR PATCH] [Updated] " Johnnynator
2024-03-06 21:55 ` Johnnynator
2024-03-06 21:55 ` [PR PATCH] [Merged]: " Johnnynator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240306155117.B323E25C36@inbox.vuxu.org \
    --to=luciogi@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).