Github messages for voidlinux
 help / color / mirror / Atom feed
From: Eloitor <Eloitor@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] [WIP] dooble: add dictionaries.
Date: Sun, 10 Mar 2024 16:11:29 +0100	[thread overview]
Message-ID: <20240310151129.A2C5E259AB@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49075@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/49075

[WIP] dooble: add dictionaries.
#### Testing the changes
- I tested the changes in this PR: **YES** 
  (Dooble finds them, but QT doesn't... See https://github.com/textbrowser/dooble/issues/222)

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

closes #49030


A patch file from https://github.com/void-linux/void-packages/pull/49075.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-49075.patch --]
[-- Type: text/x-diff, Size: 2033 bytes --]

From 6c5f0e15ac88e0f02ecf80b0b33b6da63a5fac1e Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Mon, 4 Mar 2024 13:27:30 +0100
Subject: [PATCH] dooble: add dictionaries and translations.

---
 srcpkgs/dooble/patches/dictionaries.patch | 11 +++++++++++
 srcpkgs/dooble/template                   |  4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/dooble/patches/dictionaries.patch

diff --git a/srcpkgs/dooble/patches/dictionaries.patch b/srcpkgs/dooble/patches/dictionaries.patch
new file mode 100644
index 00000000000000..f8bf80ee34466b
--- /dev/null
+++ b/srcpkgs/dooble/patches/dictionaries.patch
@@ -0,0 +1,11 @@
+--- a/Source/dooble_settings.cc
++++ b/Source/dooble_settings.cc
+@@ -2271,7 +2271,7 @@ void dooble_settings::show_qtwebengine_dictionaries_warning_label(void)
+ 
+   if(bytes.trimmed().isEmpty())
+     {
+-      bytes = "qtwebengine_dictionaries";
++      bytes = "/usr/share/qt6/qtwebengine_dictionaries";
+ 
+       if(!QFileInfo(bytes).isReadable())
+ 	{
diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
index 9c4933e551a356..c33baca5e05f67 100644
--- a/srcpkgs/dooble/template
+++ b/srcpkgs/dooble/template
@@ -1,13 +1,13 @@
 # Template file for 'dooble'
 pkgname=dooble
 version=2024.01.25
-revision=1
+revision=2
 archs="x86_64* aarch64*"
 build_style=qmake
 configure_args="dooble.pro"
 hostmakedepends="qt6-webengine qt6-declarative-devel"
 makedepends="qt6-charts-devel qt6-webengine-devel qt6-webchannel-devel qt6-location-devel qt6-charts-devel qt6-wayland python3-QtPy"
-depends="qt6-charts qt6-core qt6-declarative qt6-gui qt6-network qt6-plugin-sqlite qt6-printsupport qt6-sql qt6-webengine qt6-widgets"
+depends="qt6-charts qt6-core qt6-declarative qt6-gui qt6-network qt6-plugin-sqlite qt6-printsupport qt6-sql qt6-webengine qt6-widgets libreoffice-qtwebengine-dict"
 short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
 maintainer="Eloi Torrents <eloitor@disroot.org>"
 license="BSD-3-Clause"

  reply	other threads:[~2024-03-10 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 11:29 [PR PATCH] " Eloitor
2024-03-10 15:11 ` Eloitor [this message]
2024-03-10 17:29 ` [PR PATCH] [Updated] " Eloitor
2024-03-10 17:30 ` Eloitor
2024-06-09  1:52 ` github-actions
2024-06-24  1:50 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240310151129.A2C5E259AB@inbox.vuxu.org \
    --to=eloitor@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).