* Re: New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
@ 2024-03-19 6:17 ` oreo639
2024-03-19 6:18 ` oreo639
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2024-03-19 6:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#issuecomment-2005878821
Comment:
Update this to glycin-loaders 1.0 and loupe 46.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
2024-03-19 6:17 ` oreo639
@ 2024-03-19 6:18 ` oreo639
2024-03-19 6:23 ` oreo639
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2024-03-19 6:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#issuecomment-2005878821
Comment:
glycin-loaders 1.0 and loupe 46 are out.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
2024-03-19 6:17 ` oreo639
2024-03-19 6:18 ` oreo639
@ 2024-03-19 6:23 ` oreo639
2024-03-19 7:14 ` oreo639
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2024-03-19 6:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#issuecomment-2005878821
Comment:
glycin-loaders 1.0.0 and loupe 46.0 are out.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (2 preceding siblings ...)
2024-03-19 6:23 ` oreo639
@ 2024-03-19 7:14 ` oreo639
2024-03-19 7:17 ` [PR REVIEW] " oreo639
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2024-03-19 7:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#issuecomment-2006046882
Comment:
Here is glycin-loaders:
https://gist.github.com/oreo639/1411d98cb8714de906de66e20daaf3dd
(This removes the git dependency as git generally should not be used during xbps-src builds)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (3 preceding siblings ...)
2024-03-19 7:14 ` oreo639
@ 2024-03-19 7:17 ` oreo639
2024-03-19 7:47 ` oreo639
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2024-03-19 7:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#discussion_r1529846642
Comment:
Why are you doing this instead of `make_install_args`?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (4 preceding siblings ...)
2024-03-19 7:17 ` [PR REVIEW] " oreo639
@ 2024-03-19 7:47 ` oreo639
2024-03-19 7:51 ` oreo639
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2024-03-19 7:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#discussion_r1529877994
Comment:
Sorry, I didn't realize you are doing meson install --no-rebuild which is what gets called by `ninja install` anyway, not sure the point of this.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (5 preceding siblings ...)
2024-03-19 7:47 ` oreo639
@ 2024-03-19 7:51 ` oreo639
2024-03-20 8:24 ` [PR PATCH] [Updated] " chrysos349
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2024-03-19 7:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
New review comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#discussion_r1529877994
Comment:
Sorry, I didn't realize you are doing meson install --no-rebuild which is what gets called by `ninja install` anyway. Not sure this is necessary.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Updated] New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (6 preceding siblings ...)
2024-03-19 7:51 ` oreo639
@ 2024-03-20 8:24 ` chrysos349
2024-03-20 8:51 ` [PR REVIEW] " chrysos349
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: chrysos349 @ 2024-03-20 8:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
There is an updated pull request by chrysos349 against master on the void-packages repository
https://github.com/chrysos349/void-packages loupe
https://github.com/void-linux/void-packages/pull/48093
New package: loupe-45.3
this app is a part of gnome-45 #48762
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl x
- armv7l x
- armv6l-musl x
A patch file from https://github.com/void-linux/void-packages/pull/48093.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-loupe-48093.patch --]
[-- Type: text/x-diff, Size: 2925 bytes --]
From 6b618b2ac26e577ae1b110915767082a54a6de4a Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Sun, 7 Jan 2024 01:32:28 +0300
Subject: [PATCH 1/2] New package: glycin-loaders-0.1.2
---
srcpkgs/glycin-loaders/template | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 srcpkgs/glycin-loaders/template
diff --git a/srcpkgs/glycin-loaders/template b/srcpkgs/glycin-loaders/template
new file mode 100644
index 00000000000000..134dbfdd3f3fc9
--- /dev/null
+++ b/srcpkgs/glycin-loaders/template
@@ -0,0 +1,28 @@
+# Template file for 'glycin-loaders'
+pkgname=glycin-loaders
+version=0.1.2
+revision=1
+build_style=meson
+build_helper=rust
+configure_args="-Dtest_skip_install=true"
+hostmakedepends="cargo gettext pkg-config"
+makedepends="gtk4-devel libheif-devel rust-std"
+short_desc="Sandboxed and extendable image decoding"
+maintainer="chrysos349 <chrysostom349@gmail.com>"
+license="MPL-2.0"
+homepage="https://gitlab.gnome.org/sophie-h/glycin"
+changelog="https://gitlab.gnome.org/sophie-h/glycin/-/raw/main/NEWS"
+distfiles="${GNOME_SITE}/glycin-loaders/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=c76c01925abd070174589ccb916a44a573ab65b1e9d493f154e42756431e6dd7
+make_check=no # needs to be installed to run tests
+
+post_patch() {
+ if [ "$CROSS_BUILD" ]; then
+ vsed -i loaders/meson.build \
+ -e "s%rust_target /%'${RUST_TARGET}' / &%"
+ fi
+
+ # loaders/meson.build tries to call git to get hash for debug builds.
+ # Disable as it is useless for tarball builds.
+ ln -sf /bin/false ${XBPS_WRAPPERDIR}/git
+}
From 6f3aedadcad937fe6ff8a7ad8c5548007c86f54f Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Sun, 7 Jan 2024 01:33:02 +0300
Subject: [PATCH 2/2] New package: loupe-45.3
---
srcpkgs/loupe/template | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 srcpkgs/loupe/template
diff --git a/srcpkgs/loupe/template b/srcpkgs/loupe/template
new file mode 100644
index 00000000000000..63d0912259bc52
--- /dev/null
+++ b/srcpkgs/loupe/template
@@ -0,0 +1,24 @@
+# Template file for 'loupe'
+pkgname=loupe
+version=45.3
+revision=1
+build_style=meson
+build_helper=rust
+hostmakedepends="cargo desktop-file-utils gettext gtk4-update-icon-cache
+ itstool pkg-config"
+makedepends="lcms2-devel libadwaita-devel libgweather-devel rust-std"
+depends="glycin-loaders"
+short_desc="Simple image viewer for GNOME"
+maintainer="chrysos349 <chrysostom349@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://gitlab.gnome.org/GNOME/loupe"
+changelog="https://gitlab.gnome.org/GNOME/loupe/-/raw/main/NEWS"
+distfiles="${GNOME_SITE}/loupe/${version%.*}/loupe-${version}.tar.xz"
+checksum=f65f2d1208d085ab5ffa998dd43c92fe952272d4d59b51cfecc11ebdffca2d86
+
+post_patch() {
+ if [ "$CROSS_BUILD" ]; then
+ vsed -i src/meson.build \
+ -e "s%rust_target /%'${RUST_TARGET}' / &%"
+ fi
+}
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (7 preceding siblings ...)
2024-03-20 8:24 ` [PR PATCH] [Updated] " chrysos349
@ 2024-03-20 8:51 ` chrysos349
2024-03-20 10:46 ` [PR PATCH] [Updated] " chrysos349
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: chrysos349 @ 2024-03-20 8:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
New review comment by chrysos349 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#discussion_r1531698113
Comment:
i removed this section, and git dep from glycin-loaders. i didn't update them yet, because loupe-46.0 requires newer gtk4 (at the same time it ran fine with the current gtk4 from the repo, which means the newer is not strictly required (maybe)). also loupe-45.3 won't work with newer glycin-loaders.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Updated] New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (8 preceding siblings ...)
2024-03-20 8:51 ` [PR REVIEW] " chrysos349
@ 2024-03-20 10:46 ` chrysos349
2024-03-20 10:46 ` chrysos349
2024-03-20 21:13 ` [PR PATCH] [Merged]: New package: loupe-46.0 oreo639
11 siblings, 0 replies; 13+ messages in thread
From: chrysos349 @ 2024-03-20 10:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
There is an updated pull request by chrysos349 against master on the void-packages repository
https://github.com/chrysos349/void-packages loupe
https://github.com/void-linux/void-packages/pull/48093
New package: loupe-45.3
this app is a part of gnome-45 #48762
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl x
- armv7l x
- armv6l-musl x
A patch file from https://github.com/void-linux/void-packages/pull/48093.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-loupe-48093.patch --]
[-- Type: text/x-diff, Size: 2980 bytes --]
From cf8d5e21cee28a38084fbf0346b8bebbd49d1bba Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Sun, 7 Jan 2024 01:32:28 +0300
Subject: [PATCH 1/2] New package: glycin-loaders-1.0.0
---
srcpkgs/glycin-loaders/template | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 srcpkgs/glycin-loaders/template
diff --git a/srcpkgs/glycin-loaders/template b/srcpkgs/glycin-loaders/template
new file mode 100644
index 00000000000000..7d923e12f3c228
--- /dev/null
+++ b/srcpkgs/glycin-loaders/template
@@ -0,0 +1,27 @@
+# Template file for 'glycin-loaders'
+pkgname=glycin-loaders
+version=1.0.0
+revision=1
+build_style=meson
+build_helper=rust
+configure_args="-Dtest_skip_install=true"
+hostmakedepends="cargo clang17 gettext pkg-config"
+makedepends="gtk4-devel libheif-devel libjxl-devel libseccomp-devel rust-std"
+short_desc="Sandboxed and extendable image decoding"
+maintainer="chrysos349 <chrysostom349@gmail.com>"
+license="MPL-2.0"
+homepage="https://gitlab.gnome.org/sophie-h/glycin"
+changelog="https://gitlab.gnome.org/sophie-h/glycin/-/raw/main/NEWS"
+distfiles="${GNOME_SITE}/glycin-loaders/${version%.*}/${pkgname}-${version}.tar.xz"
+checksum=cd2a3979259fee56cbd882a4d890437684bf1926e65afeafcb904ca9d17ae282
+make_check=no # needs to be installed to run tests
+
+post_patch() {
+ if [ "$CROSS_BUILD" ]; then
+ vsed -i loaders/meson.build \
+ -e "s%rust_target /%'${RUST_TARGET}' / &%"
+ fi
+ # loaders/meson.build tries to call git to get hash for debug builds.
+ # Disable as it is useless for tarball builds.
+ ln -sf /bin/false ${XBPS_WRAPPERDIR}/git
+}
From 5bb0b94ca3d19a747e0d926e944f41159287697d Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Sun, 7 Jan 2024 01:33:02 +0300
Subject: [PATCH 2/2] New package: loupe-46.0
---
srcpkgs/loupe/template | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 srcpkgs/loupe/template
diff --git a/srcpkgs/loupe/template b/srcpkgs/loupe/template
new file mode 100644
index 00000000000000..c1497dc076bb46
--- /dev/null
+++ b/srcpkgs/loupe/template
@@ -0,0 +1,25 @@
+# Template file for 'loupe'
+pkgname=loupe
+version=46.0
+revision=1
+build_style=meson
+build_helper=rust
+hostmakedepends="cargo desktop-file-utils gettext gtk4-update-icon-cache
+ itstool pkg-config"
+makedepends="lcms2-devel libadwaita-devel libgweather-devel libseccomp-devel
+ rust-std"
+depends="glycin-loaders"
+short_desc="Simple image viewer for GNOME"
+maintainer="chrysos349 <chrysostom349@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://gitlab.gnome.org/GNOME/loupe"
+changelog="https://gitlab.gnome.org/GNOME/loupe/-/raw/main/NEWS"
+distfiles="${GNOME_SITE}/loupe/${version%.*}/loupe-${version}.tar.xz"
+checksum=051aa45cf0ab362093fbf91863140be737db57bcb1f77bc1e00ab97255a252bd
+
+post_patch() {
+ if [ "$CROSS_BUILD" ]; then
+ vsed -i src/meson.build \
+ -e "s%rust_target /%'${RUST_TARGET}' / &%"
+ fi
+}
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: New package: loupe-45.3
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (9 preceding siblings ...)
2024-03-20 10:46 ` [PR PATCH] [Updated] " chrysos349
@ 2024-03-20 10:46 ` chrysos349
2024-03-20 21:13 ` [PR PATCH] [Merged]: New package: loupe-46.0 oreo639
11 siblings, 0 replies; 13+ messages in thread
From: chrysos349 @ 2024-03-20 10:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New comment by chrysos349 on void-packages repository
https://github.com/void-linux/void-packages/pull/48093#issuecomment-2009256120
Comment:
updated to `46.0`
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Merged]: New package: loupe-46.0
2024-01-06 22:37 [PR PATCH] New package: loupe-45.3 chrysos349
` (10 preceding siblings ...)
2024-03-20 10:46 ` chrysos349
@ 2024-03-20 21:13 ` oreo639
11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2024-03-20 21:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
There's a merged pull request on the void-packages repository
New package: loupe-46.0
https://github.com/void-linux/void-packages/pull/48093
Description:
this app is a part of gnome-45 #48762
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl x
- armv7l x
- armv6l-musl x
^ permalink raw reply [flat|nested] 13+ messages in thread