Re: [PR PATCH] [Updated] Signal-Desktop: update to 7.2.0.

[akierig <akierig@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

There is an updated pull request by akierig against master on the void-packages repository

https://github.com/akierig/void-packages signal-7.0
https://github.com/void-linux/void-packages/pull/49014

Signal-Desktop: update to 7.2.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/49014.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-signal-7.0-49014.patch --]
[-- Type: text/x-diff, Size: 1973 bytes --]

From 355d0c576b51fedb5e2cd18663595d4ee170fc9c Mon Sep 17 00:00:00 2001
From: anelki <akierig@fastmail.de>
Date: Thu, 29 Feb 2024 19:51:06 -0600
Subject: [PATCH] Signal-Desktop: update to 7.3.1

---
 srcpkgs/Signal-Desktop/template | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/Signal-Desktop/template b/srcpkgs/Signal-Desktop/template
index b2efa7cb902b2d..96bb650347d8a7 100644
--- a/srcpkgs/Signal-Desktop/template
+++ b/srcpkgs/Signal-Desktop/template
@@ -1,30 +1,31 @@
 # Template file for 'Signal-Desktop'
 pkgname=Signal-Desktop
-version=6.48.1
+version=7.3.1
 revision=1
 # Signal officially only supports x86_64 
 # x86_64-musl could potentially work based on the Alpine port:
 # https://git.alpinelinux.org/aports/tree/testing/signal-desktop
 # ARM: https://github.com/signalapp/Signal-Desktop/issues/3410
 archs="x86_64"
-hostmakedepends="git git-lfs nodejs-lts python3 python3-distutils-extra tar"
+hostmakedepends="git git-lfs n python3 python3-distutils-extra tar"
 depends="cairo gtk+3 libvips pango"
 short_desc="Signal Private Messenger for Linux"
 maintainer="anelki <akierig@fastmail.de>"
 license="AGPL-3.0-only"
 homepage="https://github.com/signalapp/Signal-Desktop"
 distfiles="https://github.com/signalapp/Signal-Desktop/archive/v${version}.tar.gz"
-checksum=fb3e59e853b16a99dee5db556b45dd19694b9c7f5e2505dcb546957c7c9bd26a
+checksum=47352d6e747aac9407a788079736f3f34b5521c4c530610af31916bbae5a383b
 nostrip_files="signal-desktop"
 
 post_extract() {
+	n 20.9.0
 	# git-lfs hook needs to be installed for one of the dependencies
 	git lfs install
-
-	vsed 's/"node": "/&>=/' -i package.json
-
+	# none of this is good but it is what it is.
 	npm install -g yarn
 	# Dependencies have to be installed before applying patch
+	# I am aware this is far from a best practice but also hardly different than how we'd been doing it
+	yarn global add node-gyp
 	yarn install --ignore-engines --frozen-lockfile
 }