[PR PATCH] btop: Update to 1.3.0

[PR PATCH] btop: Update to 1.3.0

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

There is a new pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR btop
https://github.com/void-linux/void-packages/pull/48113

btop: Update to 1.3.0
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

A patch file from https://github.com/void-linux/void-packages/pull/48113.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-btop-48113.patch --]
[-- Type: text/x-diff, Size: 991 bytes --]

From 65791d188a71f2cccfc355e093592c08e48a040b Mon Sep 17 00:00:00 2001
From: zenobit <zen@osowoso.xyz>
Date: Mon, 8 Jan 2024 01:04:22 +0100
Subject: [PATCH] btop: Update to 1.3.0

---
 srcpkgs/btop/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/btop/template b/srcpkgs/btop/template
index 46b60b18611ae..ffd64997e06ac 100644
--- a/srcpkgs/btop/template
+++ b/srcpkgs/btop/template
@@ -1,6 +1,6 @@
 # Template file for 'btop'
 pkgname=btop
-version=1.2.13
+version=1.3.0
 revision=1
 build_style=gnu-makefile
 short_desc="Monitor of resources"
@@ -9,4 +9,4 @@ license="Apache-2.0"
 homepage="https://github.com/aristocratos/btop"
 changelog="https://raw.githubusercontent.com/aristocratos/btop/main/CHANGELOG.md"
 distfiles="https://github.com/aristocratos/btop/archive/refs/tags/v${version}.tar.gz"
-checksum=668dc4782432564c35ad0d32748f972248cc5c5448c9009faeb3445282920e02
+checksum=375e078ce2091969f0cd14030620bd1a94987451cf7a73859127a786006a32cf

Re: btop: Update to 1.3.0

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1880253086

Comment:
Tested and is not working for me on x86-64-musl. CPU bar are missing.

Also, we could add ROCm-SMI-LIB as a dependancy for GPU support. I have a template for it, but it is trivial, and has no dependancies

Re: btop: Update to 1.3.0

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1880253086

Comment:
Tested and is not working for me on x86-64-musl. CPU bar are missing.

Also, we could add ROCm-SMI-LIB as a dependency for AMD GPU support. I have a template for it, but it is trivial, and has no other dependencies

Re: [PR PATCH] [Updated] btop: Update to 1.3.0

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

There is an updated pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR btop
https://github.com/void-linux/void-packages/pull/48113

btop: Update to 1.3.0
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

A patch file from https://github.com/void-linux/void-packages/pull/48113.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-btop-48113.patch --]
[-- Type: text/x-diff, Size: 991 bytes --]

From 6670d25f5276cd024d036f94d3fadc432e080c2d Mon Sep 17 00:00:00 2001
From: zenobit <zen@osowoso.xyz>
Date: Mon, 8 Jan 2024 01:04:22 +0100
Subject: [PATCH] btop: Update to 1.3.0

---
 srcpkgs/btop/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/btop/template b/srcpkgs/btop/template
index 46b60b18611ae..ffd64997e06ac 100644
--- a/srcpkgs/btop/template
+++ b/srcpkgs/btop/template
@@ -1,6 +1,6 @@
 # Template file for 'btop'
 pkgname=btop
-version=1.2.13
+version=1.3.0
 revision=1
 build_style=gnu-makefile
 short_desc="Monitor of resources"
@@ -9,4 +9,4 @@ license="Apache-2.0"
 homepage="https://github.com/aristocratos/btop"
 changelog="https://raw.githubusercontent.com/aristocratos/btop/main/CHANGELOG.md"
 distfiles="https://github.com/aristocratos/btop/archive/refs/tags/v${version}.tar.gz"
-checksum=668dc4782432564c35ad0d32748f972248cc5c5448c9009faeb3445282920e02
+checksum=375e078ce2091969f0cd14030620bd1a94987451cf7a73859127a786006a32cf

Re: btop: Update to 1.3.0

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1946399774

Comment:
btop [1.3.2](https://github.com/aristocratos/btop/releases/tag/v1.3.2) available

Re: [PR PATCH] [Updated] btop: Update to 1.3.0

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

There is an updated pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR btop
https://github.com/void-linux/void-packages/pull/48113

btop: Update to 1.3.0
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

A patch file from https://github.com/void-linux/void-packages/pull/48113.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-btop-48113.patch --]
[-- Type: text/x-diff, Size: 991 bytes --]

From 2597656443313fc015c7883fabb014774b96efe6 Mon Sep 17 00:00:00 2001
From: zenobit <zen@osowoso.xyz>
Date: Mon, 8 Jan 2024 01:04:22 +0100
Subject: [PATCH] btop: Update to 1.3.2

---
 srcpkgs/btop/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/btop/template b/srcpkgs/btop/template
index 46b60b18611ae..596219e6bcb3e 100644
--- a/srcpkgs/btop/template
+++ b/srcpkgs/btop/template
@@ -1,6 +1,6 @@
 # Template file for 'btop'
 pkgname=btop
-version=1.2.13
+version=1.3.2
 revision=1
 build_style=gnu-makefile
 short_desc="Monitor of resources"
@@ -9,4 +9,4 @@ license="Apache-2.0"
 homepage="https://github.com/aristocratos/btop"
 changelog="https://raw.githubusercontent.com/aristocratos/btop/main/CHANGELOG.md"
 distfiles="https://github.com/aristocratos/btop/archive/refs/tags/v${version}.tar.gz"
-checksum=668dc4782432564c35ad0d32748f972248cc5c5448c9009faeb3445282920e02
+checksum=331d18488b1dc7f06cfa12cff909230816a24c57790ba3e8224b117e3f0ae03e

Re: btop: Update to 1.3.2

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1946778870

Comment:
I just tested, and 1.3.2 looks like its working for me on musl

Also I created a PR to add ROCm-SMI-LIB for GPU support: #48744

Re: btop: Update to 1.3.2

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1946809287

Comment:
> I just tested, and 1.3.2 looks like its working for me on musl
> 
> Also I created a PR to add ROCm-SMI-LIB for GPU support: #48744

Definetly will try..

Since btop must be compiled with ROCm support, I think we will need second package for that...

am I right?

Re: btop: Update to 1.3.2

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1946830610

Comment:
> 
> Since btop must be compiled with ROCm support, I think we will need second package for that...
> 

ROCm-SMI is a standalone library which doesn't require any additional ROCm components. It pretty much just is an interface to get GPU load, power usage, temps, fan speeds, etc.

Re: btop: Update to 1.3.2

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1946834636

Comment:
> > Since btop must be compiled with ROCm support, I think we will need second package for that...
> 
> ROCm-SMI is a standalone library which doesn't require any additional ROCm components. It pretty much just is an interface to get GPU load, power usage, temps, fan speeds, etc.

I am speaking about btop and btop-rocm

Re: btop: Update to 1.3.2

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1946851055

Comment:
> I am speaking about btop and btop-rocm

I don't think that there is a need for a second package.

How is it different from other packages we build which have optional dependencies for extended functionality?

Re: btop: Update to 1.3.2

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1947004048

Comment:
I just checked the code and it should dlopen librocm_64.so

Re: btop: Update to 1.3.2

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1947004048

Comment:
I just checked the code and it should dlopen librocm_smi64.so

Re: btop: Update to 1.3.2

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1947235846

Comment:
But as I study btop instructions before. ROCm must be presented at build time. If isn't btop should be builded without ROCm support. So provide library for usuall btop shouldn't be enough. Must be builded again with ROCm, as far as I understand...

Re: btop: Update to 1.3.2

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1947235846

Comment:
But as I study btop instructions before. ROCm must be presented at build time. If isn't btop should be builded without ROCm support. So provide library for usuall btop shouldn't be enough. Must be builded again with ROCm, as far as I understand...

So only difference will be ROCM_devel in make_depends

Re: btop: Update to 1.3.2

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1947235846

Comment:
But as I study btop instructions before. ROCm must be presented at build time. If isn't btop should be builded without ROCm support. So provide library for usuall btop shouldn't be enough. Must be builded again with ROCm, as far as I understand...

So only difference will be ROCM_devel in makedepends

repektive somethink like this?:

```
# Template file for 'btop-ROCm'
pkgname=btop-ROCm
version=1.3.2
revision=1
build_style=gnu-makefile
makedepends="ROCm-SMI-devel"
short_desc="Monitor of resources"
maintainer="RunningDroid <runningdroid@zoho.com>"
license="Apache-2.0"
homepage="https://github.com/aristocratos/btop"
changelog="https://raw.githubusercontent.com/aristocratos/btop/main/CHANGELOG.md"
distfiles="https://github.com/aristocratos/btop/archive/refs/tags/v${version}.tar.gz"
checksum=331d18488b1dc7f06cfa12cff909230816a24c57790ba3e8224b117e3f0ae03e
conflicts=btop
```

Re: btop: Update to 1.3.2

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1947359438

Comment:
I believe what @Calandracas606 is saying is that there is no need to create a new `btop-ROCm` package, you can simply add `ROCm-SMI-devel` to btop's `makdepends` if/when it gets merged.

That said, `xbps` does not support "optional" dependencies, only build options. Did you mean adding a non-default build option for ROCm-SMI support?

Re: btop: Update to 1.3.2

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1947379285

Comment:
> you can simply add `ROCm-SMI-devel` to btop's `makdepends` if/when it gets merged.

@cinerea0 what I mean is that btop tries to dlopen librocm_smi, it's not even needed as a makedepends.

``` cpp
//? Try possible library paths and names for librocm_smi64.so
  const array libRocAlts = {"/opt/rocm/lib/librocm_smi64.so",
                            "librocm_smi64.so",
                            "librocm_smi64.so.5",   // fedora
                            "librocm_smi64.so.1.0", // debian
                            "librocm_smi64.so.6"};

  for (const auto &l : libRocAlts) {
    rsmi_dl_handle = dlopen(l, RTLD_LAZY);
    if (rsmi_dl_handle != nullptr) {
      break;
    }
  }

  if (!rsmi_dl_handle) {
    Logger::info(
        "Failed to load librocm_smi64.so, AMD GPUs will not be detected: "s +
        dlerror());
    return false;
  }
```

All that being said, there appears to be a bug in the gpu code, but I've been able to patch it to get it working

Re: btop: Update to 1.3.2

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-1947461685

Comment:
made a bug report upstream, but it shouldn't block this PR

https://github.com/aristocratos/btop/issues/774

Re: btop: Update to 1.3.2

[dm17]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by dm17 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-2024240212

Comment:
![image](https://github.com/void-linux/void-packages/assets/2621663/eec16248-7f5b-4111-895b-059fb5691ad5)

I'm not seeing how to get the GPU to display.

Re: btop: Update to 1.3.2

[dm17]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by dm17 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-2024240212

Comment:
![image](https://github.com/void-linux/void-packages/assets/2621663/eec16248-7f5b-4111-895b-059fb5691ad5)

I'm not seeing how to get the GPU to display. I've AMDGPUs

Re: btop: Update to 1.3.2

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48113#issuecomment-2024281190

Comment:
@dm17 
> I'm not seeing how to get the GPU to display. I've AMDGPUs

btop needs rocm-smi-lib https://github.com/void-linux/void-packages/pull/48744 to display amdgpu details

however, btop also appears bugged, and fails to display without a patch: https://github.com/aristocratos/btop/issues/774

only with patched btop, and rocm-smi-lib will the gpu show: 
![image](https://github.com/void-linux/void-packages/assets/40183138/e752a86d-6ae3-4a9e-b292-efa6118400f2)

Re: [PR PATCH] [Updated] btop: Update to 1.3.2

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

There is an updated pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR btop
https://github.com/void-linux/void-packages/pull/48113

btop: Update to 1.3.2
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

A patch file from https://github.com/void-linux/void-packages/pull/48113.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-btop-48113.patch --]
[-- Type: text/x-diff, Size: 993 bytes --]

From 7e74d1fb253274f7d02fefd18f1972b2ad017e96 Mon Sep 17 00:00:00 2001
From: zenobit <zen@osowoso.xyz>
Date: Mon, 8 Jan 2024 01:04:22 +0100
Subject: [PATCH] btop: Update to 1.3.2

---
 srcpkgs/btop/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/btop/template b/srcpkgs/btop/template
index 46b60b18611aec..596219e6bcb3ea 100644
--- a/srcpkgs/btop/template
+++ b/srcpkgs/btop/template
@@ -1,6 +1,6 @@
 # Template file for 'btop'
 pkgname=btop
-version=1.2.13
+version=1.3.2
 revision=1
 build_style=gnu-makefile
 short_desc="Monitor of resources"
@@ -9,4 +9,4 @@ license="Apache-2.0"
 homepage="https://github.com/aristocratos/btop"
 changelog="https://raw.githubusercontent.com/aristocratos/btop/main/CHANGELOG.md"
 distfiles="https://github.com/aristocratos/btop/archive/refs/tags/v${version}.tar.gz"
-checksum=668dc4782432564c35ad0d32748f972248cc5c5448c9009faeb3445282920e02
+checksum=331d18488b1dc7f06cfa12cff909230816a24c57790ba3e8224b117e3f0ae03e

Re: [PR PATCH] [Merged]: btop: Update to 1.3.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

There's a merged pull request on the void-packages repository

btop: Update to 1.3.2
https://github.com/void-linux/void-packages/pull/48113

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)