From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-zstandard: update to 0.22.0.
Date: Sat, 30 Mar 2024 23:51:05 +0100 [thread overview]
Message-ID: <20240330225105.3F1CB25B22@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49606@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/49606#issuecomment-2028488184
Comment:
Thanks @howtologinquickwiththirtyninecharacters
I'm a bit unsure about the vendored zstd. Have you tried it with the system 1.5.6?
What do you think about the following patch:
```
--- a/c-ext/backend_c.c 2023-11-01 02:58:34.000000000 -0300
+++ b/c-ext/backend_c.c 2024-03-29 21:32:40.694372789 -0300
@@ -152,7 +152,7 @@
PyObject *features = NULL;
PyObject *feature = NULL;
unsigned zstd_ver_no = ZSTD_versionNumber();
- unsigned our_hardcoded_version = 10505;
+ unsigned our_hardcoded_version = ZSTD_VERSION_NUMBER;
if (ZSTD_VERSION_NUMBER != our_hardcoded_version ||
zstd_ver_no != our_hardcoded_version) {
PyErr_Format(
```
This eliminates the hardcoded version; it will still check that the build-time version matches the runtime version, so if zstd is updated then python3-zstandard will need to be rebuilt (and @leahneukirchen placed a note in zstd template to that effect).
next prev parent reply other threads:[~2024-03-30 22:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 13:20 [PR PATCH] " unspecd
2024-03-30 13:24 ` unspecd
2024-03-30 22:51 ` tornaria [this message]
2024-03-31 21:39 ` tornaria
2024-03-31 23:36 ` leahneukirchen
2024-05-05 7:36 ` [PR PATCH] [Updated] " unspecd
2024-05-05 21:53 ` tornaria
2024-05-06 12:10 ` [PR PATCH] [Merged]: " leahneukirchen
2024-03-31 21:21 [PR PATCH] " r-ricci
2024-03-31 21:40 ` tornaria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240330225105.3F1CB25B22@inbox.vuxu.org \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).