From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] quazip: update to 1.4
Date: Wed, 10 Apr 2024 20:21:12 +0200 [thread overview]
Message-ID: <20240410182112.994B1220D9@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49782@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/49782#discussion_r1559882311
Comment:
this is incorrect, just some files were moved around and the -devel package should not be empty.
```diff
@@ -20,8 +20,8 @@ quazip-devel_package() {
short_desc+=" - development files"
pkg_install() {
vmove usr/include
- vmove usr/share
- vmove "usr/lib/*.a"
+ vmove usr/lib/cmake
+ vmove usr/lib/pkgconfig
vmove "usr/lib/*.so"
}
}
```
next prev parent reply other threads:[~2024-04-10 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 11:35 [PR PATCH] " ElHereward
2024-04-10 18:21 ` classabbyamp [this message]
2024-04-11 7:46 ` [PR PATCH] [Updated] " ElHereward
2024-04-11 7:47 ` ElHereward
2024-04-11 7:53 ` ElHereward
2024-04-11 11:40 ` classabbyamp
2024-04-11 11:46 ` ElHereward
2024-04-11 12:15 ` [PR PATCH] [Updated] " ElHereward
2024-05-16 1:42 ` [PR PATCH] [Closed]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410182112.994B1220D9@inbox.vuxu.org \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).