Re: [PR PATCH] [Updated] New package: jack-keyboard-2.7.2

[iFoundSilentHouse <iFoundSilentHouse@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

There is an updated pull request by iFoundSilentHouse against master on the void-packages repository

https://github.com/iFoundSilentHouse/void-packages jack-keyboard-2.7.2
https://github.com/void-linux/void-packages/pull/49790

New package: jack-keyboard-2.7.2
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): system, compiled

- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64-musl (cross)
  - armv7l (cross)


A patch file from https://github.com/void-linux/void-packages/pull/49790.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jack-keyboard-2.7.2-49790.patch --]
[-- Type: text/x-diff, Size: 3068 bytes --]

From d6016ef18266dffd462b0ef2e9b37a197afac687 Mon Sep 17 00:00:00 2001
From: IFoundSilentHouse <adeptslab@gmail.com>
Date: Wed, 10 Apr 2024 22:52:12 +0600
Subject: [PATCH 1/2] New package: jack-keyboard-2.7.2

---
 srcpkgs/jack-keyboard/template | 35 ++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 srcpkgs/jack-keyboard/template

diff --git a/srcpkgs/jack-keyboard/template b/srcpkgs/jack-keyboard/template
new file mode 100644
index 00000000000000..5c4a89142b1f8a
--- /dev/null
+++ b/srcpkgs/jack-keyboard/template
@@ -0,0 +1,35 @@
+# Template file for 'jack-keyboard'
+pkgname=jack-keyboard
+version=2.7.2
+revision=1
+build_style=gnu-makefile
+hostmakedepends="cmake pkg-config"
+makedepends="gtk+-devel jack-devel pango-devel"
+short_desc="Send jack midi events with PC keyboard"
+maintainer="IFoundSilentHouse <adeptslab@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://jack-keyboard.sourceforge.net/"
+distfiles="${SOURCEFORGE_SITE}/jack-keyboard/${version}/jack-keyboard-${version}.tar.gz"
+checksum=59953c996aa057146d4ccb7697d846dad87c3e7c4e3b05eeea6f47f3837a64fc
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" gtk+-devel"
+fi
+
+pre_build() {
+	mkdir -p build
+	cd build
+	CFLAGS+=" $(pkg-config --cflags gtk+-2.0)"
+	cmake ../ -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release \
+	-DLashEnable=False
+}
+
+do_build() {
+	# Package is built on "make install" phase
+	true
+}
+
+post_install() {
+	vlicense COPYING
+	mv "${DESTDIR}/usr/man" "${DESTDIR}/usr/share/man"
+}

From 82dbc9654f85512b615f213b7e4d1147304448d6 Mon Sep 17 00:00:00 2001
From: IFoundSilentHouse <adeptslab@gmail.com>
Date: Thu, 11 Apr 2024 02:25:16 +0600
Subject: [PATCH 2/2] jack-keyboard: update to 2.7.2.

---
 srcpkgs/jack-keyboard/template | 22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/srcpkgs/jack-keyboard/template b/srcpkgs/jack-keyboard/template
index 5c4a89142b1f8a..11ee2adc8b11cd 100644
--- a/srcpkgs/jack-keyboard/template
+++ b/srcpkgs/jack-keyboard/template
@@ -2,8 +2,9 @@
 pkgname=jack-keyboard
 version=2.7.2
 revision=1
-build_style=gnu-makefile
-hostmakedepends="cmake pkg-config"
+build_style=cmake
+configure_args="-DLashEnable=False"
+hostmakedepends="pkg-config"
 makedepends="gtk+-devel jack-devel pango-devel"
 short_desc="Send jack midi events with PC keyboard"
 maintainer="IFoundSilentHouse <adeptslab@gmail.com>"
@@ -12,21 +13,8 @@ homepage="https://jack-keyboard.sourceforge.net/"
 distfiles="${SOURCEFORGE_SITE}/jack-keyboard/${version}/jack-keyboard-${version}.tar.gz"
 checksum=59953c996aa057146d4ccb7697d846dad87c3e7c4e3b05eeea6f47f3837a64fc
 
-if [ "$CROSS_BUILD" ]; then
-	hostmakedepends+=" gtk+-devel"
-fi
-
-pre_build() {
-	mkdir -p build
-	cd build
-	CFLAGS+=" $(pkg-config --cflags gtk+-2.0)"
-	cmake ../ -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release \
-	-DLashEnable=False
-}
-
-do_build() {
-	# Package is built on "make install" phase
-	true
+pre_configure() {
+  CFLAGS+=" $(pkg-config --cflags gtk+-2.0)"
 }
 
 post_install() {