Github messages for voidlinux
 help / color / mirror / Atom feed
From: MIvanchev <MIvanchev@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: abaddon-0.2.1
Date: Fri, 12 Apr 2024 08:31:32 +0200	[thread overview]
Message-ID: <20240412063132.2928623517@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46753@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/46753#issuecomment-2051078742

Comment:
> Thanks for the suggestions. Do you know if there is a failure case if the icon entry is included without an icon? It seems to validate fine. I'd prefer to leave it because I'd likely forget to add it later.

Void doesn't validate the file at all. With my launcher (xlunch) there isn't any icon in this case (icon specified but not found) whereas xlunch puts a generic icon if there is no icon specified at all. So for me nothing is slightly better but different launchers likely handle this in their own manner.

> Can you also clarify why `hicolor-icon-theme` is required? My understanding is it is depended on if the app uses icons from the desktop icon theme for e.g. in its buttons, which abaddon does not do.

IMO the package is required if you use something from `/usr/share/icons/hicolor` even if you put it there but I'm not 100% certain.

  parent reply	other threads:[~2024-04-12  6:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 16:00 [PR PATCH] New package: abaddon-0.1.12 rookiejet
2023-10-17 16:01 ` [PR PATCH] [Updated] " rookiejet
2023-10-17 16:19 ` rookiejet
2023-10-17 16:46 ` rookiejet
2023-10-19 11:14 ` rookiejet
2023-11-03 11:05 ` rookiejet
2023-11-13 15:40 ` rookiejet
2023-12-08 20:14 ` [PR PATCH] [Updated] New package: abaddon-0.1.13 rookiejet
2023-12-11 14:12 ` [PR PATCH] [Updated] New package: abaddon-0.1.14 rookiejet
2024-01-30 10:11 ` MIvanchev
2024-03-28 18:31 ` [PR PATCH] [Updated] " rookiejet
2024-04-09 10:45 ` New package: abaddon-0.2.0 MIvanchev
2024-04-09 12:05 ` MIvanchev
2024-04-11 20:58 ` rookiejet
2024-04-11 21:15 ` [PR PATCH] [Updated] " rookiejet
2024-04-11 22:12 ` [PR PATCH] [Updated] New package: abaddon-0.2.1 rookiejet
2024-04-11 22:30 ` rookiejet
2024-04-12  6:31 ` MIvanchev [this message]
2024-04-12 13:27 ` rookiejet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240412063132.2928623517@inbox.vuxu.org \
    --to=mivanchev@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).