From: chrysos349 <chrysos349@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: freerdp3-3.5.0
Date: Mon, 22 Apr 2024 15:10:15 +0200 [thread overview]
Message-ID: <20240422131015.89DCC2019D@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49982@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
New comment by chrysos349 on void-packages repository
https://github.com/void-linux/void-packages/pull/49982#issuecomment-2069370159
Comment:
@ahesford
thanks for reviewing the template. fixed everything.
regarding "needlessly" exporting `CXX`, it is actually needed, or else the crossbuild will fail.
> In the future, please refrain from opening competing PRs
i'll keep it in mind.
@fanyx
being an optional dep, sdl2 pulls webkit which in turn pull a ton of packages. i decided to skip it (ubuntu does, for example).
otherwise, `freerdp3` will pull lots of deps.
p.s. another option is to split sdl version into a separate subpackage.
p.p.s. if it were up to me, i would also split x11 and wayland versions into separate packages also (debian does so).
next prev parent reply other threads:[~2024-04-22 13:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 11:33 [PR PATCH] " chrysos349
2024-04-22 12:17 ` [PR REVIEW] " ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:17 ` ahesford
2024-04-22 12:20 ` ahesford
2024-04-22 12:41 ` fanyx
2024-04-22 12:42 ` fanyx
2024-04-22 12:57 ` [PR PATCH] [Updated] " chrysos349
2024-04-22 13:10 ` chrysos349 [this message]
2024-04-22 13:15 ` chrysos349
2024-04-22 13:20 ` chrysos349
2024-04-22 13:53 ` [PR PATCH] [Updated] " chrysos349
2024-04-22 14:44 ` [PR REVIEW] " ahesford
2024-04-22 14:46 ` ahesford
2024-04-22 14:47 ` ahesford
2024-04-22 15:58 ` [PR PATCH] [Updated] " chrysos349
2024-04-22 15:58 ` chrysos349
2024-04-22 15:59 ` [PR REVIEW] " chrysos349
2024-04-22 21:08 ` [PR PATCH] [Updated] " chrysos349
2024-04-22 21:23 ` chrysos349
-- strict thread matches above, loose matches on Subject: below --
2024-03-27 19:17 [PR PATCH] freerdp: update to 3.4.0 fanyx
2024-04-20 14:42 ` New package: freerdp3-3.5.0 fanyx
2024-04-20 16:49 ` fanyx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422131015.89DCC2019D@inbox.vuxu.org \
--to=chrysos349@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).