From: meator <meator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] catch2: fix deceiving description
Date: Sun, 28 Apr 2024 18:55:57 +0200 [thread overview]
Message-ID: <20240428165557.5DA3B2573C@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46800@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]
There is an updated pull request by meator against master on the void-packages repository
https://github.com/meator/void-packages catch2
https://github.com/void-linux/void-packages/pull/46800
catch2: fix deceiving description
The `catch2` package is really weird by the way. It ships a _static_ library. It also doesn't have `catch2-devel`
because of this. I guess this is for developers only. I know Catch2 doesn't really like to be packaged, it prefers to be managed by the project's build system, but it still isn't standard to ship static libraries like this. Correct me if I'm wrong.
<!-- Uncomment relevant sections and delete options which are not applicable -->
ping @DBLouis
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/46800.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-catch2-46800.patch --]
[-- Type: text/x-diff, Size: 971 bytes --]
From 65f9d2b9b5e7e7ec4ea7644acc0317260a32eea0 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 20 Oct 2023 20:02:50 +0200
Subject: [PATCH] catch2: fix deceiving description
Catch2 isn't header only since version v3.0.0.
---
srcpkgs/catch2/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/catch2/template b/srcpkgs/catch2/template
index 92f07bd8029e8f..feddfed76b9df8 100644
--- a/srcpkgs/catch2/template
+++ b/srcpkgs/catch2/template
@@ -8,7 +8,7 @@ configure_args="-DCATCH_USE_VALGRIND=OFF -DCATCH_BUILD_TESTING=ON
-DCATCH_ENABLE_COVERAGE=OFF -DCATCH_ENABLE_WERROR=OFF
-DCATCH_INSTALL_DOCS=ON -DCATCH_INSTALL_HELPERS=ON"
hostmakedepends="python3"
-short_desc="C++ header-only test framework for unit-tests, TDD and BDD"
+short_desc="C++ test framework for unit-tests, TDD and BDD"
maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
license="BSL-1.0"
homepage="https://github.com/catchorg/Catch2"
next prev parent reply other threads:[~2024-04-28 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 18:10 [PR PATCH] " meator
2024-01-19 1:47 ` github-actions
2024-01-28 8:01 ` meator
2024-01-28 8:08 ` [PR PATCH] [Updated] " meator
2024-04-28 1:46 ` github-actions
2024-04-28 16:54 ` meator
2024-04-28 16:55 ` meator [this message]
2024-04-28 16:57 ` meator
2024-05-06 19:51 ` [PR PATCH] [Merged]: " cinerea0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428165557.5DA3B2573C@inbox.vuxu.org \
--to=meator@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).