Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: python3-trio-websocket-0.11.1 - Add python3-trio-websocket package
Date: Sun, 28 Apr 2024 20:15:21 +0200	[thread overview]
Message-ID: <20240428181521.81811234B2@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50098@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 3520 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50098#issuecomment-2081584576

Comment:
exceptiongroup shouldn't be needed, it's a compatibility backport for <3.11. upstream didn't do any kind of check for python >=3.11 so we should just patch it out:

<details><summary>add this to <code>srcpkgs/streamlink/patches/</code></summary>
<p>

```patch
exceptiongroup is for python<3.11 compat

--- a/src/streamlink.egg-info/requires.txt
+++ b/src/streamlink.egg-info/requires.txt
@@ -1,5 +1,4 @@
 certifi
-exceptiongroup
 isodate
 lxml<6,>=4.6.4
 pycountry
--- a/src/streamlink.egg-info/PKG-INFO
+++ b/src/streamlink.egg-info/PKG-INFO
@@ -32,7 +32,6 @@
 Description-Content-Type: text/markdown
 License-File: LICENSE
 Requires-Dist: certifi
-Requires-Dist: exceptiongroup
 Requires-Dist: isodate
 Requires-Dist: lxml<6,>=4.6.4
 Requires-Dist: pycountry
--- a/PKG-INFO
+++ b/PKG-INFO
@@ -32,7 +32,6 @@
 Description-Content-Type: text/markdown
 License-File: LICENSE
 Requires-Dist: certifi
-Requires-Dist: exceptiongroup
 Requires-Dist: isodate
 Requires-Dist: lxml<6,>=4.6.4
 Requires-Dist: pycountry
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -56,7 +56,6 @@
 requires-python = ">=3.8"
 dependencies = [
   "certifi",
-  "exceptiongroup",
   "isodate",
   "lxml >=4.6.4,<6",
   "pycountry",
--- a/src/streamlink/plugins/twitch.py
+++ b/src/streamlink/plugins/twitch.py
@@ -541,7 +541,6 @@
         headers: Mapping[str, str],
         device_id: str,
     ) -> Optional[Tuple[str, int]]:
-        from exceptiongroup import BaseExceptionGroup  # noqa: PLC0415, I001
         from streamlink.webbrowser.cdp import CDPClient, CDPClientSession, devtools  # noqa: PLC0415
 
         url = f"https://www.twitch.tv/{channel}"
--- a/src/streamlink/webbrowser/webbrowser.py
+++ b/src/streamlink/webbrowser/webbrowser.py
@@ -8,7 +8,6 @@
 from typing import AsyncContextManager, AsyncGenerator, Generator, List, Optional, Union
 
 import trio
-from exceptiongroup import BaseExceptionGroup
 
 from streamlink.utils.path import resolve_executable
 from streamlink.webbrowser.exceptions import WebbrowserError
--- a/src/streamlink/compat.py
+++ b/src/streamlink/compat.py
@@ -5,9 +5,6 @@
 import warnings
 from typing import Any, Callable, Dict, Optional, Tuple
 
-# import exceptiongroup, so it can monkeypatch ExceptionGroup logic on <=py311
-import exceptiongroup  # noqa: F401
-
 from streamlink.exceptions import StreamlinkDeprecationWarning
 
 
--- a/tests/webbrowser/test_webbrowser.py
+++ b/tests/webbrowser/test_webbrowser.py
@@ -7,7 +7,6 @@
 
 import pytest
 import trio
-from exceptiongroup import BaseExceptionGroup
 
 from streamlink.compat import is_win32
 from streamlink.webbrowser.exceptions import WebbrowserError
--- a/tests/webbrowser/cdp/test_connection.py
+++ b/tests/webbrowser/cdp/test_connection.py
@@ -7,7 +7,6 @@
 
 import pytest
 import trio
-from exceptiongroup import ExceptionGroup
 from trio.testing import MockClock, wait_all_tasks_blocked
 from trio_websocket import CloseReason, ConnectionClosed, ConnectionTimeout  # type: ignore[import]
 
--- a/tests/webbrowser/cdp/test_client.py
+++ b/tests/webbrowser/cdp/test_client.py
@@ -4,7 +4,6 @@
 
 import pytest
 import trio
-from exceptiongroup import ExceptionGroup
 from trio.testing import wait_all_tasks_blocked
 
 from streamlink.session import Streamlink
```

</p>
</details> 

  parent reply	other threads:[~2024-04-28 18:15 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28 14:39 [PR PATCH] " tstraus13
2024-04-28 14:48 ` [PR PATCH] [Updated] " tstraus13
2024-04-28 15:01 ` tstraus13
2024-04-28 16:18 ` classabbyamp
2024-04-28 16:18 ` classabbyamp
2024-04-28 16:25 ` tstraus13
2024-04-28 16:34 ` [PR PATCH] [Updated] " tstraus13
2024-04-28 17:29 ` tstraus13
2024-04-28 17:31 ` classabbyamp
2024-04-28 17:54 ` tstraus13
2024-04-28 17:54 ` tstraus13
2024-04-28 18:14 ` [PR PATCH] [Closed]: " classabbyamp
2024-04-28 18:14 ` classabbyamp
2024-04-28 18:15 ` classabbyamp [this message]
2024-04-28 18:19 ` tstraus13
2024-04-28 18:35 ` [PR PATCH] [Updated] " tstraus13
2024-04-28 18:37 ` tstraus13
2024-04-28 18:44 ` tstraus13
2024-04-28 18:45 ` tstraus13
2024-04-28 18:48 ` [PR PATCH] [Updated] " tstraus13
2024-05-01  1:47 ` tstraus13
2024-05-01  2:08 ` tstraus13
2024-05-06 18:34 ` tstraus13
2024-05-06 23:14 ` classabbyamp
2024-05-06 23:18 ` tstraus13
2024-05-06 23:20 ` classabbyamp
2024-05-06 23:22 ` tstraus13
2024-05-06 23:25 ` tstraus13
2024-05-06 23:53 ` tstraus13
2024-05-06 23:54 ` streamlink: update to 6.7.3 classabbyamp
2024-05-06 23:57 ` tstraus13
2024-05-07  0:39 ` [PR PATCH] [Updated] " tstraus13
2024-05-07  0:44 ` tstraus13
2024-05-07  0:55 ` classabbyamp
2024-05-07  1:08 ` [PR PATCH] [Updated] " tstraus13
2024-05-07  1:17 ` tstraus13
2024-05-07  1:19 ` tstraus13
2024-05-07  1:26 ` [PR PATCH] [Updated] " tstraus13
2024-05-07  1:29 ` tstraus13
2024-05-07  2:03 ` [PR PATCH] [Closed]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240428181521.81811234B2@inbox.vuxu.org \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).