[PR PATCH] New package: fastfetch-2.11.5

[PR PATCH] New package: fastfetch-2.11.5

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is a new pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR n/fastfetch
https://github.com/void-linux/void-packages/pull/50291

New package: fastfetch-2.11.5

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)


A patch file from https://github.com/void-linux/void-packages/pull/50291.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-n/fastfetch-50291.patch --]
[-- Type: text/x-diff, Size: 1315 bytes --]

From be91523eb2f08a692e8e376e6ac53b7a68001066 Mon Sep 17 00:00:00 2001
From: zenobit <zenobit@disroot.org>
Date: Sun, 12 May 2024 11:16:01 +0200
Subject: [PATCH] New package: fastfetch-2.11.5

---
 srcpkgs/fastfetch/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/fastfetch/template

diff --git a/srcpkgs/fastfetch/template b/srcpkgs/fastfetch/template
new file mode 100644
index 00000000000000..c3aeb9546b0ab5
--- /dev/null
+++ b/srcpkgs/fastfetch/template
@@ -0,0 +1,19 @@
+# Template file for 'fastfetch'
+pkgname=fastfetch
+version=2.11.5
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config python3 ddcutil Vulkan-Headers"
+makedepends="libxcb-devel libXrandr-devel libX11-devel libdrm-devel garcon-devel dconf-devel sqlite-devel librpm-devel libmagick-devel libnma-devel pulseaudio-devel wayland-devel zlib-devel chafa-devel"
+depends="glibc"
+short_desc="Like neofetch, but much faster because written mostly in C"
+maintainer="zenobit <zenobit@disroot.org>"
+license="MIT"
+homepage="https://github.com/fastfetch-cli/fastfetch"
+#changelog=""
+distfiles="https://github.com/fastfetch-cli/fastfetch/archive/refs/tags/${version}.tar.gz"
+checksum=83b7699d0aee3aa1683721fe4b82d667c88e97e257d48e9efe586b0e830f8a64
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: fastfetch-2.11.5

[meator]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/50291#issuecomment-2106186194

Comment:
This is a duplicate of #50201

Re: [PR PATCH] [Closed]: New package: fastfetch-2.11.5

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

There's a closed pull request on the void-packages repository

New package: fastfetch-2.11.5
https://github.com/void-linux/void-packages/pull/50291

Description:

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

Re: New package: fastfetch-2.11.5

[SpidFightFR]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by SpidFightFR on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2113418066

Comment:
hey, i've been using fastfetch as well for the past 5 months or so, with a personal template i work on, it never broke for me.

I personally approve the addition of fastfetch as a replacement for neofetch. :v:

Re: New package: fastfetch-2.11.5

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106372649

Comment:
Absolutely, great work!

Re: New package: fastfetch-2.11.5

[fvalasiad]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

New comment by fvalasiad on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106370576

Comment:
> On Sun, May 12, 2024 at 01:18:16PM GMT, Fotios Valasiadis wrote: Sure! `./xbps-src pkg fastfetch` fails with that though complaining that: > => ERROR: fastfetch-2.11.5_1: '/etc/fastfetch/config.conf' configuration file not in PKGDESTDIR! > => ERROR: fastfetch-2.11.5_1: cannot continue with installation! Any ideas?
> On second though, maybe it's not a good idea 1. It's deprecated
> We are deprecating flags based config files (will be removed in v3.0.0). We suggest you migrate to json based config files. One may use -c /path/to/config.conf --gen-config to migrate existing flag based config files.
> https://github.com/fastfetch-cli/fastfetch/blob/dev/CHANGELOG.md#240 2. The package doesn't need a "default config", so in theory it won't be overwritten by xbps But thanks for testing it out!

Gucci, removed `configure_args` from the top and added a conditional append, just in case we wanna define default configure flags in the future. If that's alright with you!

Re: New package: fastfetch-2.11.5

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106368349

Comment:
On Sun, May 12, 2024 at 01:18:16PM GMT, Fotios Valasiadis wrote:
>Sure! `./xbps-src pkg fastfetch` fails with that though complaining that:
>
>> => ERROR: fastfetch-2.11.5_1: '/etc/fastfetch/config.conf' configuration file not in PKGDESTDIR!
>> => ERROR: fastfetch-2.11.5_1: cannot continue with installation!
>
>Any ideas?

On second though, maybe it's not a good idea

1. It's deprecated
> We are deprecating flags based config files (will be removed in v3.0.0).
> We suggest you migrate to json based config files. One may use -c
> /path/to/config.conf --gen-config to migrate existing flag based config
> files.

https://github.com/fastfetch-cli/fastfetch/blob/dev/CHANGELOG.md#240

2. The package doesn't need a "default config", so in theory it won't be
    overwritten by xbps

But thanks for testing it out!

Re: New package: fastfetch-2.11.5

[fvalasiad]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by fvalasiad on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106363647

Comment:
Sure! `./xbps-src pkg fastfetch` fails with that though complaining that:

> => ERROR: fastfetch-2.11.5_1: '/etc/fastfetch/config.conf' configuration file not in PKGDESTDIR!
> => ERROR: fastfetch-2.11.5_1: cannot continue with installation!

Any ideas?

Re: New package: fastfetch-2.11.5

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106342476

Comment:
Side note, a better alternative might be to only build the tests when
the tests will be ran, and not always build them

```bash
if [ "$XBPS_CHECK_PKGS" ]; then
	configure_args="-DBUILD_TESTS=ON"
fi
```

Re: New package: fastfetch-2.11.5

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106339794

Comment:
On Sun, May 12, 2024 at 10:32:43AM GMT, Fotios Valasiadis wrote:
>> please add conf_file and changelog. like this #38310
>
>Adding the changelog certainly, but uncertain about `conf_files`.

Seems like fastfetch has an undocumented /etc/fastfetch/config.conf file
that takes in CLI arguments. For example:

```
--logo windows
--color cyan
--kernel-format {1} {2}
--host-format {2}
```

What @hervyqa is asking is you add
`conf_files="/etc/fastfetch/config.conf"` under `configure_args`, how
the PR linked does it

https://github.com/void-linux/void-packages/pull/38310/files#diff-4db011d7f520a56f51c21a61c5db944e05bafe1cbe4cbaa570f4099d2715a5eeR7

Re: New package: fastfetch-2.11.5

[fvalasiad]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

New comment by fvalasiad on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106321981

Comment:
> please add conf_file and changelog. like this #38310

Adding the changelog certainly, but uncertain about `conf_files`.

If that's meant to point to fastfetch's config, then according to its manpage:

> Config Files
>        Fastfetch uses JSONC based format for configuration. Fastfetch doesn't
>        generate config file automatically; it should be generated manually by
>        --gen-config.  The config file will be saved in
>        ~/.config/fastfetch/config.jsonc by default.

If you are willing to provide an extra pointer to what requesting I'll try my best to deliver!

Re: New package: fastfetch-2.11.5

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106061810

Comment:
please add conf_file and changelog. like this #38310

Re: New package: fastfetch-2.11.5

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2106061810

Comment:
please add changelog. like this #38310

Re: New package: fastfetch-2.11.5

[fvalasiad]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by fvalasiad on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2102334063

Comment:
@AnInternetTroll Surely! Patch applied.
Also added you as a Co-author

I've tested on x86_64-glibc, x86_64-musl, aarch64-glibc.

Re: New package: fastfetch-2.11.5

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/50201#issuecomment-2102263585

Comment:
Tested on x86\_64-glibc and works as expected!