[PR PATCH] zulip-desktop: update to 5.10.0

[PR PATCH] zulip-desktop: update to 5.10.0

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is a new pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages zulip-desktop
https://github.com/void-linux/void-packages/pull/45242

zulip-desktop: update to 5.10.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

![Screenshot_20230725_162512](https://github.com/void-linux/void-packages/assets/45872139/562b86f7-97ab-45db-86dd-c62e1423b0f5)


A patch file from https://github.com/void-linux/void-packages/pull/45242.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zulip-desktop-45242.patch --]
[-- Type: text/x-diff, Size: 2786 bytes --]

From 438d85c0a440a62f537ef2ed1e7616f15a4f4905 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@proton.me>
Date: Tue, 25 Jul 2023 15:30:23 +0700
Subject: [PATCH] zulip-desktop: update to 5.10.0

---
 srcpkgs/zulip-desktop/files/zulip.desktop |  8 ++++
 srcpkgs/zulip-desktop/template            | 48 ++++++++++++++++++-----
 2 files changed, 47 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/zulip-desktop/files/zulip.desktop

diff --git a/srcpkgs/zulip-desktop/files/zulip.desktop b/srcpkgs/zulip-desktop/files/zulip.desktop
new file mode 100644
index 0000000000000..72f45a6bea23c
--- /dev/null
+++ b/srcpkgs/zulip-desktop/files/zulip.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Type=Application
+Name=Zulip
+Comment=Open-source team chat with topic-based threading
+Exec=zulip
+Icon=zulip
+Categories=Network;InstantMessaging;
+StartupWMClass=Zulip
diff --git a/srcpkgs/zulip-desktop/template b/srcpkgs/zulip-desktop/template
index 0a7cff02033f9..9447ffbb049aa 100644
--- a/srcpkgs/zulip-desktop/template
+++ b/srcpkgs/zulip-desktop/template
@@ -1,14 +1,44 @@
 # Template file for 'zulip-desktop'
 pkgname=zulip-desktop
-version=0.5.1
-revision=2
-build_style=cmake
-configure_args="-DBUILD_WITH_QT5=On"
-hostmakedepends="qt5-host-tools qt5-qmake"
-makedepends="qt5-webkit-devel phonon-qt5-devel qt5-svg-devel qt5-multimedia-devel"
+version=5.10.0
+revision=1
+_electronver=24.3.0
+_npmver=9.5.1
+hostmakedepends="nodejs python3"
+makedepends="GConf-devel electron24 libxkbfile-devel libXtst-devel"
+depends="electron24 gtk+3 nss"
 short_desc="Workplace chat that improves your productivity"
 maintainer="Luca - <luca.andrea.fuse@gmx.com>"
 license="Apache-2.0"
-homepage="https://www.zulip.org/"
-distfiles="https://github.com/zulip/zulip-desktop-legacy/archive/${version}.tar.gz"
-checksum=2475e5298b7df29c7ee8585da7189f4af8dda279e5e1d6e26c8f3fa08ce31ae5
+homepage="https://www.zulip.com"
+distfiles="https://github.com/zulip/zulip-desktop/archive/refs/tags/v${version}.tar.gz"
+checksum=03dde91bc8f8e8d750dcc0a240f0efda65578fb7d99ced0a04a47ec88bbc1f2e
+
+do_configure() {
+	cd "$wrksrc"
+	npm ci
+}
+
+do_build() {
+	npm install -g npm@${_npmver}
+	npm run pack
+
+	/usr/lib/node_modules/npm/bin/node-gyp-bin/node-gyp install \
+	--target=$_electronver \
+	--tarball=/usr/include/electron${_electronver%%.*}/node_headers.tar.gz
+}
+
+do_install() {
+	cat > zulip <<-EOF
+	#!/bin/sh
+	exec electron${_electronver%%.*} /usr/lib/zulip.asar "\$@"
+	EOF
+	vbin zulip
+
+	vinstall "dist/linux-unpacked/resources/app.asar" 644 /usr/lib zulip.asar
+	vinstall ${FILESDIR}/zulip.desktop 0644 usr/share/applications
+
+	for i in 16 24 32 48 64 128 256 512 1024 ; do
+		vinstall build/icons/${i}x${i}.png 644 usr/share/icons/hicolor/${i}x${i}/apps zulip.png
+	done
+}

Re: [PR PATCH] [Updated] zulip-desktop: update to 5.10.0

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is an updated pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages zulip-desktop
https://github.com/void-linux/void-packages/pull/45242

zulip-desktop: update to 5.10.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

![Screenshot_20230725_162512](https://github.com/void-linux/void-packages/assets/45872139/562b86f7-97ab-45db-86dd-c62e1423b0f5)


A patch file from https://github.com/void-linux/void-packages/pull/45242.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zulip-desktop-45242.patch --]
[-- Type: text/x-diff, Size: 2801 bytes --]

From 39a4337ec0ba85ff3056cf939f04f007fa1c4653 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@proton.me>
Date: Tue, 25 Jul 2023 15:30:23 +0700
Subject: [PATCH] zulip-desktop: update to 5.10.0

---
 srcpkgs/zulip-desktop/files/zulip.desktop |  8 ++++
 srcpkgs/zulip-desktop/template            | 48 ++++++++++++++++++-----
 2 files changed, 47 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/zulip-desktop/files/zulip.desktop

diff --git a/srcpkgs/zulip-desktop/files/zulip.desktop b/srcpkgs/zulip-desktop/files/zulip.desktop
new file mode 100644
index 0000000000000..72f45a6bea23c
--- /dev/null
+++ b/srcpkgs/zulip-desktop/files/zulip.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Type=Application
+Name=Zulip
+Comment=Open-source team chat with topic-based threading
+Exec=zulip
+Icon=zulip
+Categories=Network;InstantMessaging;
+StartupWMClass=Zulip
diff --git a/srcpkgs/zulip-desktop/template b/srcpkgs/zulip-desktop/template
index 0a7cff02033f9..2572656d600ed 100644
--- a/srcpkgs/zulip-desktop/template
+++ b/srcpkgs/zulip-desktop/template
@@ -1,14 +1,44 @@
 # Template file for 'zulip-desktop'
 pkgname=zulip-desktop
-version=0.5.1
-revision=2
-build_style=cmake
-configure_args="-DBUILD_WITH_QT5=On"
-hostmakedepends="qt5-host-tools qt5-qmake"
-makedepends="qt5-webkit-devel phonon-qt5-devel qt5-svg-devel qt5-multimedia-devel"
+version=5.10.0
+revision=1
+_electronver=24.3.0
+_npmver=9.5.1
+hostmakedepends="nodejs python3"
+makedepends="GConf-devel electron24 libxkbfile-devel libXtst-devel"
+depends="electron24 gtk+3 nss"
 short_desc="Workplace chat that improves your productivity"
 maintainer="Luca - <luca.andrea.fuse@gmx.com>"
 license="Apache-2.0"
-homepage="https://www.zulip.org/"
-distfiles="https://github.com/zulip/zulip-desktop-legacy/archive/${version}.tar.gz"
-checksum=2475e5298b7df29c7ee8585da7189f4af8dda279e5e1d6e26c8f3fa08ce31ae5
+homepage="https://www.zulip.com"
+distfiles="https://github.com/zulip/zulip-desktop/archive/refs/tags/v${version}.tar.gz"
+checksum=03dde91bc8f8e8d750dcc0a240f0efda65578fb7d99ced0a04a47ec88bbc1f2e
+
+do_configure() {
+	cd "$wrksrc"
+	npm ci
+}
+
+do_build() {
+	npm install -g npm@${_npmver}
+	npm run pack
+
+	/usr/lib/node_modules/npm/bin/node-gyp-bin/node-gyp install \
+	--target=$_electronver \
+	--tarball=/usr/include/electron${_electronver%%.*}/node_headers.tar.gz
+}
+
+do_install() {
+	cat > zulip <<-EOF
+	#!/bin/sh
+	exec electron${_electronver%%.*} /usr/lib/zulip-desktop/app.asar "\$@"
+	EOF
+	vbin zulip
+
+	vinstall "dist/linux-unpacked/resources/app.asar" 644 /usr/lib/zulip-desktop
+	vinstall ${FILESDIR}/zulip.desktop 0644 usr/share/applications
+
+	for i in 16 24 32 48 64 128 256 512 1024 ; do
+		vinstall build/icons/${i}x${i}.png 644 usr/share/icons/hicolor/${i}x${i}/apps zulip.png
+	done
+}

Re: [PR REVIEW] zulip-desktop: update to 5.10.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#discussion_r1273892125

Comment:
this should be contributed upstream instead of vendored

Re: [PR REVIEW] zulip-desktop: update to 5.10.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#discussion_r1273892848

Comment:
should already be in this dir

Re: [PR REVIEW] zulip-desktop: update to 5.10.0

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New review comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#discussion_r1274260366

Comment:
sorry, I don't understand about electron at all :(
https://github.com/zulip/zulip-desktop/issues/1321

Re: [PR PATCH] [Updated] zulip-desktop: update to 5.10.0

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is an updated pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages zulip-desktop
https://github.com/void-linux/void-packages/pull/45242

zulip-desktop: update to 5.10.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

![Screenshot_20230725_162512](https://github.com/void-linux/void-packages/assets/45872139/562b86f7-97ab-45db-86dd-c62e1423b0f5)


A patch file from https://github.com/void-linux/void-packages/pull/45242.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zulip-desktop-45242.patch --]
[-- Type: text/x-diff, Size: 2800 bytes --]

From a725d4b901f7c5d48861a7c5ed790d0faa21d16b Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@proton.me>
Date: Tue, 25 Jul 2023 15:30:23 +0700
Subject: [PATCH] zulip-desktop: update to 5.10.0

---
 srcpkgs/zulip-desktop/files/zulip.desktop |  9 +++++
 srcpkgs/zulip-desktop/template            | 47 ++++++++++++++++++-----
 2 files changed, 47 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/zulip-desktop/files/zulip.desktop

diff --git a/srcpkgs/zulip-desktop/files/zulip.desktop b/srcpkgs/zulip-desktop/files/zulip.desktop
new file mode 100644
index 0000000000000..1ba42f21f80d4
--- /dev/null
+++ b/srcpkgs/zulip-desktop/files/zulip.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=Zulip
+Exec=zulip
+Terminal=false
+Type=Application
+Icon=zulip
+StartupWMClass=Zulip
+Comment=Zulip Desktop Client for Linux
+Categories=Chat;GNOME;GTK;Network;InstantMessaging;
diff --git a/srcpkgs/zulip-desktop/template b/srcpkgs/zulip-desktop/template
index 0a7cff02033f9..99b7c41e61da8 100644
--- a/srcpkgs/zulip-desktop/template
+++ b/srcpkgs/zulip-desktop/template
@@ -1,14 +1,43 @@
 # Template file for 'zulip-desktop'
 pkgname=zulip-desktop
-version=0.5.1
-revision=2
-build_style=cmake
-configure_args="-DBUILD_WITH_QT5=On"
-hostmakedepends="qt5-host-tools qt5-qmake"
-makedepends="qt5-webkit-devel phonon-qt5-devel qt5-svg-devel qt5-multimedia-devel"
+version=5.10.0
+revision=1
+_electronver=24.3.0
+_npmver=9.5.1
+hostmakedepends="nodejs python3"
+makedepends="GConf-devel electron24 libxkbfile-devel libXtst-devel"
+depends="electron24 gtk+3 nss"
 short_desc="Workplace chat that improves your productivity"
 maintainer="Luca - <luca.andrea.fuse@gmx.com>"
 license="Apache-2.0"
-homepage="https://www.zulip.org/"
-distfiles="https://github.com/zulip/zulip-desktop-legacy/archive/${version}.tar.gz"
-checksum=2475e5298b7df29c7ee8585da7189f4af8dda279e5e1d6e26c8f3fa08ce31ae5
+homepage="https://www.zulip.com"
+distfiles="https://github.com/zulip/zulip-desktop/archive/refs/tags/v${version}.tar.gz"
+checksum=03dde91bc8f8e8d750dcc0a240f0efda65578fb7d99ced0a04a47ec88bbc1f2e
+
+do_configure() {
+	npm ci
+}
+
+do_build() {
+	npm install -g npm@${_npmver}
+	npm run pack
+
+	/usr/lib/node_modules/npm/bin/node-gyp-bin/node-gyp install \
+	--target=$_electronver \
+	--tarball=/usr/include/electron${_electronver%%.*}/node_headers.tar.gz
+}
+
+do_install() {
+	cat > zulip <<-EOF
+	#!/bin/sh
+	exec electron${_electronver%%.*} /usr/lib/zulip-desktop/app.asar "\$@"
+	EOF
+	vbin zulip
+
+	vinstall "dist/linux-unpacked/resources/app.asar" 644 /usr/lib/zulip-desktop
+	vinstall ${FILESDIR}/zulip.desktop 0644 usr/share/applications
+
+	for i in 16 24 32 48 64 128 256 512 1024 ; do
+		vinstall build/icons/${i}x${i}.png 644 usr/share/icons/hicolor/${i}x${i}/apps zulip.png
+	done
+}

Re: [PR REVIEW] zulip-desktop: update to 5.10.0

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New review comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#discussion_r1274263902

Comment:
removed, done.

Re: zulip-desktop: update to 5.10.0

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#issuecomment-1665498819

Comment:
fix: #41402

Re: zulip-desktop: update to 5.10.0

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#issuecomment-1665498819

Comment:
fix: #41402

Re: [PR REVIEW] zulip-desktop: update to 5.10.0

[selfisekai]

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

New review comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#discussion_r1327897592

Comment:
@classabbyamp fyi, I think upstream won't ever care, because for them this is auto-generated by electron-builder (which only does not generate it if you use `target=dir` :).

shameless plug alert: what I do in alpine is [electron_tasje](https://codeberg.org/selfisekai/electron_tasje), but that is so far broken in other noticeable ways (like requiring to remove dev deps before packing). also I think I can make just the desktop generator available in cli, if you want

Re: [PR PATCH] [Updated] zulip-desktop: update to 5.10.0

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is an updated pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages zulip-desktop
https://github.com/void-linux/void-packages/pull/45242

zulip-desktop: update to 5.10.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

fix: #41402

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

![Screenshot_20230725_162512](https://github.com/void-linux/void-packages/assets/45872139/562b86f7-97ab-45db-86dd-c62e1423b0f5)


A patch file from https://github.com/void-linux/void-packages/pull/45242.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zulip-desktop-45242.patch --]
[-- Type: text/x-diff, Size: 2800 bytes --]

From bbedf3ff5c79a56edb46ad71e26753fbcd9092e0 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@proton.me>
Date: Tue, 25 Jul 2023 15:30:23 +0700
Subject: [PATCH] zulip-desktop: update to 5.10.2

---
 srcpkgs/zulip-desktop/files/zulip.desktop |  9 +++++
 srcpkgs/zulip-desktop/template            | 47 ++++++++++++++++++-----
 2 files changed, 47 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/zulip-desktop/files/zulip.desktop

diff --git a/srcpkgs/zulip-desktop/files/zulip.desktop b/srcpkgs/zulip-desktop/files/zulip.desktop
new file mode 100644
index 0000000000000..1ba42f21f80d4
--- /dev/null
+++ b/srcpkgs/zulip-desktop/files/zulip.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=Zulip
+Exec=zulip
+Terminal=false
+Type=Application
+Icon=zulip
+StartupWMClass=Zulip
+Comment=Zulip Desktop Client for Linux
+Categories=Chat;GNOME;GTK;Network;InstantMessaging;
diff --git a/srcpkgs/zulip-desktop/template b/srcpkgs/zulip-desktop/template
index 0a7cff02033f9..ba64124badde0 100644
--- a/srcpkgs/zulip-desktop/template
+++ b/srcpkgs/zulip-desktop/template
@@ -1,14 +1,43 @@
 # Template file for 'zulip-desktop'
 pkgname=zulip-desktop
-version=0.5.1
-revision=2
-build_style=cmake
-configure_args="-DBUILD_WITH_QT5=On"
-hostmakedepends="qt5-host-tools qt5-qmake"
-makedepends="qt5-webkit-devel phonon-qt5-devel qt5-svg-devel qt5-multimedia-devel"
+version=5.10.2
+revision=1
+_electronver=24.3.0
+_npmver=9.5.1
+hostmakedepends="nodejs python3"
+makedepends="GConf-devel electron24 libxkbfile-devel libXtst-devel"
+depends="electron24 gtk+3 nss"
 short_desc="Workplace chat that improves your productivity"
 maintainer="Luca - <luca.andrea.fuse@gmx.com>"
 license="Apache-2.0"
-homepage="https://www.zulip.org/"
-distfiles="https://github.com/zulip/zulip-desktop-legacy/archive/${version}.tar.gz"
-checksum=2475e5298b7df29c7ee8585da7189f4af8dda279e5e1d6e26c8f3fa08ce31ae5
+homepage="https://www.zulip.com"
+distfiles="https://github.com/zulip/zulip-desktop/archive/refs/tags/v${version}.tar.gz"
+checksum=16653132be24301035271a910b5230b8142816e4446f537385fbf90eaccd9b49
+
+do_configure() {
+	npm ci
+}
+
+do_build() {
+	npm install -g npm@${_npmver}
+	npm run pack
+
+	/usr/lib/node_modules/npm/bin/node-gyp-bin/node-gyp install \
+	--target=$_electronver \
+	--tarball=/usr/include/electron${_electronver%%.*}/node_headers.tar.gz
+}
+
+do_install() {
+	cat > zulip <<-EOF
+	#!/bin/sh
+	exec electron${_electronver%%.*} /usr/lib/zulip-desktop/app.asar "\$@"
+	EOF
+	vbin zulip
+
+	vinstall "dist/linux-unpacked/resources/app.asar" 644 /usr/lib/zulip-desktop
+	vinstall ${FILESDIR}/zulip.desktop 0644 usr/share/applications
+
+	for i in 16 24 32 48 64 128 256 512 1024 ; do
+		vinstall build/icons/${i}x${i}.png 644 usr/share/icons/hicolor/${i}x${i}/apps zulip.png
+	done
+}

Re: [PR PATCH] [Updated] zulip-desktop: update to 5.10.2

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is an updated pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages zulip-desktop
https://github.com/void-linux/void-packages/pull/45242

zulip-desktop: update to 5.10.2
<!-- Uncomment relevant sections and delete options which are not applicable -->

fix: #41402

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

![Screenshot_20230725_162512](https://github.com/void-linux/void-packages/assets/45872139/562b86f7-97ab-45db-86dd-c62e1423b0f5)


A patch file from https://github.com/void-linux/void-packages/pull/45242.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zulip-desktop-45242.patch --]
[-- Type: text/x-diff, Size: 2800 bytes --]

From 97c443d7aea38371b6bf95d7715afd29a970f730 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@proton.me>
Date: Tue, 25 Jul 2023 15:30:23 +0700
Subject: [PATCH] zulip-desktop: update to 5.10.3

---
 srcpkgs/zulip-desktop/files/zulip.desktop |  9 +++++
 srcpkgs/zulip-desktop/template            | 47 ++++++++++++++++++-----
 2 files changed, 47 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/zulip-desktop/files/zulip.desktop

diff --git a/srcpkgs/zulip-desktop/files/zulip.desktop b/srcpkgs/zulip-desktop/files/zulip.desktop
new file mode 100644
index 0000000000000..1ba42f21f80d4
--- /dev/null
+++ b/srcpkgs/zulip-desktop/files/zulip.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=Zulip
+Exec=zulip
+Terminal=false
+Type=Application
+Icon=zulip
+StartupWMClass=Zulip
+Comment=Zulip Desktop Client for Linux
+Categories=Chat;GNOME;GTK;Network;InstantMessaging;
diff --git a/srcpkgs/zulip-desktop/template b/srcpkgs/zulip-desktop/template
index 0a7cff02033f9..43f160bb60209 100644
--- a/srcpkgs/zulip-desktop/template
+++ b/srcpkgs/zulip-desktop/template
@@ -1,14 +1,43 @@
 # Template file for 'zulip-desktop'
 pkgname=zulip-desktop
-version=0.5.1
-revision=2
-build_style=cmake
-configure_args="-DBUILD_WITH_QT5=On"
-hostmakedepends="qt5-host-tools qt5-qmake"
-makedepends="qt5-webkit-devel phonon-qt5-devel qt5-svg-devel qt5-multimedia-devel"
+version=5.10.3
+revision=1
+_electronver=24.3.0
+_npmver=9.5.1
+hostmakedepends="nodejs python3"
+makedepends="GConf-devel electron24 libxkbfile-devel libXtst-devel"
+depends="electron24 gtk+3 nss"
 short_desc="Workplace chat that improves your productivity"
 maintainer="Luca - <luca.andrea.fuse@gmx.com>"
 license="Apache-2.0"
-homepage="https://www.zulip.org/"
-distfiles="https://github.com/zulip/zulip-desktop-legacy/archive/${version}.tar.gz"
-checksum=2475e5298b7df29c7ee8585da7189f4af8dda279e5e1d6e26c8f3fa08ce31ae5
+homepage="https://www.zulip.com"
+distfiles="https://github.com/zulip/zulip-desktop/archive/refs/tags/v${version}.tar.gz"
+checksum=0ac9a029943030c21c8f77b09c48d49d0bd9823532577bee17d83ebf0fbbd177
+
+do_configure() {
+	npm ci
+}
+
+do_build() {
+	npm install -g npm@${_npmver}
+	npm run pack
+
+	/usr/lib/node_modules/npm/bin/node-gyp-bin/node-gyp install \
+	--target=$_electronver \
+	--tarball=/usr/include/electron${_electronver%%.*}/node_headers.tar.gz
+}
+
+do_install() {
+	cat > zulip <<-EOF
+	#!/bin/sh
+	exec electron${_electronver%%.*} /usr/lib/zulip-desktop/app.asar "\$@"
+	EOF
+	vbin zulip
+
+	vinstall "dist/linux-unpacked/resources/app.asar" 644 /usr/lib/zulip-desktop
+	vinstall ${FILESDIR}/zulip.desktop 0644 usr/share/applications
+
+	for i in 16 24 32 48 64 128 256 512 1024 ; do
+		vinstall build/icons/${i}x${i}.png 644 usr/share/icons/hicolor/${i}x${i}/apps zulip.png
+	done
+}

Re: zulip-desktop: update to 5.10.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#issuecomment-1872421597

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: zulip-desktop: update to 5.10.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

There's a closed pull request on the void-packages repository

zulip-desktop: update to 5.10.3
https://github.com/void-linux/void-packages/pull/45242

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

fix: #41402

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

![Screenshot_20230725_162512](https://github.com/void-linux/void-packages/assets/45872139/562b86f7-97ab-45db-86dd-c62e1423b0f5)

Re: zulip-desktop: update to 5.10.3

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#issuecomment-2118272117

Comment:
Was there anything blocking this PR, or just lack of interest?
would it be ok if I take it over? some friends want to use this for work..

Re: zulip-desktop: update to 5.10.3

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#issuecomment-2119174726

Comment:
@dkwo yes of course, no problem.

Re: zulip-desktop: update to 5.10.3

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/45242#issuecomment-2121198573

Comment:
I discovered we also have the terminal version, using that for now.
An updated version of this PR was building ok for me, but crashing yesterday. I tried it again today (after using the terminal one and creating zuliprc) and it seems to work, with `zulip --ozone-platform-hint=wayland`. I may go back to this later.