From: r-ricci <r-ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: 7zip: update to 24.05
Date: Sat, 18 May 2024 14:10:28 +0200 [thread overview]
Message-ID: <20240518121028.E18242509D@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50396@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
New comment by r-ricci on void-packages repository
https://github.com/void-linux/void-packages/pull/50396#issuecomment-2118407708
Comment:
> I'm don't think `armv7.patch` is necessary anymore.
Correct.
> Also I'm not sure why some of parts of `build_flags.patch` are necessary (package works fine without the entire patch), but I updated it anyway.
There are certain build flags (specified in various parts of the `common/environment` subdirectory of void-packages) which we want to always use when building all packages.
Good build systems should append the project's flags to the ones specified in environment variables such as `CFLAGS`, `CXXFLAGS`, `LDFLAGS` etc.
But 7zip's build system is a huge mess with hardcoded values which doesn't respect the environment.
You can see that by removing the patch and looking at the build log, some flags such as `-fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -pipe` are no longer passed.
next prev parent reply other threads:[~2024-05-18 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 19:51 [PR PATCH] " Zapeth
2024-05-17 21:32 ` r-ricci
2024-05-18 12:10 ` r-ricci [this message]
2024-05-19 15:13 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240518121028.E18242509D@inbox.vuxu.org \
--to=r-ricci@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).