Github messages for voidlinux
 help / color / mirror / Atom feed
From: ibhagwan <ibhagwan@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: neovim: update to 0.10.0
Date: Sun, 19 May 2024 20:37:01 +0200	[thread overview]
Message-ID: <20240519183701.9DD702580F@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50372@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

New comment by ibhagwan on void-packages repository

https://github.com/void-linux/void-packages/pull/50372#issuecomment-2119324597

Comment:
> > Why separately? When I build neovim locally and these are built inside the neovim build folder, isn’t this as simple as adding these files to the package?
> 
> we explicitly don't invoke the `cmake.deps` step, and furthermore bundled deps need to be downloaded and our build_style cmake **specifically** disables network access so that doesn't happen.

So do you think this can be released as is without the libs or should we block merging of this package for a while?

Having an error and no highlights when opening a lua/markdown/etc file isn’t really acceptable IMHO. 

  parent reply	other threads:[~2024-05-19 18:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 16:56 [PR PATCH] WIP " tranzystorekk
2024-05-16 18:20 ` [PR PATCH] [Updated] " classabbyamp
2024-05-16 21:06 ` tranzystorekk
2024-05-16 21:39 ` tranzystorekk
2024-05-16 22:54 ` classabbyamp
2024-05-16 23:04 ` [PR PATCH] [Updated] " tranzystorekk
2024-05-18 16:00 ` AnInternetTroll
2024-05-18 16:08 ` classabbyamp
2024-05-19 17:33 ` ibhagwan
2024-05-19 18:19 ` tranzystorekk
2024-05-19 18:25 ` ibhagwan
2024-05-19 18:28 ` tranzystorekk
2024-05-19 18:31 ` tranzystorekk
2024-05-19 18:37 ` ibhagwan [this message]
2024-05-19 19:02 ` tranzystorekk
2024-05-19 20:55 ` [PR PATCH] [Updated] " tranzystorekk
2024-05-19 21:09 ` ibhagwan
2024-05-19 21:15 ` ibhagwan
2024-05-19 21:26 ` [PR PATCH] [Updated] " tranzystorekk
2024-05-19 21:30 ` [PR REVIEW] " classabbyamp
2024-05-19 22:07 ` [PR PATCH] [Updated] " tranzystorekk
2024-05-20  7:23 ` vazw
2024-05-20  8:37 ` vazw
2024-05-21 22:23 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240519183701.9DD702580F@inbox.vuxu.org \
    --to=ibhagwan@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).