[PR PATCH] okular: add runtime depend phonon-backend-vlc, required for embedded …

[PR PATCH] okular: add runtime depend phonon-backend-vlc, required for embedded …

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

There is a new pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages okular
https://github.com/void-linux/void-packages/pull/50405

okular: add runtime depend phonon-backend-vlc, required for embedded …
…file

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-okular-50405.patch --]
[-- Type: text/x-diff, Size: 1243 bytes --]

From 5c5659b70e85acf0fcb9ee50692d818b7ea027f4 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 18 May 2024 14:20:20 +0500
Subject: [PATCH] okular: add runtime depend phonon-backend-vlc, required for
 embedded file

---
 srcpkgs/okular/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/okular/template b/srcpkgs/okular/template
index be7696951077d9..4a030a873137ca 100644
--- a/srcpkgs/okular/template
+++ b/srcpkgs/okular/template
@@ -1,7 +1,7 @@
 # Template file for 'okular'
 pkgname=okular
 version=24.02.2
-revision=2
+revision=3
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF -DKF6_HOST_TOOLING=/usr/lib/cmake
  -DKDE_INSTALL_QTPLUGINDIR=lib/qt6/plugins"
@@ -16,7 +16,7 @@ makedepends="discount-devel djvulibre-devel ebook-tools-devel phonon-devel
  kf6-kdoctools-devel kf6-kiconthemes-devel kf6-kio-devel kf6-kirigami-devel
  kf6-kparts-devel kf6-kpty-devel kf6-kwallet-devel kf6-kwindowsystem-devel
  kf6-threadweaver-devel kf6-ktextwidgets-devel plasma-activities-devel"
-depends="hicolor-icon-theme"
+depends="hicolor-icon-theme phonon-backend-vlc"
 checkdepends="ebook-tools dbus"
 short_desc="KDE Document Viewer"
 maintainer="John <me@johnnynator.dev>"

Re: okular: add runtime depend phonon-backend-vlc, required for embedded …

[sgn]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/50405#issuecomment-2119076620

Comment:
So it's optional dependency, no? What is okular's behaviour when it's not available? Anyway, it's preferable to use `virtual?phonon-qt6-backend`

Re: okular: add runtime depend phonon-backend-vlc, required for embedded …

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/50405#issuecomment-2119079084

Comment:
> So it's optional dependency, no? What is okular's behaviour when it's not available? Anyway, it's preferable to use `virtual?phonon-qt6-backend`

For use case, when audio is embedded in okular, it does not play and give errors in terminal output "phonon backend plugin could not be loaded"

Re: [PR PATCH] [Updated] okular: add runtime depend phonon-backend-vlc, required for embedded …

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

There is an updated pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages okular
https://github.com/void-linux/void-packages/pull/50405

okular: add runtime depend phonon-backend-vlc, required for embedded …
…file

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-okular-50405.patch --]
[-- Type: text/x-diff, Size: 1251 bytes --]

From be508f103c0f491832e71e57e8d4161e3926fb92 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 18 May 2024 14:20:20 +0500
Subject: [PATCH] okular: add runtime depend phonon-backend-vlc, required for
 embedded file

---
 srcpkgs/okular/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/okular/template b/srcpkgs/okular/template
index be7696951077d9..db3c6cf0a8726b 100644
--- a/srcpkgs/okular/template
+++ b/srcpkgs/okular/template
@@ -1,7 +1,7 @@
 # Template file for 'okular'
 pkgname=okular
 version=24.02.2
-revision=2
+revision=3
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF -DKF6_HOST_TOOLING=/usr/lib/cmake
  -DKDE_INSTALL_QTPLUGINDIR=lib/qt6/plugins"
@@ -16,7 +16,7 @@ makedepends="discount-devel djvulibre-devel ebook-tools-devel phonon-devel
  kf6-kdoctools-devel kf6-kiconthemes-devel kf6-kio-devel kf6-kirigami-devel
  kf6-kparts-devel kf6-kpty-devel kf6-kwallet-devel kf6-kwindowsystem-devel
  kf6-threadweaver-devel kf6-ktextwidgets-devel plasma-activities-devel"
-depends="hicolor-icon-theme"
+depends="hicolor-icon-theme virtual?phonon-qt6-backend"
 checkdepends="ebook-tools dbus"
 short_desc="KDE Document Viewer"
 maintainer="John <me@johnnynator.dev>"

Re: okular: add runtime depend phonon-backend-vlc, required for embedded …

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/50405#issuecomment-2119079084

Comment:
> So it's optional dependency, no? What is okular's behaviour when it's not available? Anyway, it's preferable to use `virtual?phonon-qt6-backend`

For use case, when audio is embedded in pdf file, it does not play and give errors in terminal output "phonon backend plugin could not be loaded"

Re: okular: add runtime depend phonon-backend-vlc, required for embedded …

[sgn]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/50405#issuecomment-2121326621

Comment:
I think it's optional dependency. I tend to ignore those optional dependencies, though.

Re: [PR PATCH] [Closed]: okular: add runtime depend phonon-backend-vlc, required for embedded …

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

There's a closed pull request on the void-packages repository

okular: add runtime depend phonon-backend-vlc, required for embedded …
https://github.com/void-linux/void-packages/pull/50405

Description:
…file

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->