From: github-actions [bot] <"github-actions [bot]"@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: xbps-src: Don't unset IFS
Date: Fri, 24 May 2024 03:46:47 +0200 [thread overview]
Message-ID: <20240524014647.567EB21EA9@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48402@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
There's a closed pull request on the void-packages repository
xbps-src: Don't unset IFS
https://github.com/void-linux/void-packages/pull/48402
Description:
If IFS is unset, the shell behaves as if it has the default value of `<space><tab><newline>`. However, after unsetting IFS, constructs like
```
OFS="$IFS"; IFS=','
...
IFS="$OIFS"
```
(for example in [common/xbps-src/shutils/common.sh lines 246-253](https://github.com/void-linux/void-packages/blob/d2fbe47cac44061f1154db62f6f939178f204d15/common/xbps-src/shutils/common.sh#L246)) have the effect of setting IFS with an empty value, which breaks word-splitting. This results in an error like
```
./common/xbps-src/shutils/bulk.sh: line 125: sudo /bin/sh -c: No such file or directory
```
when running `./xbps-src update-sys` with `XBPS_SUCMD` set to the default value (`sudo /bin/sh -c`).
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **yes**
prev parent reply other threads:[~2024-05-24 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 14:29 [PR PATCH] " heindsight
2024-02-08 19:17 ` [PR PATCH] [Updated] " heindsight
2024-05-09 1:46 ` github-actions
2024-05-24 1:46 ` github-actions [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524014647.567EB21EA9@inbox.vuxu.org \
--to=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).