Github messages for voidlinux
 help / color / mirror / Atom feed
From: abenson <abenson@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: samba: update to 4.20.1.
Date: Sun, 26 May 2024 05:48:11 +0200	[thread overview]
Message-ID: <20240526034811.C532728FC2@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50464@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]

There's a merged pull request on the void-packages repository

samba: update to 4.20.1.
https://github.com/void-linux/void-packages/pull/50464

Description:
I don't have much experience with packaging and none with `Void Linux` packaging in particular, especially with a big project like Samba, so I'm not sure this is production ready yet.

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures:
  - x86_64
  - aarch64
  - aarch64-musl

#### Questions & notes
  - `samba-libs` has a ton of private libraries that I could not build as builtin this time. Should I add all of them to `common/shlibs`? **EDIT** I did add them all
  - I packaged `{uid,socket,nss,resolv}_wrapper` since they are needed by the `samba` testsuite but they can also be bundled in... Do we really need them? They are not used by anything else (yet).  On the other hand, `pam_wrapper`, that is also needed, is already in the repository.
  - On a related note, I tried to build the aforementioned testsuite but it ended up with a `cmocka` related build failure (`LargestIntegralType` was not defined). It did build successfully when `cmocka` was build as a bundled library though.
  - Should we break the `samba` package up? Fedora/Debian have a ton of subpackages for it and even Alpine has a few more than us.

  parent reply	other threads:[~2024-05-26  3:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 10:43 [PR PATCH] " otommod
2024-05-23  8:15 ` [PR PATCH] [Updated] " otommod
2024-05-23  8:17 ` otommod
2024-05-23 14:02 ` [PR PATCH] [Updated] " otommod
2024-05-23 14:04 ` otommod
2024-05-23 14:12 ` otommod
2024-05-26  2:47 ` abenson
2024-05-26  3:48 ` abenson [this message]
2024-05-26  3:49 ` abenson
2024-05-26  3:49 ` abenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240526034811.C532728FC2@inbox.vuxu.org \
    --to=abenson@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).