[PR PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[PR PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

There is a new pull request by ElementW against master on the void-packages repository

https://github.com/ElementW/void-packages sane-fix-pdf-ecsl-scanners
https://github.com/void-linux/void-packages/pull/42569

sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.

#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)


A patch file from https://github.com/void-linux/void-packages/pull/42569.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-fix-pdf-ecsl-scanners-42569.patch --]
[-- Type: text/x-diff, Size: 2075 bytes --]

From 127f925ebca02fa3dd07105e20abaf9caff23507 Mon Sep 17 00:00:00 2001
From: Celeste Wouters <perso@elementw.net>
Date: Fri, 3 Mar 2023 18:46:32 +0100
Subject: [PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid
 argument`

eSCL-speaking scanners that produce PDF-formatted output scan properly,
but completion is only met with `sane_start: Invalid argument` expressed
in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by
poppler-glib; this commit enables that as a default-on option, fixing
support for those scanners.
---
 srcpkgs/sane/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/sane/template b/srcpkgs/sane/template
index 2a40d0ad5813..74e6bdda7b44 100644
--- a/srcpkgs/sane/template
+++ b/srcpkgs/sane/template
@@ -2,15 +2,16 @@
 pkgname=sane
 _gitlab_release_hash=7d30fab4e115029d91027b6a58d64b43
 version=1.1.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-locking --enable-ipv6 --enable-pthread
  --with-usb --docdir=/usr/share/doc/sane ac_cv_func_mmap_fixed_mapped=yes
- $(vopt_with snmp)"
+ $(vopt_with snmp) $(vopt_with poppler poppler-glib)"
 hostmakedepends="pkg-config python3"
 makedepends="libjpeg-turbo-devel tiff-devel libgphoto2-devel v4l-utils-devel
  libusb-devel openssl-devel libxml2-devel $(vopt_if snmp net-snmp-devel)
- $(vopt_if avahi 'avahi-libs-devel libcurl-devel')"
+ $(vopt_if avahi 'avahi-libs-devel libcurl-devel')
+ $(vopt_if poppler 'cairo-devel poppler-glib-devel')"
 depends="$(vopt_if snmp net-snmp)"
 conf_files="/etc/sane.d/*.conf"
 short_desc="Scanner Access Now Easy"
@@ -26,8 +27,8 @@ noshlibprovides="avoid false detection of device drivers"
 system_accounts="_saned"
 _saned_groups="lp,scanner"
 
-build_options="avahi snmp"
-build_options_default="avahi"
+build_options="avahi snmp poppler"
+build_options_default="avahi poppler"
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
 	make_check=no # tests broken on 32bit.  https://gitlab.com/sane-project/backends/-/issues/157

Re: [PR PATCH] [Updated] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

There is an updated pull request by ElementW against master on the void-packages repository

https://github.com/ElementW/void-packages sane-fix-pdf-ecsl-scanners
https://github.com/void-linux/void-packages/pull/42569

sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.

#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)


A patch file from https://github.com/void-linux/void-packages/pull/42569.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-fix-pdf-ecsl-scanners-42569.patch --]
[-- Type: text/x-diff, Size: 2075 bytes --]

From 59cafa7d2f05437a464553f5d1bb20a01708f1b6 Mon Sep 17 00:00:00 2001
From: Celeste Wouters <perso@elementw.net>
Date: Fri, 3 Mar 2023 18:46:32 +0100
Subject: [PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid
 argument`

eSCL-speaking scanners that produce PDF-formatted output scan properly,
but completion is only met with `sane_start: Invalid argument` expressed
in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by
poppler-glib; this commit enables that as a default-on option, fixing
support for those scanners.
---
 srcpkgs/sane/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/sane/template b/srcpkgs/sane/template
index 2a40d0ad5813..74e6bdda7b44 100644
--- a/srcpkgs/sane/template
+++ b/srcpkgs/sane/template
@@ -2,15 +2,16 @@
 pkgname=sane
 _gitlab_release_hash=7d30fab4e115029d91027b6a58d64b43
 version=1.1.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-locking --enable-ipv6 --enable-pthread
  --with-usb --docdir=/usr/share/doc/sane ac_cv_func_mmap_fixed_mapped=yes
- $(vopt_with snmp)"
+ $(vopt_with snmp) $(vopt_with poppler poppler-glib)"
 hostmakedepends="pkg-config python3"
 makedepends="libjpeg-turbo-devel tiff-devel libgphoto2-devel v4l-utils-devel
  libusb-devel openssl-devel libxml2-devel $(vopt_if snmp net-snmp-devel)
- $(vopt_if avahi 'avahi-libs-devel libcurl-devel')"
+ $(vopt_if avahi 'avahi-libs-devel libcurl-devel')
+ $(vopt_if poppler 'cairo-devel poppler-glib-devel')"
 depends="$(vopt_if snmp net-snmp)"
 conf_files="/etc/sane.d/*.conf"
 short_desc="Scanner Access Now Easy"
@@ -26,8 +27,8 @@ noshlibprovides="avoid false detection of device drivers"
 system_accounts="_saned"
 _saned_groups="lp,scanner"
 
-build_options="avahi snmp"
-build_options_default="avahi"
+build_options="avahi snmp poppler"
+build_options_default="avahi poppler"
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
 	make_check=no # tests broken on 32bit.  https://gitlab.com/sane-project/backends/-/issues/157

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[riddicc]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by riddicc on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1506400478

Comment:
how can i get at least a test-version of the new package?
i think my scanner (Canon PIXMA TS3450) delivers PDF, too...

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[riddicc]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by riddicc on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1514502629

Comment:
yesterday's sane-1.1.1_2.x86_64 still does not scan with my TS3450... *cry*

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1641280699

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[riddicc]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

New comment by riddicc on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1641329934

Comment:
bump

Re: [PR PATCH] [Updated] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

There is an updated pull request by ElementW against master on the void-packages repository

https://github.com/ElementW/void-packages sane-fix-pdf-ecsl-scanners
https://github.com/void-linux/void-packages/pull/42569

sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.

#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)


A patch file from https://github.com/void-linux/void-packages/pull/42569.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-fix-pdf-ecsl-scanners-42569.patch --]
[-- Type: text/x-diff, Size: 2246 bytes --]

From b783c6cfd68a03367c193e21b4c010fe75d4755f Mon Sep 17 00:00:00 2001
From: Celeste Wouters <perso@elementw.net>
Date: Fri, 3 Mar 2023 18:46:32 +0100
Subject: [PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid
 argument`

eSCL-speaking scanners that produce PDF-formatted output scan properly,
but completion is only met with `sane_start: Invalid argument` expressed
in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by
poppler-glib; this commit enables that as a default-on option, fixing
support for those scanners.
---
 srcpkgs/sane/template | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/sane/template b/srcpkgs/sane/template
index 46ddd20f31701..c63f579650aef 100644
--- a/srcpkgs/sane/template
+++ b/srcpkgs/sane/template
@@ -2,15 +2,16 @@
 pkgname=sane
 _gitlab_release_hash=7d30fab4e115029d91027b6a58d64b43
 version=1.1.1
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="--disable-locking --enable-ipv6 --enable-pthread
  --with-usb --docdir=/usr/share/doc/sane ac_cv_func_mmap_fixed_mapped=yes
- $(vopt_with snmp)"
+ $(vopt_with snmp) $(vopt_with poppler poppler-glib)"
 hostmakedepends="pkg-config python3"
 makedepends="libjpeg-turbo-devel tiff-devel libgphoto2-devel v4l-utils-devel
  libusb-devel openssl-devel libxml2-devel $(vopt_if snmp net-snmp-devel)
- $(vopt_if avahi 'avahi-libs-devel libcurl-devel')"
+ $(vopt_if avahi 'avahi-libs-devel libcurl-devel')
+ $(vopt_if poppler 'cairo-devel poppler-glib-devel')"
 depends="$(vopt_if snmp net-snmp)"
 conf_files="/etc/sane.d/*.conf"
 short_desc="Scanner Access Now Easy"
@@ -26,12 +27,15 @@ noshlibprovides="avoid false detection of device drivers"
 system_accounts="_saned"
 _saned_groups="lp,scanner"
 
-build_options="avahi snmp"
-build_options_default="avahi"
+build_options="avahi snmp poppler"
+build_options_default="avahi poppler"
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
 	make_check=no # tests broken on 32bit.  https://gitlab.com/sane-project/backends/-/issues/157
 fi
+if [ "$build_option_poppler" ]; then
+	make_check=no # tests broken when poppler enabled due to bundled minigtest
+fi
 
 post_build() {
 	# generate udev file

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New comment by ElementW on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1642494633

Comment:
Gave up trying to understand precisely why the test fails. Not surprising it would really be broken upstream considering [its sorry state on 32 bit since 3 years now](https://gitlab.com/sane-project/backends/-/issues/157).
So I just disabled tests when `poppler` is enabled too.

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[riddicc]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by riddicc on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1657114128

Comment:
sane-1.2.1_1 still does not work...

Re: [PR PATCH] [Updated] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

There is an updated pull request by ElementW against master on the void-packages repository

https://github.com/ElementW/void-packages sane-fix-pdf-ecsl-scanners
https://github.com/void-linux/void-packages/pull/42569

sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.

#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)


A patch file from https://github.com/void-linux/void-packages/pull/42569.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-fix-pdf-ecsl-scanners-42569.patch --]
[-- Type: text/x-diff, Size: 2191 bytes --]

From d089d1f0355d51579b5d1d83a6bcdd700e32f131 Mon Sep 17 00:00:00 2001
From: Celeste Wouters <perso@elementw.net>
Date: Fri, 3 Mar 2023 18:46:32 +0100
Subject: [PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid
 argument`

eSCL-speaking scanners that produce PDF-formatted output scan properly,
but completion is only met with `sane_start: Invalid argument` expressed
in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by
poppler-glib; this commit enables that as a default-on option, fixing
support for those scanners.
---
 srcpkgs/sane/template | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/sane/template b/srcpkgs/sane/template
index 27b8c46ad6fdb..66a1a346f1570 100644
--- a/srcpkgs/sane/template
+++ b/srcpkgs/sane/template
@@ -6,11 +6,12 @@ revision=1
 build_style=gnu-configure
 configure_args="--disable-locking --enable-ipv6 --enable-pthread
  --with-usb --docdir=/usr/share/doc/sane ac_cv_func_mmap_fixed_mapped=yes
- $(vopt_with snmp)"
+ $(vopt_with snmp) $(vopt_with poppler poppler-glib)"
 hostmakedepends="pkg-config python3"
 makedepends="libjpeg-turbo-devel tiff-devel libgphoto2-devel v4l-utils-devel
  libusb-devel openssl-devel libxml2-devel libpng-devel
- $(vopt_if snmp net-snmp-devel) $(vopt_if avahi 'avahi-libs-devel libcurl-devel')"
+ $(vopt_if snmp net-snmp-devel) $(vopt_if avahi 'avahi-libs-devel libcurl-devel')
+ $(vopt_if poppler 'cairo-devel poppler-glib-devel')"
 depends="$(vopt_if snmp net-snmp)"
 conf_files="/etc/sane.d/*.conf"
 short_desc="Scanner Access Now Easy"
@@ -26,12 +27,15 @@ noshlibprovides="avoid false detection of device drivers"
 system_accounts="_saned"
 _saned_groups="lp,scanner"
 
-build_options="avahi snmp"
-build_options_default="avahi"
+build_options="avahi snmp poppler"
+build_options_default="avahi poppler"
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
 	make_check=no # tests broken on 32bit.  https://gitlab.com/sane-project/backends/-/issues/157
 fi
+if [ "$build_option_poppler" ]; then
+	make_check=no # tests broken when poppler enabled due to bundled minigtest
+fi
 
 post_build() {
 	# generate udev file

Re: [PR PATCH] [Updated] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

There is an updated pull request by ElementW against master on the void-packages repository

https://github.com/ElementW/void-packages sane-fix-pdf-ecsl-scanners
https://github.com/void-linux/void-packages/pull/42569

sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.

#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)


A patch file from https://github.com/void-linux/void-packages/pull/42569.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-fix-pdf-ecsl-scanners-42569.patch --]
[-- Type: text/x-diff, Size: 2191 bytes --]

From fb071e7b7ac900b4988e1aac6d556609db1e42ba Mon Sep 17 00:00:00 2001
From: Celeste Wouters <perso@elementw.net>
Date: Fri, 3 Mar 2023 18:46:32 +0100
Subject: [PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid
 argument`

eSCL-speaking scanners that produce PDF-formatted output scan properly,
but completion is only met with `sane_start: Invalid argument` expressed
in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by
poppler-glib; this commit enables that as a default-on option, fixing
support for those scanners.
---
 srcpkgs/sane/template | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/sane/template b/srcpkgs/sane/template
index 27b8c46ad6fdb..66a1a346f1570 100644
--- a/srcpkgs/sane/template
+++ b/srcpkgs/sane/template
@@ -6,11 +6,12 @@ revision=1
 build_style=gnu-configure
 configure_args="--disable-locking --enable-ipv6 --enable-pthread
  --with-usb --docdir=/usr/share/doc/sane ac_cv_func_mmap_fixed_mapped=yes
- $(vopt_with snmp)"
+ $(vopt_with snmp) $(vopt_with poppler poppler-glib)"
 hostmakedepends="pkg-config python3"
 makedepends="libjpeg-turbo-devel tiff-devel libgphoto2-devel v4l-utils-devel
  libusb-devel openssl-devel libxml2-devel libpng-devel
- $(vopt_if snmp net-snmp-devel) $(vopt_if avahi 'avahi-libs-devel libcurl-devel')"
+ $(vopt_if snmp net-snmp-devel) $(vopt_if avahi 'avahi-libs-devel libcurl-devel')
+ $(vopt_if poppler 'cairo-devel poppler-glib-devel')"
 depends="$(vopt_if snmp net-snmp)"
 conf_files="/etc/sane.d/*.conf"
 short_desc="Scanner Access Now Easy"
@@ -26,12 +27,15 @@ noshlibprovides="avoid false detection of device drivers"
 system_accounts="_saned"
 _saned_groups="lp,scanner"
 
-build_options="avahi snmp"
-build_options_default="avahi"
+build_options="avahi snmp poppler"
+build_options_default="avahi poppler"
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
 	make_check=no # tests broken on 32bit.  https://gitlab.com/sane-project/backends/-/issues/157
 fi
+if [ "$build_option_poppler" ]; then
+	make_check=no # tests broken when poppler enabled due to bundled minigtest
+fi
 
 post_build() {
 	# generate udev file

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1793291980

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[riddicc]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

New comment by riddicc on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1793356281

Comment:
bump?

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

New comment by ElementW on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1642494633

Comment:
Gave up trying to understand precisely why the test fails. Not surprising it would really be broken upstream considering [its sorry state on 32 bit for 4 years now](https://gitlab.com/sane-project/backends/-/issues/157).
So I just disabled tests when `poppler` is enabled too.

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1928624233

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by ElementW on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1929091507

Comment:
Again, this is still current, and SANE's test situation has not improved since 90 days.

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[riddicc]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by riddicc on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-1929154399

Comment:
why cant we just do it? i mean: make a new package?
when i compile&install it myself, it works fine...

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-2097224312

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[riddicc]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by riddicc on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-2097412307

Comment:
what is wrong here? lol

Re: [PR PATCH] [Updated] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

There is an updated pull request by ElementW against master on the void-packages repository

https://github.com/ElementW/void-packages sane-fix-pdf-ecsl-scanners
https://github.com/void-linux/void-packages/pull/42569

sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.

#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)


A patch file from https://github.com/void-linux/void-packages/pull/42569.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-fix-pdf-ecsl-scanners-42569.patch --]
[-- Type: text/x-diff, Size: 2292 bytes --]

From 75806dbbbfc14ccd9346ffb62f245b13f492edce Mon Sep 17 00:00:00 2001
From: Celeste Wouters <perso@elementw.net>
Date: Fri, 3 Mar 2023 18:46:32 +0100
Subject: [PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid
 argument`

eSCL-speaking scanners that produce PDF-formatted output scan properly,
but completion is only met with `sane_start: Invalid argument` expressed
in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by
poppler-glib; this commit enables that as a default-on option, fixing
support for those scanners.
---
 srcpkgs/sane/template | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/sane/template b/srcpkgs/sane/template
index 27b8c46ad6fdba..e1ef2d9455ea69 100644
--- a/srcpkgs/sane/template
+++ b/srcpkgs/sane/template
@@ -2,15 +2,16 @@
 pkgname=sane
 _gitlab_release_hash=110fc43336d0fb5e514f1fdc7360dd87
 version=1.2.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-locking --enable-ipv6 --enable-pthread
  --with-usb --docdir=/usr/share/doc/sane ac_cv_func_mmap_fixed_mapped=yes
- $(vopt_with snmp)"
+ $(vopt_with snmp) $(vopt_with poppler poppler-glib)"
 hostmakedepends="pkg-config python3"
 makedepends="libjpeg-turbo-devel tiff-devel libgphoto2-devel v4l-utils-devel
  libusb-devel openssl-devel libxml2-devel libpng-devel
- $(vopt_if snmp net-snmp-devel) $(vopt_if avahi 'avahi-libs-devel libcurl-devel')"
+ $(vopt_if snmp net-snmp-devel) $(vopt_if avahi 'avahi-libs-devel libcurl-devel')
+ $(vopt_if poppler 'cairo-devel poppler-glib-devel')"
 depends="$(vopt_if snmp net-snmp)"
 conf_files="/etc/sane.d/*.conf"
 short_desc="Scanner Access Now Easy"
@@ -26,12 +27,15 @@ noshlibprovides="avoid false detection of device drivers"
 system_accounts="_saned"
 _saned_groups="lp,scanner"
 
-build_options="avahi snmp"
-build_options_default="avahi"
+build_options="avahi snmp poppler"
+build_options_default="avahi poppler"
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
 	make_check=no # tests broken on 32bit.  https://gitlab.com/sane-project/backends/-/issues/157
 fi
+if [ "$build_option_poppler" ]; then
+	make_check=no # tests broken when poppler enabled due to bundled minigtest
+fi
 
 post_build() {
 	# generate udev file

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by ElementW on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-2118996581

Comment:
More than a year later, it seems this has not been looked at by any maintainer.
I'll ping @Piraty since they were the one to touch this file through a PR merge that updated `sane` to the current 1.2.1.

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-2132382246

Comment:
a gentle ping usually works best ;)

thanks for this patch!

* commit title is too verbose, something like `sane: enable pdf support' will work just fine.
* since poppler build option is not part of `common/options.description`, you should declare `desc_option_poppler=` like texstudio's template does

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-2132382246

Comment:
a gentle ping usually works best ;) (template mentions me as `maintainer=` , so pinging me would have been wise from the start)

thanks for this patch!

* commit title is too verbose, something like `sane: enable pdf support' will work just fine.
* since poppler build option is not part of `common/options.description`, you should declare `desc_option_poppler=` like texstudio's template does

Re: [PR PATCH] [Updated] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

There is an updated pull request by ElementW against master on the void-packages repository

https://github.com/ElementW/void-packages sane-fix-pdf-ecsl-scanners
https://github.com/void-linux/void-packages/pull/42569

sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.

#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)


A patch file from https://github.com/void-linux/void-packages/pull/42569.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-fix-pdf-ecsl-scanners-42569.patch --]
[-- Type: text/x-diff, Size: 2344 bytes --]

From dcf2915316697391e20333ac0de8db3e1c1ebbe6 Mon Sep 17 00:00:00 2001
From: Celeste Wouters <perso@elementw.net>
Date: Fri, 3 Mar 2023 18:46:32 +0100
Subject: [PATCH] sane: enable pdf support

eSCL-speaking scanners that produce PDF-formatted output scan properly,
but completion is only met with `sane_start: Invalid argument` expressed
in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by
poppler-glib; this commit enables that as a default-on option, fixing
support for those scanners.
---
 srcpkgs/sane/template | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/sane/template b/srcpkgs/sane/template
index 27b8c46ad6fdba..895b2a56a2f0b9 100644
--- a/srcpkgs/sane/template
+++ b/srcpkgs/sane/template
@@ -2,15 +2,16 @@
 pkgname=sane
 _gitlab_release_hash=110fc43336d0fb5e514f1fdc7360dd87
 version=1.2.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-locking --enable-ipv6 --enable-pthread
  --with-usb --docdir=/usr/share/doc/sane ac_cv_func_mmap_fixed_mapped=yes
- $(vopt_with snmp)"
+ $(vopt_with snmp) $(vopt_with poppler poppler-glib)"
 hostmakedepends="pkg-config python3"
 makedepends="libjpeg-turbo-devel tiff-devel libgphoto2-devel v4l-utils-devel
  libusb-devel openssl-devel libxml2-devel libpng-devel
- $(vopt_if snmp net-snmp-devel) $(vopt_if avahi 'avahi-libs-devel libcurl-devel')"
+ $(vopt_if snmp net-snmp-devel) $(vopt_if avahi 'avahi-libs-devel libcurl-devel')
+ $(vopt_if poppler 'cairo-devel poppler-glib-devel')"
 depends="$(vopt_if snmp net-snmp)"
 conf_files="/etc/sane.d/*.conf"
 short_desc="Scanner Access Now Easy"
@@ -26,12 +27,16 @@ noshlibprovides="avoid false detection of device drivers"
 system_accounts="_saned"
 _saned_groups="lp,scanner"
 
-build_options="avahi snmp"
-build_options_default="avahi"
+build_options="avahi snmp poppler"
+build_options_default="avahi poppler"
+desc_option_poppler="build with poppler (support for PDF-producing scanners, e.g. Epson eSCL)"
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
 	make_check=no # tests broken on 32bit.  https://gitlab.com/sane-project/backends/-/issues/157
 fi
+if [ "$build_option_poppler" ]; then
+	make_check=no # tests broken when poppler enabled due to bundled minigtest
+fi
 
 post_build() {
 	# generate udev file

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[ElementW]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

New comment by ElementW on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-2132397071

Comment:
@Piraty Oooh thanks a lot for these suggestions; I had noticed that options have their common description file back then but wasn't sure if I should touch it, and I found no documentation on whether one could create a per-package option, thanks again for the tip.

I've also shortened the commit name, as you suggested.

Re: [PR PATCH] [Merged]: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

There's a merged pull request on the void-packages repository

sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
https://github.com/void-linux/void-packages/pull/42569

Description:
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.

This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.

#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-2144530715

Comment:
https://github.com/void-linux/void-packages/issues/50541 :(

Re: sane: fix PDF-producing eSCL scanners failing with `Invalid argument`

[riddicc]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by riddicc on void-packages repository

https://github.com/void-linux/void-packages/pull/42569#issuecomment-2144703296

Comment:
just upgraded... works fine now...