From: Piraty <Piraty@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] librsvg: update to 2.58.0.
Date: Mon, 27 May 2024 15:00:32 +0200 [thread overview]
Message-ID: <20240527130032.6FED126B96@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49755@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/49755#discussion_r1616024022
Comment:
i don't see validity of "strong pushback" claim. The only thing in this regard i can remember was https://github.com/void-linux/void-packages/issues/27735 and yes, it's still unsettled
* `homepage` is usually free of variables for parsing reasons (i think)
* `distfiles` don't make sense without variables (especially `$version`)
* `changelog` is preferred to point to the active branch if there is one. if there is no such thing, the next best thing is to point to the versioned hyperlink.
if not following an idiom (regardless of its justification) leads to less error-prone maintenance overhead, do it.
next prev parent reply other threads:[~2024-05-27 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 19:02 [PR PATCH] " icp1994
2024-04-08 8:01 ` [PR REVIEW] " tranzystorekk
2024-04-08 8:32 ` icp1994
2024-04-08 8:37 ` tranzystorekk
2024-05-26 21:05 ` Piraty
2024-05-27 7:42 ` icp1994
2024-05-27 13:00 ` Piraty [this message]
2024-05-27 18:09 ` [PR PATCH] [Updated] " icp1994
2024-05-27 18:09 ` [PR REVIEW] librsvg: update to 2.58.1 icp1994
2024-05-28 17:25 ` [PR PATCH] [Merged]: " cinerea0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240527130032.6FED126B96@inbox.vuxu.org \
--to=piraty@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).