Github messages for voidlinux
 help / color / mirror / Atom feed
From: MIvanchev <MIvanchev@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] [WIP] electron19: fixing failed build
Date: Tue, 28 May 2024 16:59:12 +0200	[thread overview]
Message-ID: <20240528145912.BF2C228925@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50551@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

There is an updated pull request by MIvanchev against master on the void-packages repository

https://github.com/MIvanchev/void-packages electron19-fix
https://github.com/void-linux/void-packages/pull/50551

[WIP] electron19: fixing failed build
#### Testing the changes
- I tested the changes in this PR: **NO**



A patch file from https://github.com/void-linux/void-packages/pull/50551.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-electron19-fix-50551.patch --]
[-- Type: text/x-diff, Size: 1375 bytes --]

From eb9dda722732a7cc0f0649fcf2073ebfb69f4272 Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Tue, 28 May 2024 14:12:32 +0200
Subject: [PATCH] electron19: fixing failed build

---
 srcpkgs/electron19/template | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/electron19/template b/srcpkgs/electron19/template
index b1fdb63cb67d46..427f58dd0d2424 100644
--- a/srcpkgs/electron19/template
+++ b/srcpkgs/electron19/template
@@ -1,7 +1,7 @@
 # Template file for 'electron19'
 pkgname=electron19
 version=19.0.8
-revision=4
+revision=5
 _nodever=16.14.2
 _chromiumver=102.0.5005.125
 archs="x86_64* aarch64* ppc64le*"
@@ -103,6 +103,7 @@ _get_chromium_arch() {
 }
 
 post_extract() {
+	xuname
 	mv chromium-${_chromiumver} src
 	mkdir -p src/third_party/
 	mv node-$_nodever src/third_party/electron_node
@@ -205,6 +206,8 @@ pre_configure() {
 
 	# Add missing include
 	vsed -e "s|#include <algorithm>|&\n#include <utility>|" -i base/third_party/symbolize/symbolize.h
+	vsed -e "s|#include <ostream>|&\n#include <cstdint>|" -i third_party/abseil-cpp/absl/strings/internal/str_format/extension.h
+	vsed -e "s|#include <vector>|&\n#include <cstdint>|" -i third_party/angle/include/GLSLANG/ShaderVars.h
 
 	mkdir -p third_party/node/linux/node-linux-x64/bin
 	ln -sf /usr/bin/node third_party/node/linux/node-linux-x64/bin/

  parent reply	other threads:[~2024-05-28 14:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 12:13 [PR PATCH] " MIvanchev
2024-05-28 12:32 ` [PR PATCH] [Updated] " MIvanchev
2024-05-28 12:39 ` MIvanchev
2024-05-28 13:41 ` MIvanchev
2024-05-28 13:53 ` MIvanchev
2024-05-28 14:23 ` MIvanchev
2024-05-28 14:47 ` MIvanchev
2024-05-28 14:59 ` MIvanchev [this message]
2024-05-28 15:28 ` MIvanchev
2024-05-28 15:41 ` MIvanchev
2024-05-28 17:41 ` MIvanchev
2024-05-28 18:02 ` MIvanchev
2024-05-28 18:03 ` MIvanchev
2024-05-28 18:07 ` MIvanchev
2024-05-28 20:33 ` MIvanchev
2024-05-29  7:04 ` MIvanchev
2024-05-29  7:19 ` MIvanchev
2024-05-29  8:03 ` MIvanchev
2024-05-29  8:16 ` MIvanchev
2024-05-29  9:02 ` MIvanchev
2024-05-29  9:45 ` MIvanchev
2024-05-29 10:43 ` MIvanchev
2024-05-29 11:35 ` MIvanchev
2024-05-29 11:54 ` MIvanchev
2024-05-29 12:06 ` MIvanchev
2024-05-29 12:20 ` MIvanchev
2024-05-29 14:42 ` MIvanchev
2024-05-29 19:36 ` [PR REVIEW] " classabbyamp
2024-05-30  7:27 ` [PR PATCH] [Updated] " MIvanchev
2024-05-30  7:59 ` MIvanchev
2024-05-30  8:55 ` [PR REVIEW] " MIvanchev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528145912.BF2C228925@inbox.vuxu.org \
    --to=mivanchev@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).