Github messages for voidlinux
 help / color / mirror / Atom feed
From: meator <meator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [WIP] fmt: update to 10.2.1, spdlog: update to 1.14.1.
Date: Tue, 28 May 2024 21:18:54 +0200	[thread overview]
Message-ID: <20240528191854.82967294F4@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50183@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 5322 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/50183#issuecomment-2135947149

Comment:
> after several hours, i can't figure out how to fix cross compilation for `imhex`
> 
> please help

Worry not, I come to the rescue!

Here's a patch:

```patch
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -29,6 +29,12 @@
 set(CMAKE_MODULE_PATH "${IMHEX_BASE_FOLDER}/cmake/modules")
 include("${IMHEX_BASE_FOLDER}/cmake/build_helpers.cmake")
 
+# Void Linux flags for cross compiling libromfs
+set(NATIVE_CMAKE_C_COMPILER "$ENV{CC_host}")
+set(NATIVE_CMAKE_CXX_COMPILER "$ENV{CXX_host}")
+set(NATIVE_CMAKE_C_FLAGS "$ENV{CFLAGS_host}")
+set(NATIVE_CMAKE_CXX_FLAGS "$ENV{CXXFLAGS_host}")
+
 # Setup project
 loadVersion(IMHEX_VERSION)
 setVariableInParent(IMHEX_VERSION ${IMHEX_VERSION})
```

This is what's causing problems: https://github.com/WerWolv/libromfs/blob/master/generator/CMakeLists.txt#L5-L12 (`libromfs` isn't a part of `imhex`, it gets downloaded during the configure step[^1])

`ld` prints warnings about skipping aarch libraries when looking for libs. I believe that these warnings are harmless.

<details><summary>Here are the ld warnings.</summary>
<p>

```
...
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libstdc++.so when searching for -lstdc++
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libstdc++.a when searching for -lstdc++
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libm.so when searching for -lm
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libm.a when searching for -lm
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libc.so when searching for -lc
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libc.a when searching for -lc
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
[141/369] Linking CXX executable plugins/builtin/libromfs/generator/generator-builtin
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libstdc++.so when searching for -lstdc++
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libstdc++.a when searching for -lstdc++
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libm.so when searching for -lm
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libm.a when searching for -lm
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libc.so when searching for -lc
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libc.a when searching for -lc
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
[142/369] Linking CXX executable main/gui/main/gui/libromfs/generator/generator-imhex
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libstdc++.so when searching for -lstdc++
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libstdc++.a when searching for -lstdc++
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libm.so when searching for -lm
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libm.a when searching for -lm
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libc.so when searching for -lc
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libc.a when searching for -lc
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
/usr/bin/ld: skipping incompatible /usr/aarch64-linux-gnu/usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
...
```

</p>
</details>

These flags could be theoretically set through `$configure_args`, but the variable expansion gets pretty funky with `$CFLAGS_host` and `$CXXFLAGS_host`. `libromfs`'s build system disregards the relevant `NATIVE_CMAKE_` variables when set through the environment, so the only two solutions I see is passing `-DNATIVE_CMAKE_` to cmake (impossible to do [because of parameter expansion](https://github.com/void-linux/void-packages/blob/master/common/build-style/cmake.sh#L78)) or modifying the build system like my patch does.

[^1]: This is bad for obvious reasons, I believe that it pulls https://github.com/WerWolv/libromfs directly from master. This should probably be fixed.

  parent reply	other threads:[~2024-05-28 19:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 22:39 [PR PATCH] " Calandracas606
2024-05-04  4:24 ` [PR PATCH] [Updated] " Calandracas606
2024-05-05  2:42 ` sgn
2024-05-05  3:00 ` sgn
2024-05-05  4:02 ` [PR PATCH] [Updated] " Calandracas606
2024-05-05  4:03 ` Calandracas606
2024-05-05 16:40 ` [PR PATCH] [Updated] " Calandracas606
2024-05-05 17:09 ` Calandracas606
2024-05-05 17:11 ` Calandracas606
2024-05-05 23:08 ` Calandracas606
2024-05-14 11:26 ` [PR PATCH] [Updated] " Calandracas606
2024-05-28 14:58 ` Calandracas606
2024-05-28 15:00 ` Calandracas606
2024-05-28 19:18 ` meator [this message]
2024-05-28 19:37 ` [PR PATCH] [Updated] " Calandracas606
2024-05-28 19:38 ` Calandracas606
2024-05-28 19:48 ` [PR PATCH] [Updated] " Calandracas606
2024-05-28 22:03 ` Calandracas606
2024-05-28 22:36 ` Calandracas606
2024-05-28 22:39 ` Calandracas606
2024-06-13 23:34 ` [PR PATCH] [Updated] " Calandracas606

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528191854.82967294F4@inbox.vuxu.org \
    --to=meator@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).