[PR PATCH] autofirma: fix passing arguments to app

[PR PATCH] autofirma: fix passing arguments to app

[Xx-Seth-xX]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

There is a new pull request by Xx-Seth-xX against master on the void-packages repository

https://github.com/Xx-Seth-xX/void-packages autofirma-fix
https://github.com/void-linux/void-packages/pull/50572

autofirma: fix passing arguments to app
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50572.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-fix-50572.patch --]
[-- Type: text/x-diff, Size: 661 bytes --]

From 1f76a495fec1ad24d39969f9aaf19071747b0b7a Mon Sep 17 00:00:00 2001
From: Seth <53190848+Xx-Seth-xX@users.noreply.github.com>
Date: Tue, 28 May 2024 21:34:51 +0200
Subject: [PATCH] autofirma: fix passing arguments to app

---
 srcpkgs/autofirma/files/autofirma | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/autofirma/files/autofirma b/srcpkgs/autofirma/files/autofirma
index 173e8ac46fd6c0..0acf369f116c35 100644
--- a/srcpkgs/autofirma/files/autofirma
+++ b/srcpkgs/autofirma/files/autofirma
@@ -1,2 +1,2 @@
 #! /bin/sh
-java -jar /usr/share/java/autofirma/AutoFirma.jar
+java -jar /usr/share/java/autofirma/AutoFirma.jar "$@"

Re: autofirma: fix passing arguments to app

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50572#issuecomment-2136011613

Comment:
the revision needs to be incremented

Re: [PR PATCH] [Updated] autofirma: fix passing arguments to app

[Xx-Seth-xX]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by Xx-Seth-xX against master on the void-packages repository

https://github.com/Xx-Seth-xX/void-packages autofirma-fix
https://github.com/void-linux/void-packages/pull/50572

autofirma: fix passing arguments to app
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50572.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-fix-50572.patch --]
[-- Type: text/x-diff, Size: 1095 bytes --]

From 658a8a4798d74d7710de55f12336757df8415d68 Mon Sep 17 00:00:00 2001
From: Seth <53190848+Xx-Seth-xX@users.noreply.github.com>
Date: Tue, 28 May 2024 21:34:51 +0200
Subject: [PATCH] autofirma: fix passing arguments to app

---
 srcpkgs/autofirma/files/autofirma | 2 +-
 srcpkgs/autofirma/template        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/autofirma/files/autofirma b/srcpkgs/autofirma/files/autofirma
index 173e8ac46fd6c0..0acf369f116c35 100644
--- a/srcpkgs/autofirma/files/autofirma
+++ b/srcpkgs/autofirma/files/autofirma
@@ -1,2 +1,2 @@
 #! /bin/sh
-java -jar /usr/share/java/autofirma/AutoFirma.jar
+java -jar /usr/share/java/autofirma/AutoFirma.jar "$@"
diff --git a/srcpkgs/autofirma/template b/srcpkgs/autofirma/template
index 2d87e27fb67811..3a2c21d5f953d2 100644
--- a/srcpkgs/autofirma/template
+++ b/srcpkgs/autofirma/template
@@ -1,7 +1,7 @@
 # Template file for 'autofirma'
 pkgname=autofirma
 version=1.8.2
-revision=1
+revision=2
 _jmulticard_version=1.8
 hostmakedepends="apache-maven openjdk11"
 depends="virtual?java-environment"

Re: autofirma: fix passing arguments to app

[Xx-Seth-xX]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by Xx-Seth-xX on void-packages repository

https://github.com/void-linux/void-packages/pull/50572#issuecomment-2136131977

Comment:
> the revision needs to be incremented

I don't know if this is the right place to ask, but linting is failing because there is a new version of autofirma (1.8.3), should I bump and test that in this PR or how can I make this pass CI? 

(It's my first PR in a public project)

Re: autofirma: fix passing arguments to app

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50572#issuecomment-2136145665

Comment:
the error is `Error: 658a8a479: authored by noreply email`

you'll need to set a different email in your git config and `git commit --amend --reset-author`

Re: [PR PATCH] [Updated] autofirma: fix passing arguments to app

[Xx-Seth-xX]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by Xx-Seth-xX against master on the void-packages repository

https://github.com/Xx-Seth-xX/void-packages autofirma-fix
https://github.com/void-linux/void-packages/pull/50572

autofirma: fix passing arguments to app
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50572.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-fix-50572.patch --]
[-- Type: text/x-diff, Size: 1071 bytes --]

From b7300d53caad8122c81903fdbcb0d51bfa218ce6 Mon Sep 17 00:00:00 2001
From: Seth <dalu121212@gmail.com>
Date: Tue, 28 May 2024 23:36:28 +0200
Subject: [PATCH] autofirma: fix passing arguments to app

---
 srcpkgs/autofirma/files/autofirma | 2 +-
 srcpkgs/autofirma/template        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/autofirma/files/autofirma b/srcpkgs/autofirma/files/autofirma
index 173e8ac46fd6c0..0acf369f116c35 100644
--- a/srcpkgs/autofirma/files/autofirma
+++ b/srcpkgs/autofirma/files/autofirma
@@ -1,2 +1,2 @@
 #! /bin/sh
-java -jar /usr/share/java/autofirma/AutoFirma.jar
+java -jar /usr/share/java/autofirma/AutoFirma.jar "$@"
diff --git a/srcpkgs/autofirma/template b/srcpkgs/autofirma/template
index 2d87e27fb67811..3a2c21d5f953d2 100644
--- a/srcpkgs/autofirma/template
+++ b/srcpkgs/autofirma/template
@@ -1,7 +1,7 @@
 # Template file for 'autofirma'
 pkgname=autofirma
 version=1.8.2
-revision=1
+revision=2
 _jmulticard_version=1.8
 hostmakedepends="apache-maven openjdk11"
 depends="virtual?java-environment"

Re: autofirma: fix passing arguments to app

[Xx-Seth-xX]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by Xx-Seth-xX on void-packages repository

https://github.com/void-linux/void-packages/pull/50572#issuecomment-2136151254

Comment:
> the error is `Error: 658a8a479: authored by noreply email`
> 
> you'll need to set a different email in your git config and `git commit --amend --reset-author`

Thank you, I missread, it should be fixed now

Re: [PR PATCH] [Merged]: autofirma: fix passing arguments to app

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

There's a merged pull request on the void-packages repository

autofirma: fix passing arguments to app
https://github.com/void-linux/void-packages/pull/50572

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->