Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Manual.md: minor grammar fix
@ 2024-05-28 21:55 r-ricci
  2024-05-28 22:03 ` [PR REVIEW] " classabbyamp
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: r-ricci @ 2024-05-28 21:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

There is a new pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages manual
https://github.com/void-linux/void-packages/pull/50576

Manual.md: minor grammar fix
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50576.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-50576.patch --]
[-- Type: text/x-diff, Size: 791 bytes --]

From 8f5633ff0842fc8263a176e4d1d4a3ab701892fc Mon Sep 17 00:00:00 2001
From: Roberto Ricci <io@r-ricci.it>
Date: Tue, 28 May 2024 23:44:43 +0200
Subject: [PATCH] Manual.md: minor grammar fix

---
 Manual.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Manual.md b/Manual.md
index 53a2cc8a1510fc..a8b5dd2c3733e9 100644
--- a/Manual.md
+++ b/Manual.md
@@ -761,7 +761,7 @@ certain architectures or there is a compelling reason why the software should no
 available on some supported architectures.
 Prepending pattern with tilde means disallowing build on indicated archs.
 First matching pattern is taken to allow/deny build. When no pattern matches,
-package is build if last pattern includes tilde.
+package is built if last pattern includes tilde.
 Examples:
 
 	```

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] Manual.md: minor grammar fix
  2024-05-28 21:55 [PR PATCH] Manual.md: minor grammar fix r-ricci
@ 2024-05-28 22:03 ` classabbyamp
  2024-05-29 20:13 ` [PR PATCH] [Updated] " r-ricci
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2024-05-28 22:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50576#discussion_r1617938215

Comment:
```diff
- Prepending pattern with tilde means disallowing build on indicated archs.
- First matching pattern is taken to allow/deny build. When no pattern matches,
- package is built if last pattern includes tilde.
+ Prepending a pattern with a tilde means disallowing build on the indicated archs.
+ The first matching pattern is taken to allow/deny build. When no pattern matches,
+ the package is built if the last pattern includes tilde.
```

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] Manual.md: minor grammar fix
  2024-05-28 21:55 [PR PATCH] Manual.md: minor grammar fix r-ricci
  2024-05-28 22:03 ` [PR REVIEW] " classabbyamp
@ 2024-05-29 20:13 ` r-ricci
  2024-05-29 20:17 ` [PR REVIEW] " r-ricci
  2024-05-30 18:29 ` [PR PATCH] [Closed]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: r-ricci @ 2024-05-29 20:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

There is an updated pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages manual
https://github.com/void-linux/void-packages/pull/50576

Manual.md: minor grammar fix
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50576.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-50576.patch --]
[-- Type: text/x-diff, Size: 1141 bytes --]

From e5dec31a5faff02c533c77ea24091a433114ed55 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <io@r-ricci.it>
Date: Wed, 29 May 2024 22:10:22 +0200
Subject: [PATCH] Manual.md: minor grammar fixes

---
 Manual.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Manual.md b/Manual.md
index 53a2cc8a1510fc..e812d1d37fd880 100644
--- a/Manual.md
+++ b/Manual.md
@@ -759,9 +759,9 @@ built for, available architectures can be found under `common/cross-profiles`.
 In general, `archs` should only be set if the upstream software explicitly targets
 certain architectures or there is a compelling reason why the software should not be
 available on some supported architectures.
-Prepending pattern with tilde means disallowing build on indicated archs.
-First matching pattern is taken to allow/deny build. When no pattern matches,
-package is build if last pattern includes tilde.
+Prepending a pattern with a tilde means disallowing build on the indicated archs.
+The first matching pattern is taken to allow/deny build. When no pattern matches,
+the package is built if the last pattern includes tilde.
 Examples:
 
 	```

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] Manual.md: minor grammar fix
  2024-05-28 21:55 [PR PATCH] Manual.md: minor grammar fix r-ricci
  2024-05-28 22:03 ` [PR REVIEW] " classabbyamp
  2024-05-29 20:13 ` [PR PATCH] [Updated] " r-ricci
@ 2024-05-29 20:17 ` r-ricci
  2024-05-30 18:29 ` [PR PATCH] [Closed]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: r-ricci @ 2024-05-29 20:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/50576#discussion_r1619426478

Comment:
Yeah, I could have fixed other things too.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: Manual.md: minor grammar fix
  2024-05-28 21:55 [PR PATCH] Manual.md: minor grammar fix r-ricci
                   ` (2 preceding siblings ...)
  2024-05-29 20:17 ` [PR REVIEW] " r-ricci
@ 2024-05-30 18:29 ` classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2024-05-30 18:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

There's a closed pull request on the void-packages repository

Manual.md: minor grammar fix
https://github.com/void-linux/void-packages/pull/50576

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-05-30 18:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-28 21:55 [PR PATCH] Manual.md: minor grammar fix r-ricci
2024-05-28 22:03 ` [PR REVIEW] " classabbyamp
2024-05-29 20:13 ` [PR PATCH] [Updated] " r-ricci
2024-05-29 20:17 ` [PR REVIEW] " r-ricci
2024-05-30 18:29 ` [PR PATCH] [Closed]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).