Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] optipng: add changelog
@ 2024-05-29  3:00 RunningDroid
  2024-05-29 10:28 ` classabbyamp
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: RunningDroid @ 2024-05-29  3:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

There is a new pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages optipng_changelog
https://github.com/void-linux/void-packages/pull/50579

optipng: add changelog
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

`xchangelog` handles it fine, the file itself starts with non-printing characters* for some reason though:
![2024-05-28T22:53:50,555115731-04:00](https://github.com/void-linux/void-packages/assets/486393/19e58d7f-6976-4f15-b908-40f2bb494467)

*: byte sequence is `EF BB BF`
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50579.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-optipng_changelog-50579.patch --]
[-- Type: text/x-diff, Size: 793 bytes --]

From 435f0c264d03b9bff97ccbf7412a0b4b2cf3a394 Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Tue, 28 May 2024 22:41:37 -0400
Subject: [PATCH] optipng: add changelog

---
 srcpkgs/optipng/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/optipng/template b/srcpkgs/optipng/template
index e82b59cc0de4fb..0c6966e1be898a 100644
--- a/srcpkgs/optipng/template
+++ b/srcpkgs/optipng/template
@@ -8,6 +8,7 @@ short_desc="Advanced PNG Optimizer"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Zlib"
 homepage="https://optipng.sourceforge.net/"
+changelog="https://optipng.sourceforge.net/history.txt"
 distfiles="${SOURCEFORGE_SITE}/optipng/optipng-${version}.tar.gz"
 checksum=25a3bd68481f21502ccaa0f4c13f84dcf6b20338e4c4e8c51f2cefbd8513398c
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: optipng: add changelog
  2024-05-29  3:00 [PR PATCH] optipng: add changelog RunningDroid
@ 2024-05-29 10:28 ` classabbyamp
  2024-05-29 10:29 ` [PR PATCH] [Merged]: " classabbyamp
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-05-29 10:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50579#issuecomment-2137080055

Comment:
that's a UTF8 byte-order mark https://en.wikipedia.org/wiki/Byte_order_mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: optipng: add changelog
  2024-05-29  3:00 [PR PATCH] optipng: add changelog RunningDroid
  2024-05-29 10:28 ` classabbyamp
@ 2024-05-29 10:29 ` classabbyamp
  2024-05-29 10:30 ` classabbyamp
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-05-29 10:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

There's a merged pull request on the void-packages repository

optipng: add changelog
https://github.com/void-linux/void-packages/pull/50579

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

`xchangelog` handles it fine, the file itself starts with non-printing characters* for some reason though:
![2024-05-28T22:53:50,555115731-04:00](https://github.com/void-linux/void-packages/assets/486393/19e58d7f-6976-4f15-b908-40f2bb494467)

*: byte sequence is `EF BB BF`
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: optipng: add changelog
  2024-05-29  3:00 [PR PATCH] optipng: add changelog RunningDroid
  2024-05-29 10:28 ` classabbyamp
  2024-05-29 10:29 ` [PR PATCH] [Merged]: " classabbyamp
@ 2024-05-29 10:30 ` classabbyamp
  2024-05-29 10:30 ` classabbyamp
  2024-05-29 22:34 ` RunningDroid
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-05-29 10:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50579#issuecomment-2137080055

Comment:
that's a UTF8 byte-order mark https://en.wikipedia.org/wiki/Byte_order_mark

> UTF-8 always has the same byte order,[[6]](https://en.wikipedia.org/wiki/Byte_order_mark#cite_note-utf-8-bom-6) so its only use in UTF-8 is to signal at the start that the text stream is encoded in UTF-8, or that it was converted to UTF-8 from a stream that contained an optional BOM.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: optipng: add changelog
  2024-05-29  3:00 [PR PATCH] optipng: add changelog RunningDroid
                   ` (2 preceding siblings ...)
  2024-05-29 10:30 ` classabbyamp
@ 2024-05-29 10:30 ` classabbyamp
  2024-05-29 22:34 ` RunningDroid
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-05-29 10:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50579#issuecomment-2137080055

Comment:
that's a UTF8 byte-order mark https://en.wikipedia.org/wiki/Byte_order_mark

> UTF-8 always has the same byte order, so its only use in UTF-8 is to signal at the start that the text stream is encoded in UTF-8, or that it was converted to UTF-8 from a stream that contained an optional BOM.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: optipng: add changelog
  2024-05-29  3:00 [PR PATCH] optipng: add changelog RunningDroid
                   ` (3 preceding siblings ...)
  2024-05-29 10:30 ` classabbyamp
@ 2024-05-29 22:34 ` RunningDroid
  4 siblings, 0 replies; 6+ messages in thread
From: RunningDroid @ 2024-05-29 22:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/50579#issuecomment-2138367211

Comment:
Thanks, I had checked that page but stopped reading after it started talking about `FE FF`.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-05-29 22:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-29  3:00 [PR PATCH] optipng: add changelog RunningDroid
2024-05-29 10:28 ` classabbyamp
2024-05-29 10:29 ` [PR PATCH] [Merged]: " classabbyamp
2024-05-29 10:30 ` classabbyamp
2024-05-29 10:30 ` classabbyamp
2024-05-29 22:34 ` RunningDroid

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).