[PR PATCH] autofirma: Add .desktop file to pkg

[PR PATCH] autofirma: Add .desktop file to pkg

[suturar]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

There is a new pull request by suturar against master on the void-packages repository

https://github.com/suturar/void-packages autofirma-add_desktop
https://github.com/void-linux/void-packages/pull/50586

autofirma: Add .desktop file to pkg
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/50586.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-add_desktop-50586.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From 2d56258427ed260c8dff61317e8ced3ef86c6c9e Mon Sep 17 00:00:00 2001
From: Seth <sutura-git@qkco.es>
Date: Wed, 29 May 2024 15:41:31 +0200
Subject: [PATCH] autofirma: Add .desktop file to pkg

---
 srcpkgs/autofirma/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/autofirma/template b/srcpkgs/autofirma/template
index 3a2c21d5f953d2..be2e7d18d82007 100644
--- a/srcpkgs/autofirma/template
+++ b/srcpkgs/autofirma/template
@@ -1,7 +1,7 @@
 # Template file for 'autofirma'
 pkgname=autofirma
 version=1.8.2
-revision=2
+revision=3
 _jmulticard_version=1.8
 hostmakedepends="apache-maven openjdk11"
 depends="virtual?java-environment"
@@ -35,5 +35,6 @@ do_check() {
 do_install() {
 	vmkdir usr/share/java/${pkgname}
 	vinstall clienteafirma-${version}/afirma-simple/target/AutoFirma.jar 644 usr/share/java/autofirma
+	vinstall clienteafirma-${version}/afirma-simple-installer/linux/instalador_deb/src/usr/share/applications/afirma.desktop 644 /usr/share/applications
 	vbin "${FILESDIR}/autofirma"
 }

Re: autofirma: Add .desktop file to pkg

[suturar]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by suturar on void-packages repository

https://github.com/void-linux/void-packages/pull/50586#issuecomment-2137540215

Comment:
Modification of closed PR #50584 now using upstream .desktop file instead of vendoring our own

Re: autofirma: Add .desktop file to pkg

[suturar]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by suturar on void-packages repository

https://github.com/void-linux/void-packages/pull/50586#issuecomment-2137954933

Comment:
Also, this is needed for a lot of usages as an online verification tool as the browsert uses xdg to try and guess which app to use to open the url needed.

Re: [PR PATCH] [Merged]: autofirma: Add .desktop file to pkg

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

There's a merged pull request on the void-packages repository

autofirma: Add .desktop file to pkg
https://github.com/void-linux/void-packages/pull/50586

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

Re: autofirma: Add .desktop file to pkg

[suturar]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by suturar on void-packages repository

https://github.com/void-linux/void-packages/pull/50584#issuecomment-2137809203

Comment:
Fixed in #50586

Re: autofirma: Add .desktop file to pkg

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/50584#issuecomment-2137461864

Comment:
We're trying to reduce our vendoring of desktop files. Please petition upstream to include this.