[PR PATCH] winusb: Use pkexec instead of gksudo for privilege escalation

[PR PATCH] winusb: Use pkexec instead of gksudo for privilege escalation

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

There is a new pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-17
https://github.com/void-linux/void-packages/pull/50648

winusb: Use pkexec instead of gksudo for privilege escalation
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-17-50648.patch --]
[-- Type: text/x-diff, Size: 1818 bytes --]

From 0610cdb2e66e184cd7e73bd01de825315fd8ee93 Mon Sep 17 00:00:00 2001
From: bugcrazy <marcoaureliopc@gmail.com>
Date: Sun, 2 Jun 2024 01:10:33 -0300
Subject: [PATCH] winusb: Use pkexec instead of gksudo for privilege escalation

---
 srcpkgs/winusb/patches/support-PolicyKit.patch | 11 +++++++++++
 srcpkgs/winusb/template                        |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/winusb/patches/support-PolicyKit.patch

diff --git a/srcpkgs/winusb/patches/support-PolicyKit.patch b/srcpkgs/winusb/patches/support-PolicyKit.patch
new file mode 100644
index 00000000000000..44910318dd4bba
--- /dev/null
+++ b/srcpkgs/winusb/patches/support-PolicyKit.patch
@@ -0,0 +1,11 @@
+--- a/src/MainPanel.cpp	2024-05-29 02:25:33.973355791 -0300
++++ b/src/MainPanel.cpp	2024-05-29 03:02:00.747154122 -0300
+@@ -240,7 +240,7 @@
+             iso = m_dvdDriveDevList.at(m_dvdDriveList->GetSelection());
+         }
+ 
+-        PipeManager pipe(std::string("gksudo --description 'WinUSB' -- sh -c 'winusb --noColor --forGui --format \"") + iso + "\" \"" + device + "\" 2>&1'");
++        PipeManager pipe(std::string("pkexec --description 'WinUSB' -- sh -c 'winusb --noColor --forGui --format \"") + iso + "\" \"" + device + "\" 2>&1'");
+ 
+         wxProgressDialog *dialog = new wxProgressDialog(_("Installing..."), _("Please wait..."), 100, GetParent(), wxPD_APP_MODAL | wxPD_SMOOTH | wxPD_CAN_ABORT);
+ 
diff --git a/srcpkgs/winusb/template b/srcpkgs/winusb/template
index 5f116a336b61e9..ddfa7444620794 100644
--- a/srcpkgs/winusb/template
+++ b/srcpkgs/winusb/template
@@ -1,7 +1,7 @@
 # Template file for 'winusb'
 pkgname=winusb
 version=1.0.11
-revision=11
+revision=12
 archs="i686* x86_64*"
 build_style=gnu-configure
 configure_args="--with-wx-config=wx-config-gtk3"

Re: [PR PATCH] [Updated] winusb: Use pkexec instead of gksudo for privilege escalation

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

There is an updated pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-17
https://github.com/void-linux/void-packages/pull/50648

winusb: Use pkexec instead of gksudo for privilege escalation
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-17-50648.patch --]
[-- Type: text/x-diff, Size: 2293 bytes --]

From 9a75625774eafb4ab3887657e67d077892fcc117 Mon Sep 17 00:00:00 2001
From: bugcrazy <marcoaureliopc@gmail.com>
Date: Sun, 2 Jun 2024 01:23:38 -0300
Subject: [PATCH] winusb: Use pkexec instead of gksudo for privilege escalation

---
 srcpkgs/winusb/patches/support-PolicyKit.patch | 11 +++++++++++
 srcpkgs/winusb/template                        |  4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/winusb/patches/support-PolicyKit.patch

diff --git a/srcpkgs/winusb/patches/support-PolicyKit.patch b/srcpkgs/winusb/patches/support-PolicyKit.patch
new file mode 100644
index 00000000000000..44910318dd4bba
--- /dev/null
+++ b/srcpkgs/winusb/patches/support-PolicyKit.patch
@@ -0,0 +1,11 @@
+--- a/src/MainPanel.cpp	2024-05-29 02:25:33.973355791 -0300
++++ b/src/MainPanel.cpp	2024-05-29 03:02:00.747154122 -0300
+@@ -240,7 +240,7 @@
+             iso = m_dvdDriveDevList.at(m_dvdDriveList->GetSelection());
+         }
+ 
+-        PipeManager pipe(std::string("gksudo --description 'WinUSB' -- sh -c 'winusb --noColor --forGui --format \"") + iso + "\" \"" + device + "\" 2>&1'");
++        PipeManager pipe(std::string("pkexec --description 'WinUSB' -- sh -c 'winusb --noColor --forGui --format \"") + iso + "\" \"" + device + "\" 2>&1'");
+ 
+         wxProgressDialog *dialog = new wxProgressDialog(_("Installing..."), _("Please wait..."), 100, GetParent(), wxPD_APP_MODAL | wxPD_SMOOTH | wxPD_CAN_ABORT);
+ 
diff --git a/srcpkgs/winusb/template b/srcpkgs/winusb/template
index 5f116a336b61e9..50a4cfdc5a3b03 100644
--- a/srcpkgs/winusb/template
+++ b/srcpkgs/winusb/template
@@ -1,15 +1,15 @@
 # Template file for 'winusb'
 pkgname=winusb
 version=1.0.11
-revision=11
+revision=12
 archs="i686* x86_64*"
 build_style=gnu-configure
 configure_args="--with-wx-config=wx-config-gtk3"
 hostmakedepends="pkg-config"
 makedepends="wxWidgets-gtk3-devel ntfs-3g libparted-devel
  desktop-file-utils hicolor-icon-theme"
-short_desc="Simple tool to create your own usb stick windows installer"
 depends="desktop-file-utils hicolor-icon-theme parted ntfs-3g"
+short_desc="Simple tool to create your own usb stick windows installer"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="http://en.congelli.eu/prog_info_winusb.html"

Re: winusb: Use pkexec instead of gksudo for privilege escalation

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/50648#issuecomment-2143694855

Comment:
Patch for frontend-wxgtk: https://github.com/WoeUSB/WoeUSB-frontend-wxgtk/commit/94f1b083dcf64d8cdc95d5c552a24d18b0f32d22

Re: winusb: Use pkexec instead of gksudo for privilege escalation

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50648#issuecomment-2143724349

Comment:
that commit has been included in releases, why not just update the package? 

Re: winusb: Use pkexec instead of gksudo for privilege escalation

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/50648#issuecomment-2143747053

Comment:
> that commit has been included in releases, why not just update the package?

There have been no more winusb releases since 2015, the commit is more recent, derived from the code of another with the same code base.

Re: winusb: Use pkexec instead of gksudo for privilege escalation

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50648#issuecomment-2143783099

Comment:
then perhaps winusb should be removed

Re: winusb: Use pkexec instead of gksudo for privilege escalation

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/50648#issuecomment-2146190129

Comment:
> then perhaps winusb should be removed

It can be removed winusb, woeusb is in the repository, it is a fork of winusb, but it is not maintained, woe-cli is a fork of woeusb, there is a more updated project is woeusb-ng, it is not in the repository.

This explains the status of the projects:
https://github.com/slacka/WoeUSB?tab=readme-ov-file

Re: winusb: Use pkexec instead of gksudo for privilege escalation

[sgn]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/50648#issuecomment-2148971319

Comment:
Let's remove winusb, and make woeusb provides winusb. Maybe winusb as symlink to woeuse?

Re: winusb: Use pkexec instead of gksudo for privilege escalation

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/50648#issuecomment-2153546724

Comment:
> Let's remove winusb, and make woeusb provides winusb. Maybe winusb as symlink to woeuse?

There could be a symlink, the command between the two, works the same, just changes the name.