* [PR PATCH] vscode: remove deprecated --unity-launch flag from desktop file
@ 2024-06-10 16:06 deimonn
2024-06-10 16:21 ` classabbyamp
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: deimonn @ 2024-06-10 16:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
There is a new pull request by deimonn against master on the void-packages repository
https://github.com/deimonn/void-packages vscode
https://github.com/void-linux/void-packages/pull/50762
vscode: remove deprecated --unity-launch flag from desktop file
VSCode has [deprecated the --unity-launch flag](https://github.com/microsoft/vscode/issues/202545) and its presence was breaking the "Open with Code" context menu option.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
Closes #50682
A patch file from https://github.com/void-linux/void-packages/pull/50762.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-50762.patch --]
[-- Type: text/x-diff, Size: 1272 bytes --]
From 948492fcc2fc5ed8ea1728b8b56ee541c7a2c088 Mon Sep 17 00:00:00 2001
From: deimonn <deimonn@outlook.com>
Date: Mon, 10 Jun 2024 11:53:26 -0300
Subject: [PATCH] vscode: remove deprecated --unity-launch flag from desktop
file
---
srcpkgs/vscode/patches/fix_dir.patch | 2 +-
srcpkgs/vscode/template | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/vscode/patches/fix_dir.patch b/srcpkgs/vscode/patches/fix_dir.patch
index dbe615623d3c31..ca35ae86c677a4 100644
--- a/srcpkgs/vscode/patches/fix_dir.patch
+++ b/srcpkgs/vscode/patches/fix_dir.patch
@@ -33,7 +33,7 @@ index 4c939a2fab8..1f94f5fccfb 100755
Comment=Code Editing. Redefined.
GenericName=Text Editor
-Exec=@@EXEC@@ %F
-+Exec=/usr/lib/@@NAME@@/bin/@@NAME@@ --unity-launch %F
++Exec=/usr/lib/@@NAME@@/bin/@@NAME@@ %F
Icon=@@ICON@@
Type=Application
StartupNotify=false
diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index deb3846a0037d0..97bfe6419f69d7 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,7 +1,7 @@
# Template file for 'vscode'
pkgname=vscode
version=1.90.0
-revision=1
+revision=2
_electronver=24.3.0
_npmver=8.6.0
hostmakedepends="pkg-config python3 python3-setuptools nodejs yarn tar git ripgrep"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: vscode: remove deprecated --unity-launch flag from desktop file
2024-06-10 16:06 [PR PATCH] vscode: remove deprecated --unity-launch flag from desktop file deimonn
@ 2024-06-10 16:21 ` classabbyamp
2024-06-10 16:35 ` deimonn
2024-06-11 17:02 ` [PR PATCH] [Merged]: " classabbyamp
2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2024-06-10 16:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/50762#issuecomment-2158809508
Comment:
should this use `--new-window`?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: vscode: remove deprecated --unity-launch flag from desktop file
2024-06-10 16:06 [PR PATCH] vscode: remove deprecated --unity-launch flag from desktop file deimonn
2024-06-10 16:21 ` classabbyamp
@ 2024-06-10 16:35 ` deimonn
2024-06-11 17:02 ` [PR PATCH] [Merged]: " classabbyamp
2 siblings, 0 replies; 4+ messages in thread
From: deimonn @ 2024-06-10 16:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
New comment by deimonn on void-packages repository
https://github.com/void-linux/void-packages/pull/50762#issuecomment-2158834797
Comment:
Someone else already suggested that on [this arch package issue](https://github.com/nihaals/visual-studio-code-insiders-arch/pull/5), and the response was that it may be undesirable, as it "[...] makes Visual Studio open a new window each time a file is opened, irrespective of the folder the files are placed in".
I've been using it without `--unity-launch` and without `--new-window` and so far I haven't detected any strange behavior.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Merged]: vscode: remove deprecated --unity-launch flag from desktop file
2024-06-10 16:06 [PR PATCH] vscode: remove deprecated --unity-launch flag from desktop file deimonn
2024-06-10 16:21 ` classabbyamp
2024-06-10 16:35 ` deimonn
@ 2024-06-11 17:02 ` classabbyamp
2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2024-06-11 17:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
There's a merged pull request on the void-packages repository
vscode: remove deprecated --unity-launch flag from desktop file
https://github.com/void-linux/void-packages/pull/50762
Description:
VSCode has [deprecated the --unity-launch flag](https://github.com/microsoft/vscode/issues/202545) and its presence was breaking the "Open with Code" context menu option.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
Closes #50682
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-11 17:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-10 16:06 [PR PATCH] vscode: remove deprecated --unity-launch flag from desktop file deimonn
2024-06-10 16:21 ` classabbyamp
2024-06-10 16:35 ` deimonn
2024-06-11 17:02 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).