[PR PATCH] gajim: update to 1.9.0, adopt.

[PR PATCH] gajim: update to 1.9.0, adopt.

[Emru1]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

There is a new pull request by Emru1 against master on the void-packages repository

https://github.com/Emru1/void-packages gajim-1.9.0
https://github.com/void-linux/void-packages/pull/50773

gajim: update to 1.9.0, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, amd64-glibc

Python3-nbxmpp is here too, as dependency


A patch file from https://github.com/void-linux/void-packages/pull/50773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gajim-1.9.0-50773.patch --]
[-- Type: text/x-diff, Size: 2756 bytes --]

From d4f6a40b6a1193911aacabd0d195a627f5475415 Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Tue, 11 Jun 2024 14:48:57 +0200
Subject: [PATCH 1/2] python3-nbxmpp: update to 5.0.0.

---
 srcpkgs/python3-nbxmpp/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-nbxmpp/template b/srcpkgs/python3-nbxmpp/template
index 433a4bbd41d674..708256356a3cc5 100644
--- a/srcpkgs/python3-nbxmpp/template
+++ b/srcpkgs/python3-nbxmpp/template
@@ -1,6 +1,6 @@
 # Template file for 'python3-nbxmpp'
 pkgname=python3-nbxmpp
-version=4.5.3
+version=5.0.0
 revision=1
 build_style=python3-pep517
 hostmakedepends="python3-wheel"
@@ -12,7 +12,7 @@ license="GPL-2.0-or-later"
 homepage="https://python-nbxmpp.gajim.org/"
 changelog="https://dev.gajim.org/gajim/python-nbxmpp/raw/master/ChangeLog"
 distfiles="${PYPI_SITE}/n/nbxmpp/nbxmpp-${version}.tar.gz"
-checksum=6e620e6da8ec9f9bc4fad4b1f7ff8467c3ae9efee8ea0593ce4258ac03e00b9e
+checksum=52319a08fb0f017833a305342a67d07f77f167821c975e2cc520b6b86d4cdc54
 
 do_check() {
 	coverage run --source=nbxmpp -m unittest discover -v

From cce7ac422690b53aeaa7977d2007b8c8350f345e Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Tue, 11 Jun 2024 14:49:10 +0200
Subject: [PATCH 2/2] gajim: update to 1.9.0, adopt.

---
 srcpkgs/gajim/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gajim/template b/srcpkgs/gajim/template
index cf49fab68994f4..ce7ab528a91b52 100644
--- a/srcpkgs/gajim/template
+++ b/srcpkgs/gajim/template
@@ -1,6 +1,6 @@
 # Template file for 'gajim'
 pkgname=gajim
-version=1.8.4
+version=1.9.0
 revision=1
 build_style=python3-pep517
 hostmakedepends="gettext python3-wheel"
@@ -10,15 +10,16 @@ depends="python3-gobject python3-setuptools python3-Pillow
  python3-precis-i18n python3-packaging python3-setuptools python3-distro
  python3-qrcode python3-omemo-dr
  python3-netifaces python3-pyasn1 python3-jeepney libsoup3 farstream gst-plugins-base1
- gst-plugins-ugly1 gst-libav gtksourceview4"
+ gst-plugins-ugly1 gst-libav gtksourceview4
+ python3-SQLAlchemy2 python3-emoji"
 checkdepends="${depends} python3-packaging"
 short_desc="Full featured Jabber/XMPP client"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Emil Tomczyk <emru@emru.xyz>"
 license="GPL-3.0-only"
 homepage="https://www.gajim.org"
 changelog="https://dev.gajim.org/gajim/gajim/-/raw/master/ChangeLog"
 distfiles="https://gajim.org/downloads/${version%.*}/gajim-${version}.tar.gz"
-checksum=58fced87b1ce01b3d5269bcdf33499246533b01b4008d9701eb1e10cf94e49c5
+checksum=7a244b419afad01be3aaa9e860463e2ecc205ba7be4bd9932ef04a5425eb0b32
 
 post_build() {
 	./pep517build/build_metadata.py -o dist/metadata

Re: [PR PATCH] [Updated] gajim: update to 1.9.0, adopt.

[Emru1]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

There is an updated pull request by Emru1 against master on the void-packages repository

https://github.com/Emru1/void-packages gajim-1.9.0
https://github.com/void-linux/void-packages/pull/50773

gajim: update to 1.9.0, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, amd64-glibc

Python3-nbxmpp is here too, as dependency


A patch file from https://github.com/void-linux/void-packages/pull/50773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gajim-1.9.0-50773.patch --]
[-- Type: text/x-diff, Size: 3967 bytes --]

From d4f6a40b6a1193911aacabd0d195a627f5475415 Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Tue, 11 Jun 2024 14:48:57 +0200
Subject: [PATCH 1/2] python3-nbxmpp: update to 5.0.0.

---
 srcpkgs/python3-nbxmpp/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-nbxmpp/template b/srcpkgs/python3-nbxmpp/template
index 433a4bbd41d674..708256356a3cc5 100644
--- a/srcpkgs/python3-nbxmpp/template
+++ b/srcpkgs/python3-nbxmpp/template
@@ -1,6 +1,6 @@
 # Template file for 'python3-nbxmpp'
 pkgname=python3-nbxmpp
-version=4.5.3
+version=5.0.0
 revision=1
 build_style=python3-pep517
 hostmakedepends="python3-wheel"
@@ -12,7 +12,7 @@ license="GPL-2.0-or-later"
 homepage="https://python-nbxmpp.gajim.org/"
 changelog="https://dev.gajim.org/gajim/python-nbxmpp/raw/master/ChangeLog"
 distfiles="${PYPI_SITE}/n/nbxmpp/nbxmpp-${version}.tar.gz"
-checksum=6e620e6da8ec9f9bc4fad4b1f7ff8467c3ae9efee8ea0593ce4258ac03e00b9e
+checksum=52319a08fb0f017833a305342a67d07f77f167821c975e2cc520b6b86d4cdc54
 
 do_check() {
 	coverage run --source=nbxmpp -m unittest discover -v

From 7f9a898c9c8f992392d4f7facbe80a45566483da Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Tue, 11 Jun 2024 14:49:10 +0200
Subject: [PATCH 2/2] gajim: update to 1.9.0, adopt.

People on Gajim's MUC advised to remove this test
---
 srcpkgs/gajim/patches/remove_broken_test.patch | 15 +++++++++++++++
 srcpkgs/gajim/template                         |  9 +++++----
 2 files changed, 20 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/gajim/patches/remove_broken_test.patch

diff --git a/srcpkgs/gajim/patches/remove_broken_test.patch b/srcpkgs/gajim/patches/remove_broken_test.patch
new file mode 100644
index 00000000000000..5b11e87cfebf63
--- /dev/null
+++ b/srcpkgs/gajim/patches/remove_broken_test.patch
@@ -0,0 +1,15 @@
+--- a/test/gui/test_util.py	2024-06-10 10:03:49.000000000 +0200
++++ b/test/gui/test_util.py	2024-06-11 16:15:31.000273954 +0200
+@@ -57,9 +57,9 @@
+         # returns 'c', not 'ch'.
+ 
+         # In most locales (say, any western one):
+-        devanagari_kshi = '\u0915\u094D' + devanagari_ssi
+-        self.assertEqual(
+-            get_first_grapheme(devanagari_kshi), '\u0915\u094D', 'क्षि -> क् ')
++        # devanagari_kshi = '\u0915\u094D' + devanagari_ssi
++        # self.assertEqual(
++        #     get_first_grapheme(devanagari_kshi), '\u0915\u094D', 'क्षि -> क् ')
+         # This probably won't fail on *any* locale, ever, again because the
+         # implementation doesn't seem locale-specific.
+ 
diff --git a/srcpkgs/gajim/template b/srcpkgs/gajim/template
index cf49fab68994f4..ce7ab528a91b52 100644
--- a/srcpkgs/gajim/template
+++ b/srcpkgs/gajim/template
@@ -1,6 +1,6 @@
 # Template file for 'gajim'
 pkgname=gajim
-version=1.8.4
+version=1.9.0
 revision=1
 build_style=python3-pep517
 hostmakedepends="gettext python3-wheel"
@@ -10,15 +10,16 @@ depends="python3-gobject python3-setuptools python3-Pillow
  python3-precis-i18n python3-packaging python3-setuptools python3-distro
  python3-qrcode python3-omemo-dr
  python3-netifaces python3-pyasn1 python3-jeepney libsoup3 farstream gst-plugins-base1
- gst-plugins-ugly1 gst-libav gtksourceview4"
+ gst-plugins-ugly1 gst-libav gtksourceview4
+ python3-SQLAlchemy2 python3-emoji"
 checkdepends="${depends} python3-packaging"
 short_desc="Full featured Jabber/XMPP client"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Emil Tomczyk <emru@emru.xyz>"
 license="GPL-3.0-only"
 homepage="https://www.gajim.org"
 changelog="https://dev.gajim.org/gajim/gajim/-/raw/master/ChangeLog"
 distfiles="https://gajim.org/downloads/${version%.*}/gajim-${version}.tar.gz"
-checksum=58fced87b1ce01b3d5269bcdf33499246533b01b4008d9701eb1e10cf94e49c5
+checksum=7a244b419afad01be3aaa9e860463e2ecc205ba7be4bd9932ef04a5425eb0b32
 
 post_build() {
 	./pep517build/build_metadata.py -o dist/metadata

Re: gajim: update to 1.9.0, adopt.

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/50773#issuecomment-2161360313

Comment:
Tested on x86_64-glibc with both a public room (through biboumi) and an
OMEMO encrypted room. Works as expected!

Re: gajim: update to 1.9.0, adopt.

[lissine0]

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

New comment by lissine0 on void-packages repository

https://github.com/void-linux/void-packages/pull/50773#issuecomment-2166984505

Comment:
Hi, it also works for me on x86_64-glibc

A problem I have (which exists before this update), is that by default, the emojis are displayed in black and white, and many emojis sent by other users can't be decyphered.
(I have the freetype package installed.)

![default](https://github.com/void-linux/void-packages/assets/138154076/d09049a1-89c0-4f81-82d0-8eec8bf652e5)
![default](https://github.com/void-linux/void-packages/assets/138154076/409c708a-993d-4e59-b873-e6d7e1fb861b)

Installing font-awesome6 gave me more black and white emojis
And installing noto-fonts-emoji or  font-emoji-one-color gave me a lot of colored emojis

font-emoji-one-color:
![font-emoji-one-color_1](https://github.com/void-linux/void-packages/assets/138154076/6d4b9d42-23a0-472d-baf1-4593d7c645d5)
![font-emoji-one-color_2](https://github.com/void-linux/void-packages/assets/138154076/fa09f755-379c-40fe-ad8c-3053dc329f8b)

noto-fonts-emoji: (which is the emoji font shown in the official screenshots https://gajim.org/img/news/message-reactions.png )
![noto-fonts-emoji_1](https://github.com/void-linux/void-packages/assets/138154076/f7700e67-91bf-442c-a53a-18efde1ef595)
![noto-fonts-emoji_2](https://github.com/void-linux/void-packages/assets/138154076/7bb7b296-f62f-4a34-9b70-1c1b6bc75638)


What do you think? should we add noto-fonts-emoji as a dependency? (I think it looks better than font-emoji-one-color)

Or is this issue only in my setup? (I have emojis working correctly on Firefox)

Re: gajim: update to 1.9.0, adopt.

[elliniyessine]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

New comment by elliniyessine on void-packages repository

https://github.com/void-linux/void-packages/pull/50773#issuecomment-2168806544

Comment:
It turns out font-emoji-one-color is a proprietary font, and we may not use it for free for non-profit use https://joypixels.com/licenses

I suggest Twitter's open source twemoji (shown here)
![twemoji](https://github.com/void-linux/void-packages/assets/130303156/8f2f7e39-e5e1-4315-81d4-3395ca405273)

Or we can use Google's open source noto-fonts-emoji (shown in the previous comment)
twemoji is smaller to download (4MB vs 18MB) and uses less disk space (14MB vs 19MB) 
(Plus I think twemoji looks better)

Re: gajim: update to 1.9.0, adopt.

[Emru1]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New comment by Emru1 on void-packages repository

https://github.com/void-linux/void-packages/pull/50773#issuecomment-2169240807

Comment:
I think that we shouldn't use any emoji pack as dependency. User shouldn't be forced to use/download any packages that aren't strictly required.
We could add information to `README.voidlinux` suggesting some emoji packages.

Re: gajim: update to 1.9.0, adopt.

[Emru1]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

New comment by Emru1 on void-packages repository

https://github.com/void-linux/void-packages/pull/50773#issuecomment-2169240807

Comment:
I think that we shouldn't use any emoji pack as dependency. User shouldn't be forced to use/download any packages that aren't strictly required.
We could add information to `README.voidlinux` suggesting some emoji packages.

For me it's same situation as with some fonts not installed by default by `xorg` package.

Re: [PR PATCH] [Updated] gajim: update to 1.9.0, adopt.

[Emru1]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

There is an updated pull request by Emru1 against master on the void-packages repository

https://github.com/Emru1/void-packages gajim-1.9.0
https://github.com/void-linux/void-packages/pull/50773

gajim: update to 1.9.0, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, amd64-glibc

Python3-nbxmpp is here too, as dependency


A patch file from https://github.com/void-linux/void-packages/pull/50773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gajim-1.9.0-50773.patch --]
[-- Type: text/x-diff, Size: 5352 bytes --]

From 9a81beb8cf53485b8569a43dd42de85ead02ac39 Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Tue, 11 Jun 2024 14:48:57 +0200
Subject: [PATCH 1/2] python3-nbxmpp: update to 5.0.0.

---
 srcpkgs/python3-nbxmpp/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-nbxmpp/template b/srcpkgs/python3-nbxmpp/template
index 433a4bbd41d674..708256356a3cc5 100644
--- a/srcpkgs/python3-nbxmpp/template
+++ b/srcpkgs/python3-nbxmpp/template
@@ -1,6 +1,6 @@
 # Template file for 'python3-nbxmpp'
 pkgname=python3-nbxmpp
-version=4.5.3
+version=5.0.0
 revision=1
 build_style=python3-pep517
 hostmakedepends="python3-wheel"
@@ -12,7 +12,7 @@ license="GPL-2.0-or-later"
 homepage="https://python-nbxmpp.gajim.org/"
 changelog="https://dev.gajim.org/gajim/python-nbxmpp/raw/master/ChangeLog"
 distfiles="${PYPI_SITE}/n/nbxmpp/nbxmpp-${version}.tar.gz"
-checksum=6e620e6da8ec9f9bc4fad4b1f7ff8467c3ae9efee8ea0593ce4258ac03e00b9e
+checksum=52319a08fb0f017833a305342a67d07f77f167821c975e2cc520b6b86d4cdc54
 
 do_check() {
 	coverage run --source=nbxmpp -m unittest discover -v

From 2ccae0d9526d83c4d4b509ecde5f70600a05cf5b Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Tue, 11 Jun 2024 14:49:10 +0200
Subject: [PATCH 2/2] gajim: update to 1.9.0, adopt.

People on Gajim's MUC advised to remove this test
---
 srcpkgs/gajim/INSTALL.msg                     |  1 +
 srcpkgs/gajim/files/README.voidlinux          |  3 +++
 .../gajim/patches/remove_broken_test.patch    | 15 ++++++++++++++
 srcpkgs/gajim/template                        | 20 +++++++++----------
 4 files changed, 29 insertions(+), 10 deletions(-)
 create mode 120000 srcpkgs/gajim/INSTALL.msg
 create mode 100644 srcpkgs/gajim/patches/remove_broken_test.patch

diff --git a/srcpkgs/gajim/INSTALL.msg b/srcpkgs/gajim/INSTALL.msg
new file mode 120000
index 00000000000000..4c01261b738c52
--- /dev/null
+++ b/srcpkgs/gajim/INSTALL.msg
@@ -0,0 +1 @@
+files/README.voidlinux
\ No newline at end of file
diff --git a/srcpkgs/gajim/files/README.voidlinux b/srcpkgs/gajim/files/README.voidlinux
index 3b19a82a5bb256..73c3158d82722a 100644
--- a/srcpkgs/gajim/files/README.voidlinux
+++ b/srcpkgs/gajim/files/README.voidlinux
@@ -1 +1,4 @@
 Visit https://dev.gajim.org/gajim/gajim-plugins/-/wikis/home to install plugins.
+Some plugins are already available via Gajim->Plugins menu.
+If you want to use same emojis as in official screenshots, install
+"noto-fonts-emoji" package. Another popular one is "twemoji".
diff --git a/srcpkgs/gajim/patches/remove_broken_test.patch b/srcpkgs/gajim/patches/remove_broken_test.patch
new file mode 100644
index 00000000000000..5b11e87cfebf63
--- /dev/null
+++ b/srcpkgs/gajim/patches/remove_broken_test.patch
@@ -0,0 +1,15 @@
+--- a/test/gui/test_util.py	2024-06-10 10:03:49.000000000 +0200
++++ b/test/gui/test_util.py	2024-06-11 16:15:31.000273954 +0200
+@@ -57,9 +57,9 @@
+         # returns 'c', not 'ch'.
+ 
+         # In most locales (say, any western one):
+-        devanagari_kshi = '\u0915\u094D' + devanagari_ssi
+-        self.assertEqual(
+-            get_first_grapheme(devanagari_kshi), '\u0915\u094D', 'क्षि -> क् ')
++        # devanagari_kshi = '\u0915\u094D' + devanagari_ssi
++        # self.assertEqual(
++        #     get_first_grapheme(devanagari_kshi), '\u0915\u094D', 'क्षि -> क् ')
+         # This probably won't fail on *any* locale, ever, again because the
+         # implementation doesn't seem locale-specific.
+ 
diff --git a/srcpkgs/gajim/template b/srcpkgs/gajim/template
index cf49fab68994f4..fddd50f555e54f 100644
--- a/srcpkgs/gajim/template
+++ b/srcpkgs/gajim/template
@@ -1,24 +1,24 @@
 # Template file for 'gajim'
 pkgname=gajim
-version=1.8.4
+version=1.9.0
 revision=1
 build_style=python3-pep517
 hostmakedepends="gettext python3-wheel"
-depends="python3-gobject python3-setuptools python3-Pillow
- python3-cairo python3-dbus libsecret gsound libnm
- python3-nbxmpp python3-openssl python3-css-parser python3-keyring
- python3-precis-i18n python3-packaging python3-setuptools python3-distro
- python3-qrcode python3-omemo-dr
- python3-netifaces python3-pyasn1 python3-jeepney libsoup3 farstream gst-plugins-base1
- gst-plugins-ugly1 gst-libav gtksourceview4"
+depends="farstream gsound gst-libav gst-plugins-base1 gst-plugins-ugly1
+ gtksourceview4 libnm libsecret libsoup3 python3-Pillow python3-SQLAlchemy2
+ python3-cairo python3-css-parser python3-dbus python3-distro python3-emoji
+ python3-gobject python3-jeepney python3-keyring python3-nbxmpp
+ python3-netifaces python3-omemo-dr python3-openssl python3-packaging
+ python3-precis-i18n python3-pyasn1 python3-qrcode python3-setuptools
+ python3-setuptools"
 checkdepends="${depends} python3-packaging"
 short_desc="Full featured Jabber/XMPP client"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Emil Tomczyk <emru@emru.xyz>"
 license="GPL-3.0-only"
 homepage="https://www.gajim.org"
 changelog="https://dev.gajim.org/gajim/gajim/-/raw/master/ChangeLog"
 distfiles="https://gajim.org/downloads/${version%.*}/gajim-${version}.tar.gz"
-checksum=58fced87b1ce01b3d5269bcdf33499246533b01b4008d9701eb1e10cf94e49c5
+checksum=7a244b419afad01be3aaa9e860463e2ecc205ba7be4bd9932ef04a5425eb0b32
 
 post_build() {
 	./pep517build/build_metadata.py -o dist/metadata

Re: gajim: update to 1.9.0, adopt.

[Emru1]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by Emru1 on void-packages repository

https://github.com/void-linux/void-packages/pull/50773#issuecomment-2171270448

Comment:
@lissine0 @elliniyessine I added emoji packages to README
I also symlinked README to INSTALL.msg

Re: [PR REVIEW] gajim: update to 1.9.0, adopt.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50773#discussion_r1641994788

Comment:
don't use INSTALL.msg for this

Re: [PR PATCH] [Updated] gajim: update to 1.9.0, adopt.

[Emru1]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

There is an updated pull request by Emru1 against master on the void-packages repository

https://github.com/Emru1/void-packages gajim-1.9.0
https://github.com/void-linux/void-packages/pull/50773

gajim: update to 1.9.0, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, amd64-glibc

Python3-nbxmpp is here too, as dependency


A patch file from https://github.com/void-linux/void-packages/pull/50773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gajim-1.9.0-50773.patch --]
[-- Type: text/x-diff, Size: 5015 bytes --]

From 9a81beb8cf53485b8569a43dd42de85ead02ac39 Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Tue, 11 Jun 2024 14:48:57 +0200
Subject: [PATCH 1/2] python3-nbxmpp: update to 5.0.0.

---
 srcpkgs/python3-nbxmpp/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-nbxmpp/template b/srcpkgs/python3-nbxmpp/template
index 433a4bbd41d674..708256356a3cc5 100644
--- a/srcpkgs/python3-nbxmpp/template
+++ b/srcpkgs/python3-nbxmpp/template
@@ -1,6 +1,6 @@
 # Template file for 'python3-nbxmpp'
 pkgname=python3-nbxmpp
-version=4.5.3
+version=5.0.0
 revision=1
 build_style=python3-pep517
 hostmakedepends="python3-wheel"
@@ -12,7 +12,7 @@ license="GPL-2.0-or-later"
 homepage="https://python-nbxmpp.gajim.org/"
 changelog="https://dev.gajim.org/gajim/python-nbxmpp/raw/master/ChangeLog"
 distfiles="${PYPI_SITE}/n/nbxmpp/nbxmpp-${version}.tar.gz"
-checksum=6e620e6da8ec9f9bc4fad4b1f7ff8467c3ae9efee8ea0593ce4258ac03e00b9e
+checksum=52319a08fb0f017833a305342a67d07f77f167821c975e2cc520b6b86d4cdc54
 
 do_check() {
 	coverage run --source=nbxmpp -m unittest discover -v

From 4567e15da9d498883fd934cf69b3c4df10efcd8c Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Tue, 11 Jun 2024 14:49:10 +0200
Subject: [PATCH 2/2] gajim: update to 1.9.0, adopt.

People on Gajim's MUC advised to remove this test
---
 srcpkgs/gajim/files/README.voidlinux          |  3 +++
 .../gajim/patches/remove_broken_test.patch    | 15 ++++++++++++++
 srcpkgs/gajim/template                        | 20 +++++++++----------
 3 files changed, 28 insertions(+), 10 deletions(-)
 create mode 100644 srcpkgs/gajim/patches/remove_broken_test.patch

diff --git a/srcpkgs/gajim/files/README.voidlinux b/srcpkgs/gajim/files/README.voidlinux
index 3b19a82a5bb256..73c3158d82722a 100644
--- a/srcpkgs/gajim/files/README.voidlinux
+++ b/srcpkgs/gajim/files/README.voidlinux
@@ -1 +1,4 @@
 Visit https://dev.gajim.org/gajim/gajim-plugins/-/wikis/home to install plugins.
+Some plugins are already available via Gajim->Plugins menu.
+If you want to use same emojis as in official screenshots, install
+"noto-fonts-emoji" package. Another popular one is "twemoji".
diff --git a/srcpkgs/gajim/patches/remove_broken_test.patch b/srcpkgs/gajim/patches/remove_broken_test.patch
new file mode 100644
index 00000000000000..5b11e87cfebf63
--- /dev/null
+++ b/srcpkgs/gajim/patches/remove_broken_test.patch
@@ -0,0 +1,15 @@
+--- a/test/gui/test_util.py	2024-06-10 10:03:49.000000000 +0200
++++ b/test/gui/test_util.py	2024-06-11 16:15:31.000273954 +0200
+@@ -57,9 +57,9 @@
+         # returns 'c', not 'ch'.
+ 
+         # In most locales (say, any western one):
+-        devanagari_kshi = '\u0915\u094D' + devanagari_ssi
+-        self.assertEqual(
+-            get_first_grapheme(devanagari_kshi), '\u0915\u094D', 'क्षि -> क् ')
++        # devanagari_kshi = '\u0915\u094D' + devanagari_ssi
++        # self.assertEqual(
++        #     get_first_grapheme(devanagari_kshi), '\u0915\u094D', 'क्षि -> क् ')
+         # This probably won't fail on *any* locale, ever, again because the
+         # implementation doesn't seem locale-specific.
+ 
diff --git a/srcpkgs/gajim/template b/srcpkgs/gajim/template
index cf49fab68994f4..fddd50f555e54f 100644
--- a/srcpkgs/gajim/template
+++ b/srcpkgs/gajim/template
@@ -1,24 +1,24 @@
 # Template file for 'gajim'
 pkgname=gajim
-version=1.8.4
+version=1.9.0
 revision=1
 build_style=python3-pep517
 hostmakedepends="gettext python3-wheel"
-depends="python3-gobject python3-setuptools python3-Pillow
- python3-cairo python3-dbus libsecret gsound libnm
- python3-nbxmpp python3-openssl python3-css-parser python3-keyring
- python3-precis-i18n python3-packaging python3-setuptools python3-distro
- python3-qrcode python3-omemo-dr
- python3-netifaces python3-pyasn1 python3-jeepney libsoup3 farstream gst-plugins-base1
- gst-plugins-ugly1 gst-libav gtksourceview4"
+depends="farstream gsound gst-libav gst-plugins-base1 gst-plugins-ugly1
+ gtksourceview4 libnm libsecret libsoup3 python3-Pillow python3-SQLAlchemy2
+ python3-cairo python3-css-parser python3-dbus python3-distro python3-emoji
+ python3-gobject python3-jeepney python3-keyring python3-nbxmpp
+ python3-netifaces python3-omemo-dr python3-openssl python3-packaging
+ python3-precis-i18n python3-pyasn1 python3-qrcode python3-setuptools
+ python3-setuptools"
 checkdepends="${depends} python3-packaging"
 short_desc="Full featured Jabber/XMPP client"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Emil Tomczyk <emru@emru.xyz>"
 license="GPL-3.0-only"
 homepage="https://www.gajim.org"
 changelog="https://dev.gajim.org/gajim/gajim/-/raw/master/ChangeLog"
 distfiles="https://gajim.org/downloads/${version%.*}/gajim-${version}.tar.gz"
-checksum=58fced87b1ce01b3d5269bcdf33499246533b01b4008d9701eb1e10cf94e49c5
+checksum=7a244b419afad01be3aaa9e860463e2ecc205ba7be4bd9932ef04a5425eb0b32
 
 post_build() {
 	./pep517build/build_metadata.py -o dist/metadata

Re: [PR REVIEW] gajim: update to 1.9.0, adopt.

[Emru1]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by Emru1 on void-packages repository

https://github.com/void-linux/void-packages/pull/50773#discussion_r1642264021

Comment:
removed

Re: [PR PATCH] [Merged]: gajim: update to 1.9.0, adopt.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

There's a merged pull request on the void-packages repository

gajim: update to 1.9.0, adopt.
https://github.com/void-linux/void-packages/pull/50773

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, amd64-glibc

Python3-nbxmpp is here too, as dependency