Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] fancontrol: fix run script
@ 2024-06-11 21:47 philhofer
  2024-06-11 21:52 ` [PR PATCH] [Closed]: " classabbyamp
  2024-06-11 21:53 ` classabbyamp
  0 siblings, 2 replies; 3+ messages in thread
From: philhofer @ 2024-06-11 21:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

There is a new pull request by philhofer against master on the void-packages repository

https://github.com/philhofer/void-packages master
https://github.com/void-linux/void-packages/pull/50789

fancontrol: fix run script
The existing `run` script does not source `conf` correctly.
Tested on a Mellanox SN2700 running void.


A patch file from https://github.com/void-linux/void-packages/pull/50789.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-50789.patch --]
[-- Type: text/x-diff, Size: 710 bytes --]

From 2ddcd9cd15ac8211565693bf8a9a0bef984dfa2e Mon Sep 17 00:00:00 2001
From: Phil Hofer <phil@sunfi.sh>
Date: Tue, 11 Jun 2024 14:41:14 -0700
Subject: [PATCH] fancontrol: fix run script

---
 srcpkgs/lm_sensors/files/fancontrol/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/lm_sensors/files/fancontrol/run b/srcpkgs/lm_sensors/files/fancontrol/run
index 0025d9784a5d2e..6aa08f456d6da8 100644
--- a/srcpkgs/lm_sensors/files/fancontrol/run
+++ b/srcpkgs/lm_sensors/files/fancontrol/run
@@ -1,5 +1,5 @@
 #!/bin/sh
 exec 2>&1
-[ -r conf ] && . conf
+[ -r conf ] && . ./conf
 [ ! -r ${CONF_FILE:-/etc/fancontrol} ] && exit 1
 exec /usr/bin/fancontrol ${CONF_FILE:-/etc/fancontrol}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: fancontrol: fix run script
  2024-06-11 21:47 [PR PATCH] fancontrol: fix run script philhofer
@ 2024-06-11 21:52 ` classabbyamp
  2024-06-11 21:53 ` classabbyamp
  1 sibling, 0 replies; 3+ messages in thread
From: classabbyamp @ 2024-06-11 21:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

There's a closed pull request on the void-packages repository

fancontrol: fix run script
https://github.com/void-linux/void-packages/pull/50789

Description:
The existing `run` script does not source `conf` correctly.
Tested on a Mellanox SN2700 running void (we provide our own `conf` which involves auto-generating the required config).


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: fancontrol: fix run script
  2024-06-11 21:47 [PR PATCH] fancontrol: fix run script philhofer
  2024-06-11 21:52 ` [PR PATCH] [Closed]: " classabbyamp
@ 2024-06-11 21:53 ` classabbyamp
  1 sibling, 0 replies; 3+ messages in thread
From: classabbyamp @ 2024-06-11 21:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50789#issuecomment-2161661870

Comment:
good catch, found 3 other instances of it and fixed them too

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-11 21:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-11 21:47 [PR PATCH] fancontrol: fix run script philhofer
2024-06-11 21:52 ` [PR PATCH] [Closed]: " classabbyamp
2024-06-11 21:53 ` classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).