Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] GNU Make package doesn't make a symlink for /usr/bin/gmake
@ 2024-06-13  6:08 rudzik8
  2024-06-14  0:25 ` ahesford
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: rudzik8 @ 2024-06-13  6:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

New issue by rudzik8 on void-packages repository

https://github.com/void-linux/void-packages/issues/50812

Description:
### Is this a new report?

Yes

### System Info

Void 6.6.32_1 x86_64 AuthenticAMD notuptodate rFFF

### Package(s) Affected

make-4.4.1_1

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Since our `make` implementation is GNU Make, it is really weird for it to not include a symlink for `gmake`.

For example, this is the output of `ls -l /usr/bin/ | grep "make"` on an Ubuntu system with `make` package installed is:
```
lrwxrwxrwx 1 root root           4 Feb 15  2022 gmake -> make
-rwxr-xr-x 1 root root      255696 Feb 15  2022 make
-rwxr-xr-x 1 root root        4905 Feb 15  2022 make-first-existing-target
```
And all `gmake` commands resolve without any problems there.

### Actual behaviour

CMake checks for `gmake` don't pass, its "simple test program" to verify `cc` doesn't compile (because it expects `gmake` to exist, and doesn't find it), and nobody's happy. :(

This is, however, easily fixed by doing `sudo ln -s /usr/bin/make /usr/bin/gmake`.

### Steps to reproduce

Try CMake'ing anything on a new Void install with `make` and `gcc` installed. [In my case, it was Minetest (+ its deps ofc)](https://github.com/minetest/minetest/issues/14746)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: GNU Make package doesn't make a symlink for /usr/bin/gmake
  2024-06-13  6:08 [ISSUE] GNU Make package doesn't make a symlink for /usr/bin/gmake rudzik8
@ 2024-06-14  0:25 ` ahesford
  2024-06-14  0:27 ` ahesford
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ahesford @ 2024-06-14  0:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/50812#issuecomment-2166997386

Comment:
Why would we make a symlink? The package installs itself as `make` and it's the default and expected version of make in a Void development environment. Also note that we have a metric ton of CMake packages in the repo, and they all build fine with our make.

Your CMake scripts are broken (and probably aimed at some BSD) if they demand to find GNU make as `gmake`.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: GNU Make package doesn't make a symlink for /usr/bin/gmake
  2024-06-13  6:08 [ISSUE] GNU Make package doesn't make a symlink for /usr/bin/gmake rudzik8
  2024-06-14  0:25 ` ahesford
@ 2024-06-14  0:27 ` ahesford
  2024-06-14  1:18 ` classabbyamp
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ahesford @ 2024-06-14  0:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/50812#issuecomment-2166997386

Comment:
Why would we make a symlink? The package installs itself as `make` and it's the default and expected version of make in a Void development environment. Also note that we have a metric ton of CMake packages in the repo, and they all build fine with our make.

Your CMake scripts are broken (and probably aimed at some BSD) if they demand to find GNU make as `gmake`.

Edit: although our CMake uses ninja by default, this wasn't always the case, and we've never installed a `gmake` symlink.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: GNU Make package doesn't make a symlink for /usr/bin/gmake
  2024-06-13  6:08 [ISSUE] GNU Make package doesn't make a symlink for /usr/bin/gmake rudzik8
  2024-06-14  0:25 ` ahesford
  2024-06-14  0:27 ` ahesford
@ 2024-06-14  1:18 ` classabbyamp
  2024-06-14  1:41 ` classabbyamp
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-06-14  1:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/50812#issuecomment-2167039838

Comment:
```
$ cat /usr/share/cmake-3.27/Modules/CMakeUnixFindMake.cmake
...
find_program(CMAKE_MAKE_PROGRAM NAMES gmake make smake)
...
```
pretty sure cmake should find `make` just fine without it being called `gmake`. what's the *exact* cmake output where this occurs?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: GNU Make package doesn't make a symlink for /usr/bin/gmake
  2024-06-13  6:08 [ISSUE] GNU Make package doesn't make a symlink for /usr/bin/gmake rudzik8
                   ` (2 preceding siblings ...)
  2024-06-14  1:18 ` classabbyamp
@ 2024-06-14  1:41 ` classabbyamp
  2024-06-14  2:08 ` sgn
  2024-06-14  3:37 ` [ISSUE] [CLOSED] " ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-06-14  1:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/50812#issuecomment-2167039838

Comment:
```
$ cat /usr/share/cmake-3.27/Modules/CMakeUnixFindMake.cmake
...
find_program(CMAKE_MAKE_PROGRAM NAMES gmake make smake)
...
```
pretty sure cmake should find `make` just fine without it being called `gmake`. what's the *exact* cmake output where this occurs? do you have a minimal reproducing cmake project?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: GNU Make package doesn't make a symlink for /usr/bin/gmake
  2024-06-13  6:08 [ISSUE] GNU Make package doesn't make a symlink for /usr/bin/gmake rudzik8
                   ` (3 preceding siblings ...)
  2024-06-14  1:41 ` classabbyamp
@ 2024-06-14  2:08 ` sgn
  2024-06-14  3:37 ` [ISSUE] [CLOSED] " ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2024-06-14  2:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/50812#issuecomment-2167080388

Comment:

> Your CMake scripts are broken (and probably aimed at some BSD) if they demand to find GNU make as `gmake`.
> 

If a CMake scripts care about its backend, or assuming its backend is Make, it's broken.

If a CMake scripts want GNU Make, it's very broken. If it  wants specially gmake, it shouldn't be existed.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [ISSUE] [CLOSED] GNU Make package doesn't make a symlink for /usr/bin/gmake
  2024-06-13  6:08 [ISSUE] GNU Make package doesn't make a symlink for /usr/bin/gmake rudzik8
                   ` (4 preceding siblings ...)
  2024-06-14  2:08 ` sgn
@ 2024-06-14  3:37 ` ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: ahesford @ 2024-06-14  3:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

Closed issue by rudzik8 on void-packages repository

https://github.com/void-linux/void-packages/issues/50812

Description:
### Is this a new report?

Yes

### System Info

Void 6.6.32_1 x86_64 AuthenticAMD notuptodate rFFF

### Package(s) Affected

make-4.4.1_1

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Since our `make` implementation is GNU Make, it is really weird for it to not include a symlink for `gmake`.

For example, this is the output of `ls -l /usr/bin/ | grep "make"` on an Ubuntu system with `make` package installed is:
```
lrwxrwxrwx 1 root root           4 Feb 15  2022 gmake -> make
-rwxr-xr-x 1 root root      255696 Feb 15  2022 make
-rwxr-xr-x 1 root root        4905 Feb 15  2022 make-first-existing-target
```
And all `gmake` commands resolve without any problems there.

### Actual behaviour

CMake checks for `gmake` don't pass, its "simple test program" to verify `cc` doesn't compile (because it expects `gmake` to exist, and doesn't find it), and nobody's happy. :(

This is, however, easily fixed by doing `sudo ln -s /usr/bin/make /usr/bin/gmake`.

### Steps to reproduce

Try CMake'ing anything on a new Void install with `make` and `gcc` installed. [In my case, it was Minetest (+ its deps ofc)](https://github.com/minetest/minetest/issues/14746)

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-06-14  3:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-13  6:08 [ISSUE] GNU Make package doesn't make a symlink for /usr/bin/gmake rudzik8
2024-06-14  0:25 ` ahesford
2024-06-14  0:27 ` ahesford
2024-06-14  1:18 ` classabbyamp
2024-06-14  1:41 ` classabbyamp
2024-06-14  2:08 ` sgn
2024-06-14  3:37 ` [ISSUE] [CLOSED] " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).