[PR PATCH] intellij-idea-community-edition: removing unvendored desktop file

[PR PATCH] intellij-idea-community-edition: removing unvendored desktop file

[piekay]

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

There is a new pull request by piekay against master on the void-packages repository

https://github.com/piekay/void-packages remove-unvendored-intellij-files
https://github.com/void-linux/void-packages/pull/50831

intellij-idea-community-edition: removing unvendored desktop file
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/50831.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove-unvendored-intellij-files-50831.patch --]
[-- Type: text/x-diff, Size: 2559 bytes --]

From 68b8999ae53e92d162303487de63a923a5672404 Mon Sep 17 00:00:00 2001
From: Piekay <github@piekay.de>
Date: Fri, 14 Jun 2024 15:45:34 +0200
Subject: [PATCH] intellij-idea-community-edition: removing unvendored desktop
 file

---
 .../files/idea.desktop                           |  8 --------
 srcpkgs/intellij-idea-community-edition/template | 16 ++++++++++++++--
 2 files changed, 14 insertions(+), 10 deletions(-)
 delete mode 100644 srcpkgs/intellij-idea-community-edition/files/idea.desktop

diff --git a/srcpkgs/intellij-idea-community-edition/files/idea.desktop b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
deleted file mode 100644
index 8aeda8fdbe2061..00000000000000
--- a/srcpkgs/intellij-idea-community-edition/files/idea.desktop
+++ /dev/null
@@ -1,8 +0,0 @@
-[Desktop Entry]
-Name=IntelliJ IDEA Community Edition
-Comment=Java integrated development environment by JetBrains
-Exec=/usr/bin/idea %f
-Icon=idea
-Terminal=false
-Type=Application
-Categories=Development;
diff --git a/srcpkgs/intellij-idea-community-edition/template b/srcpkgs/intellij-idea-community-edition/template
index 51f63e256ad213..27e573226aa7d8 100644
--- a/srcpkgs/intellij-idea-community-edition/template
+++ b/srcpkgs/intellij-idea-community-edition/template
@@ -1,7 +1,7 @@
 # Template file for 'intellij-idea-community-edition'
 pkgname=intellij-idea-community-edition
 version=2024.1.2
-revision=1
+revision=2
 archs="x86_64"
 depends="virtual?java-environment giflib libXtst hicolor-icon-theme"
 short_desc="Java integrated development environment by JetBrains"
@@ -15,6 +15,18 @@ nopie=yes
 python_version=3
 skiprdeps="/usr/lib/intellij-idea/plugins/Kotlin/bin/linux/LLDBFrontend"
 
+post_extract() {
+	bsdtar xf lib/app-client.jar entry.desktop
+}
+
+post_patch() {
+	vsed -i -e 's/\$NAME\$/IntelliJ IDEA Community Edition/' entry.desktop
+	vsed -i -e 's/\$ICON\$/idea/' entry.desktop
+	vsed -i -e 's/\$SCRIPT\$/idea/' entry.desktop
+	vsed -i -e 's/\$COMMENT\$/Capable and Ergonomic IDE for JVM/' entry.desktop
+	vsed -i -e 's/\$WM_CLASS\$/jetbrains-idea/' entry.desktop
+}
+
 do_install() {
 	vmkdir usr/bin
 	vmkdir usr/share/doc/intellij-idea
@@ -45,5 +57,5 @@ do_install() {
 	ln -sf /usr/lib/intellij-idea/bin/idea.sh ${DESTDIR}/usr/bin/idea
 	ln -sf /usr/lib/intellij-idea/bin/idea.png ${DESTDIR}/usr/share/pixmaps
 	ln -sf /usr/lib/intellij-idea/bin/idea.svg ${DESTDIR}/usr/share/icons/hicolor/scalable/apps
-	vinstall ${FILESDIR}/idea.desktop 644 usr/share/applications
+	vinstall entry.desktop 644 usr/share/applications idea.desktop
 }

Re: intellij-idea-community-edition: removing unvendored desktop file

[piekay]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by piekay on void-packages repository

https://github.com/void-linux/void-packages/pull/50831#issuecomment-2168099462

Comment:
This patch fixes #49164 for intellij-idea-community-edition.

Adapted from the intellij-idea-ultimate-edition patch

Re: [PR PATCH] [Merged]: intellij-idea-community-edition: removing unvendored desktop file

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

There's a merged pull request on the void-packages repository

intellij-idea-community-edition: removing unvendored desktop file
https://github.com/void-linux/void-packages/pull/50831

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)