Re: [PR PATCH] [Updated] New package: ltfs-2.4.6.1

[maciozo <maciozo@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2715 bytes --]

There is an updated pull request by maciozo against master on the void-packages repository

https://github.com/maciozo/void-packages ltfs-2.4.6.1
https://github.com/void-linux/void-packages/pull/50845

New package: ltfs-2.4.6.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Tested:
* Listing drives
* Formatting
* Mounting drives
* R/W
* Unmounting

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

I have not been able to cross-compile this program due to `pkgdata` complaining about not being able to open its `pkgdata.inc` file.

```
=> ltfs-2.4.6.1_1: running do_build ...
make  all-recursive
make[1]: Entering directory '/builddir/ltfs-2.4.6.1'
Making all in messages
make[2]: Entering directory '/builddir/ltfs-2.4.6.1/messages'
Processing bin_mkltfs
genrb number of files: 3
Unable to open or read "/usr/lib64/icu/73.2/pkgdata.inc" option file. status = U_FILE_ACCESS_ERROR
sh: line 1: oma.c: command not found
-- return status = 32512
Failed to compile oma.c
sh: line 1: ./bin_mkltfs.: No such file or directory
-- return status = 32512
Error generating library file. Failed command:   ./bin_mkltfs. ./bin_mkltfs_dat.o
Error generating package data.
make[2]: *** [Makefile:490: libbin_mkltfs_dat.a] Error 1
make[2]: Leaving directory '/builddir/ltfs-2.4.6.1/messages'
make[1]: *** [Makefile:523: all-recursive] Error 1
make[1]: Leaving directory '/builddir/ltfs-2.4.6.1'
make: *** [Makefile:429: all] Error 2
=> ERROR: ltfs-2.4.6.1_1: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-configure.sh:15
```

The closest relevant issue I could find to this is linked below, but doing the `icu-config` tricks mentioned there did not help.
I'd be very appreciative of any suggestions, because I can't see why this program shouldn't be cross-compilable.

https://github.com/LinearTapeFileSystem/ltfs/issues/419

A patch file from https://github.com/void-linux/void-packages/pull/50845.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ltfs-2.4.6.1-50845.patch --]
[-- Type: text/x-diff, Size: 2027 bytes --]

From ea93b9f781ceb0a88ce1774a1f1c05e3232e0a5c Mon Sep 17 00:00:00 2001
From: maciozo <15807067+maciozo@users.noreply.github.com>
Date: Sun, 16 Jun 2024 02:23:23 +0100
Subject: [PATCH] New package: ltfs-2.4.6.1

---
 srcpkgs/ltfs-devel    |  1 +
 srcpkgs/ltfs/template | 42 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 120000 srcpkgs/ltfs-devel
 create mode 100644 srcpkgs/ltfs/template

diff --git a/srcpkgs/ltfs-devel b/srcpkgs/ltfs-devel
new file mode 120000
index 00000000000000..e4bd37f12078ae
--- /dev/null
+++ b/srcpkgs/ltfs-devel
@@ -0,0 +1 @@
+ltfs
\ No newline at end of file
diff --git a/srcpkgs/ltfs/template b/srcpkgs/ltfs/template
new file mode 100644
index 00000000000000..dbf2392dcbc384
--- /dev/null
+++ b/srcpkgs/ltfs/template
@@ -0,0 +1,42 @@
+# Template file for 'ltfs'
+pkgname=ltfs
+version=2.4.6.1
+revision=1
+_version_suffix=10511
+#archs="i686 x86_64"
+#build_wrksrc=
+build_style=gnu-configure
+#configure_args=""
+#make_build_args=""
+#make_install_args=""
+#conf_files=""
+#make_dirs="/var/log/dir 0755 root root"
+hostmakedepends="automake libtool pkg-config icu"
+makedepends="fuse-devel libuuid-devel libxml2-devel icu icu-devel net-snmp-devel pciutils-devel pcre-devel libsensors-devel libnl3-devel"
+depends="python3-pyxattr"
+short_desc="Reference implementation of the Linear Tape File System"
+maintainer="maciozo <maciozo+voidlinux@maciozo.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/LinearTapeFileSystem/ltfs"
+#changelog=""
+distfiles="https://github.com/LinearTapeFileSystem/ltfs/archive/refs/tags/v${version}-${_version_suffix}.tar.gz"
+checksum=f54fcb014dc06518d3804209fb3bd17f520a075a71e64675cddc46c801509bf6
+python_version=${py3_ver}
+
+pre_configure() {
+	./autogen.sh
+}
+
+post_install() {
+	vlicense LICENSE
+}
+
+ltfs-devel_package() {
+	depends="${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+	}
+}